* [PATCH] ltp: fix rpc build error
@ 2020-12-17 9:55 Kory Maincent
2020-12-17 10:03 ` [OE-core] " Konrad Weihmann
0 siblings, 1 reply; 5+ messages in thread
From: Kory Maincent @ 2020-12-17 9:55 UTC (permalink / raw)
To: openembedded-core; +Cc: thomas.petazzoni
Add support to tirpc tests build.
Export incdir and libdir to have the right path.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-extended/ltp/ltp_20200930.bb
index 7acf15b360..9b17d68f67 100644
--- a/meta/recipes-extended/ltp/ltp_20200930.bb
+++ b/meta/recipes-extended/ltp/ltp_20200930.bb
@@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\
file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
"
-DEPENDS = "attr libaio libcap acl openssl zip-native"
+DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"
DEPENDS_append_libc-musl = " fts "
EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
@@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"
export prefix = "/opt/${PN}"
export exec_prefix = "/opt/${PN}"
+export libdir = "/usr/lib"
+export incdir = "/usr/include"
PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
-# ltp network/rpc test cases ftbfs when libtirpc is found
-EXTRA_OECONF += " --without-tirpc "
do_install(){
install -d ${D}${prefix}/
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] ltp: fix rpc build error
2020-12-17 9:55 [PATCH] ltp: fix rpc build error Kory Maincent
@ 2020-12-17 10:03 ` Konrad Weihmann
2020-12-17 10:25 ` Kory Maincent
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Weihmann @ 2020-12-17 10:03 UTC (permalink / raw)
To: openembedded-core, kory.maincent
On 17.12.20 10:55, Kory Maincent wrote:
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb b/meta/recipes-extended/ltp/ltp_20200930.bb
> index 7acf15b360..9b17d68f67 100644
> --- a/meta/recipes-extended/ltp/ltp_20200930.bb
> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\
> file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
> "
>
> -DEPENDS = "attr libaio libcap acl openssl zip-native"
> +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"
Can we have that as a PACKAGECONFIG entry, please? otherwise I think it
will change the behavior of the existing setups.
Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think
depending on virtual/librpc should be the safest way
> DEPENDS_append_libc-musl = " fts "
> EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
> EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
> @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"
>
> export prefix = "/opt/${PN}"
> export exec_prefix = "/opt/${PN}"
> +export libdir = "/usr/lib"
> +export incdir = "/usr/include"
Those should be ${libdir} and ${incdir} if I'm not mistaken
>
> PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
> EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
> EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
> -# ltp network/rpc test cases ftbfs when libtirpc is found
> -EXTRA_OECONF += " --without-tirpc "
Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being
the default
>
> do_install(){
> install -d ${D}${prefix}/
>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] ltp: fix rpc build error
2020-12-17 10:03 ` [OE-core] " Konrad Weihmann
@ 2020-12-17 10:25 ` Kory Maincent
2020-12-17 10:47 ` Konrad Weihmann
[not found] ` <16517B4086903658.9537@lists.openembedded.org>
0 siblings, 2 replies; 5+ messages in thread
From: Kory Maincent @ 2020-12-17 10:25 UTC (permalink / raw)
To: Konrad Weihmann; +Cc: openembedded-core
Hello Konrad,
On Thu, 17 Dec 2020 11:03:39 +0100
Konrad Weihmann <kweihmann@outlook.com> wrote:
> On 17.12.20 10:55, Kory Maincent wrote:
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb
> > b/meta/recipes-extended/ltp/ltp_20200930.bb index 7acf15b360..9b17d68f67
> > 100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb
> > +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
> > @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\
> > file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f
> > \ "
> >
> > -DEPENDS = "attr libaio libcap acl openssl zip-native"
> > +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"
>
> Can we have that as a PACKAGECONFIG entry, please? otherwise I think it
> will change the behavior of the existing setups.
I assumed the tirpc was disable because they did not manage to build with
it "# ltp network/rpc test cases ftbfs when libtirpc is found".
But if you prefer I can add it to PACKAGECONFIG.
> Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think
> depending on virtual/librpc should be the safest way
Ok
>
> > DEPENDS_append_libc-musl = " fts "
> > EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
> > EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
> > @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"
> >
> > export prefix = "/opt/${PN}"
> > export exec_prefix = "/opt/${PN}"
> > +export libdir = "/usr/lib"
> > +export incdir = "/usr/include"
>
> Those should be ${libdir} and ${incdir} if I'm not mistaken
The exporting of ${prefix} change the value of ${libdir} and ${incdir}
therefore I set them up again. If I don't set it, pkgconfig can not find
libtirpc.
>
> >
> > PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
>
>
> > EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
> > EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
> > -# ltp network/rpc test cases ftbfs when libtirpc is found
> > -EXTRA_OECONF += " --without-tirpc "
>
> Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being
> the default
Ok,
Köry
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] ltp: fix rpc build error
2020-12-17 10:25 ` Kory Maincent
@ 2020-12-17 10:47 ` Konrad Weihmann
[not found] ` <16517B4086903658.9537@lists.openembedded.org>
1 sibling, 0 replies; 5+ messages in thread
From: Konrad Weihmann @ 2020-12-17 10:47 UTC (permalink / raw)
To: Köry Maincent; +Cc: openembedded-core
On 17.12.20 11:25, Köry Maincent wrote:
> Hello Konrad,
>
> On Thu, 17 Dec 2020 11:03:39 +0100
> Konrad Weihmann <kweihmann@outlook.com> wrote:
>
>> On 17.12.20 10:55, Kory Maincent wrote:
>>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>>> ---
>>> meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb
>>> b/meta/recipes-extended/ltp/ltp_20200930.bb index 7acf15b360..9b17d68f67
>>> 100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb
>>> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
>>> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\
>>> file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f
>>> \ "
>>>
>>> -DEPENDS = "attr libaio libcap acl openssl zip-native"
>>> +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"
>>
>> Can we have that as a PACKAGECONFIG entry, please? otherwise I think it
>> will change the behavior of the existing setups.
>
> I assumed the tirpc was disable because they did not manage to build with
> it "# ltp network/rpc test cases ftbfs when libtirpc is found".
> But if you prefer I can add it to PACKAGECONFIG.
>
>> Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think
>> depending on virtual/librpc should be the safest way
>
> Ok
>
>>
>>> DEPENDS_append_libc-musl = " fts "
>>> EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
>>> EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
>>> @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"
>>>
>>> export prefix = "/opt/${PN}"
>>> export exec_prefix = "/opt/${PN}"
>>> +export libdir = "/usr/lib"
>>> +export incdir = "/usr/include"
>>
>> Those should be ${libdir} and ${incdir} if I'm not mistaken
>
> The exporting of ${prefix} change the value of ${libdir} and ${incdir}
> therefore I set them up again. If I don't set it, pkgconfig can not find
> libtirpc.
>
I see, then please just export ${libdir} and ${incdir} before the prefix
export and it should be fine
>>
>>>
>>> PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
>>
>>
>>> EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
>>> EXTRA_OECONF = " --with-realtime-testsuite --with-open-posix-testsuite "
>>> -# ltp network/rpc test cases ftbfs when libtirpc is found
>>> -EXTRA_OECONF += " --without-tirpc "
>>
>> Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being
>> the default
>
> Ok,
>
> Köry
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <16517B4086903658.9537@lists.openembedded.org>]
* Re: [OE-core] [PATCH] ltp: fix rpc build error
[not found] ` <16517B4086903658.9537@lists.openembedded.org>
@ 2020-12-17 10:53 ` Konrad Weihmann
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Weihmann @ 2020-12-17 10:53 UTC (permalink / raw)
To: openembedded-core, Köry Maincent
On 17.12.20 11:47, Konrad Weihmann wrote:
> On 17.12.20 11:25, Köry Maincent wrote:
>> Hello Konrad,
>>
>> On Thu, 17 Dec 2020 11:03:39 +0100
>> Konrad Weihmann <kweihmann@outlook.com> wrote:
>>
>>> On 17.12.20 10:55, Kory Maincent wrote:
>>>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
>>>> ---
>>>> meta/recipes-extended/ltp/ltp_20200930.bb | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-extended/ltp/ltp_20200930.bb
>>>> b/meta/recipes-extended/ltp/ltp_20200930.bb index
>>>> 7acf15b360..9b17d68f67
>>>> 100644 --- a/meta/recipes-extended/ltp/ltp_20200930.bb
>>>> +++ b/meta/recipes-extended/ltp/ltp_20200930.bb
>>>> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "\
>>>>
>>>> file://utils/benchmark/kernbench-0.42/COPYING;md5=94d55d512a9ba36caa9b7df079bae19f
>>>>
>>>> \ "
>>>> -DEPENDS = "attr libaio libcap acl openssl zip-native"
>>>> +DEPENDS = "attr libaio libcap acl openssl zip-native libtirpc"
>>>
>>> Can we have that as a PACKAGECONFIG entry, please? otherwise I think it
>>> will change the behavior of the existing setups.
>>
>> I assumed the tirpc was disable because they did not manage to build with
>> it "# ltp network/rpc test cases ftbfs when libtirpc is found".
>> But if you prefer I can add it to PACKAGECONFIG.
>>
>>> Also the dependency has a `PROVIDES = "virtual/librpc"`, so I think
>>> depending on virtual/librpc should be the safest way
>>
>> Ok
>>
>>>
>>>> DEPENDS_append_libc-musl = " fts "
>>>> EXTRA_OEMAKE_append_libc-musl = " LIBC=musl "
>>>> EXTRA_OECONF_append_libc-musl = " LIBS=-lfts "
>>>> @@ -44,12 +44,12 @@ TARGET_CC_ARCH += "${LDFLAGS}"
>>>> export prefix = "/opt/${PN}"
>>>> export exec_prefix = "/opt/${PN}"
>>>> +export libdir = "/usr/lib"
>>>> +export incdir = "/usr/include"
>>>
>>> Those should be ${libdir} and ${incdir} if I'm not mistaken
>>
>> The exporting of ${prefix} change the value of ${libdir} and ${incdir}
>> therefore I set them up again. If I don't set it, pkgconfig can not find
>> libtirpc.
>>
> I see, then please just export ${libdir} and ${incdir} before the prefix
> export and it should be fine
for instance that here
export libdir := "${exec_prefix}/${baselib}"
export incdir := "${exec_prefix}/include"
export prefix = "/opt/${PN}"
worked for me
>>>
>>>> PACKAGECONFIG[numa] = "--with-numa, --without-numa, numactl,"
>>>
>>>
>>>> EXTRA_AUTORECONF += "-I ${S}/testcases/realtime/m4"
>>>> EXTRA_OECONF = " --with-realtime-testsuite
>>>> --with-open-posix-testsuite "
>>>> -# ltp network/rpc test cases ftbfs when libtirpc is found
>>>> -EXTRA_OECONF += " --without-tirpc "
>>>
>>> Should be part of a PACKAGECONFIG entry, with `--without-tirpc` being
>>> the default
>>
>> Ok,
>>
>> Köry
>>
>>
>>
>>
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-17 10:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 9:55 [PATCH] ltp: fix rpc build error Kory Maincent
2020-12-17 10:03 ` [OE-core] " Konrad Weihmann
2020-12-17 10:25 ` Kory Maincent
2020-12-17 10:47 ` Konrad Weihmann
[not found] ` <16517B4086903658.9537@lists.openembedded.org>
2020-12-17 10:53 ` Konrad Weihmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.