From: Hongxing Zhu <hongxing.zhu@nxp.com> To: Bjorn Helgaas <helgaas@kernel.org> Cc: "l.stach@pengutronix.de" <l.stach@pengutronix.de>, "bhelgaas@google.com" <bhelgaas@google.com>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH v1] PCI: imx6: Set MSI enable bit of RC in resume Date: Thu, 3 Nov 2022 06:26:33 +0000 [thread overview] Message-ID: <AS8PR04MB86769FFF542FF025047221C18C389@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20221102231037.GA6902@bhelgaas> > -----Original Message----- > From: Bjorn Helgaas <helgaas@kernel.org> > Sent: 2022年11月3日 7:11 > To: Hongxing Zhu <hongxing.zhu@nxp.com> > Cc: l.stach@pengutronix.de; bhelgaas@google.com; > lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH v1] PCI: imx6: Set MSI enable bit of RC in resume > > On Tue, Nov 01, 2022 at 03:59:55PM +0800, Richard Zhu wrote: > > The MSI Enable bit controls delivery of MSI interrupts from components > > below the Root Port. This bit might lost during the suspend, should be > > re-configured during resume. > > Just out of curiosity, why would this bit "get lost" during suspend? > > Don't the normal save and restore in the suspend/resume paths take care of > this? Are there other bits that might get lost? Hi Bjorn: Thanks for your care. The controller might be reset to the known stat during the re-initialization in the resume path, I think. dw_pcie_setup_rc() configures most of the controller setting during resume. It seems that this bit is i.MX PCIe special, should be configured in both the probe and suspend/resume. Best Regards Richard Zhu > > > Encapsulate the MSI enable set into a standalone function, and invoke > > it in both probe and resume. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > drivers/pci/controller/dwc/pci-imx6.c | 24 +++++++++++++++++------- > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > b/drivers/pci/controller/dwc/pci-imx6.c > > index 2616585ca5f8..dba15546075f 100644 > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > @@ -1041,6 +1041,21 @@ static void imx6_pcie_pm_turnoff(struct > imx6_pcie *imx6_pcie) > > usleep_range(1000, 10000); > > } > > > > +static void pci_imx_set_msi_en(struct dw_pcie *pci) { > > + u8 offset; > > + u16 val; > > + > > + if (pci_msi_enabled()) { > > + offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); > > + dw_pcie_dbi_ro_wr_en(pci); > > + val = dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS); > > + val |= PCI_MSI_FLAGS_ENABLE; > > + dw_pcie_writew_dbi(pci, offset + PCI_MSI_FLAGS, val); > > + dw_pcie_dbi_ro_wr_dis(pci); > > + } > > +} > > + > > static int imx6_pcie_suspend_noirq(struct device *dev) { > > struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); @@ -1073,6 > > +1088,7 @@ static int imx6_pcie_resume_noirq(struct device *dev) > > if (imx6_pcie->link_is_up) > > imx6_pcie_start_link(imx6_pcie->pci); > > > > + pci_imx_set_msi_en(imx6_pcie->pci); > > return 0; > > } > > > > @@ -1090,7 +1106,6 @@ static int imx6_pcie_probe(struct platform_device > *pdev) > > struct resource *dbi_base; > > struct device_node *node = dev->of_node; > > int ret; > > - u16 val; > > > > imx6_pcie = devm_kzalloc(dev, sizeof(*imx6_pcie), GFP_KERNEL); > > if (!imx6_pcie) > > @@ -1282,12 +1297,7 @@ static int imx6_pcie_probe(struct > platform_device *pdev) > > if (ret < 0) > > return ret; > > > > - if (pci_msi_enabled()) { > > - u8 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); > > - val = dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS); > > - val |= PCI_MSI_FLAGS_ENABLE; > > - dw_pcie_writew_dbi(pci, offset + PCI_MSI_FLAGS, val); > > - } > > + pci_imx_set_msi_en(pci); > > > > return 0; > > } > > -- > > 2.25.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists > > .infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&data=05%7 > C0 > > > 1%7Chongxing.zhu%40nxp.com%7C4454f7f5d1d0438d009908dabd27767e% > 7C686ea1 > > > d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638030274437186510%7CUnk > nown%7CTW > > > FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > CI6 > > > Mn0%3D%7C3000%7C%7C%7C&sdata=gfiPPlezSSocyNTpq0oKnk5rwwm > hpmWCszaHa > > YWLhoI%3D&reserved=0
WARNING: multiple messages have this Message-ID (diff)
From: Hongxing Zhu <hongxing.zhu@nxp.com> To: Bjorn Helgaas <helgaas@kernel.org> Cc: "l.stach@pengutronix.de" <l.stach@pengutronix.de>, "bhelgaas@google.com" <bhelgaas@google.com>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH v1] PCI: imx6: Set MSI enable bit of RC in resume Date: Thu, 3 Nov 2022 06:26:33 +0000 [thread overview] Message-ID: <AS8PR04MB86769FFF542FF025047221C18C389@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20221102231037.GA6902@bhelgaas> > -----Original Message----- > From: Bjorn Helgaas <helgaas@kernel.org> > Sent: 2022年11月3日 7:11 > To: Hongxing Zhu <hongxing.zhu@nxp.com> > Cc: l.stach@pengutronix.de; bhelgaas@google.com; > lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH v1] PCI: imx6: Set MSI enable bit of RC in resume > > On Tue, Nov 01, 2022 at 03:59:55PM +0800, Richard Zhu wrote: > > The MSI Enable bit controls delivery of MSI interrupts from components > > below the Root Port. This bit might lost during the suspend, should be > > re-configured during resume. > > Just out of curiosity, why would this bit "get lost" during suspend? > > Don't the normal save and restore in the suspend/resume paths take care of > this? Are there other bits that might get lost? Hi Bjorn: Thanks for your care. The controller might be reset to the known stat during the re-initialization in the resume path, I think. dw_pcie_setup_rc() configures most of the controller setting during resume. It seems that this bit is i.MX PCIe special, should be configured in both the probe and suspend/resume. Best Regards Richard Zhu > > > Encapsulate the MSI enable set into a standalone function, and invoke > > it in both probe and resume. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > drivers/pci/controller/dwc/pci-imx6.c | 24 +++++++++++++++++------- > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > b/drivers/pci/controller/dwc/pci-imx6.c > > index 2616585ca5f8..dba15546075f 100644 > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > @@ -1041,6 +1041,21 @@ static void imx6_pcie_pm_turnoff(struct > imx6_pcie *imx6_pcie) > > usleep_range(1000, 10000); > > } > > > > +static void pci_imx_set_msi_en(struct dw_pcie *pci) { > > + u8 offset; > > + u16 val; > > + > > + if (pci_msi_enabled()) { > > + offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); > > + dw_pcie_dbi_ro_wr_en(pci); > > + val = dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS); > > + val |= PCI_MSI_FLAGS_ENABLE; > > + dw_pcie_writew_dbi(pci, offset + PCI_MSI_FLAGS, val); > > + dw_pcie_dbi_ro_wr_dis(pci); > > + } > > +} > > + > > static int imx6_pcie_suspend_noirq(struct device *dev) { > > struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); @@ -1073,6 > > +1088,7 @@ static int imx6_pcie_resume_noirq(struct device *dev) > > if (imx6_pcie->link_is_up) > > imx6_pcie_start_link(imx6_pcie->pci); > > > > + pci_imx_set_msi_en(imx6_pcie->pci); > > return 0; > > } > > > > @@ -1090,7 +1106,6 @@ static int imx6_pcie_probe(struct platform_device > *pdev) > > struct resource *dbi_base; > > struct device_node *node = dev->of_node; > > int ret; > > - u16 val; > > > > imx6_pcie = devm_kzalloc(dev, sizeof(*imx6_pcie), GFP_KERNEL); > > if (!imx6_pcie) > > @@ -1282,12 +1297,7 @@ static int imx6_pcie_probe(struct > platform_device *pdev) > > if (ret < 0) > > return ret; > > > > - if (pci_msi_enabled()) { > > - u8 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI); > > - val = dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS); > > - val |= PCI_MSI_FLAGS_ENABLE; > > - dw_pcie_writew_dbi(pci, offset + PCI_MSI_FLAGS, val); > > - } > > + pci_imx_set_msi_en(pci); > > > > return 0; > > } > > -- > > 2.25.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists > > .infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&data=05%7 > C0 > > > 1%7Chongxing.zhu%40nxp.com%7C4454f7f5d1d0438d009908dabd27767e% > 7C686ea1 > > > d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638030274437186510%7CUnk > nown%7CTW > > > FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV > CI6 > > > Mn0%3D%7C3000%7C%7C%7C&sdata=gfiPPlezSSocyNTpq0oKnk5rwwm > hpmWCszaHa > > YWLhoI%3D&reserved=0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-03 6:26 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-01 7:59 [PATCH v1] PCI: imx6: Set MSI enable bit of RC in resume Richard Zhu 2022-11-01 7:59 ` Richard Zhu 2022-11-02 23:10 ` Bjorn Helgaas 2022-11-02 23:10 ` Bjorn Helgaas 2022-11-03 6:26 ` Hongxing Zhu [this message] 2022-11-03 6:26 ` Hongxing Zhu 2022-11-25 2:07 ` Hongxing Zhu 2022-11-25 2:07 ` Hongxing Zhu 2022-11-25 10:19 ` Lucas Stach 2022-11-25 10:19 ` Lucas Stach 2022-11-28 3:45 ` Hongxing Zhu 2022-11-28 3:45 ` Hongxing Zhu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8PR04MB86769FFF542FF025047221C18C389@AS8PR04MB8676.eurprd04.prod.outlook.com \ --to=hongxing.zhu@nxp.com \ --cc=bhelgaas@google.com \ --cc=helgaas@kernel.org \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.