* Re: [PATCH] net/dpaa2: fix dpdmux default interface
2022-03-29 20:26 [PATCH] net/dpaa2: fix dpdmux default interface Tianli Lai
@ 2022-03-29 13:30 ` Hemant Agrawal
2022-03-29 13:45 ` Hemant Agrawal
2022-03-29 22:01 ` [PATCH v2] " Tianli Lai
1 sibling, 1 reply; 6+ messages in thread
From: Hemant Agrawal @ 2022-03-29 13:30 UTC (permalink / raw)
To: Tianli Lai, dev; +Cc: Hemant Agrawal, Sachin Saxena
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
On 3/30/2022 1:56 AM, Tianli Lai wrote:
> if dpdmux objects created by restool tools with
> the argument "--default-if=<if-id-number>", this
> function would change it to 1
>
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
> drivers/net/dpaa2/dpaa2_mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
> index bd4596b891..e8689a7832 100644
> --- a/drivers/net/dpaa2/dpaa2_mux.c
> +++ b/drivers/net/dpaa2/dpaa2_mux.c
> @@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused,
> }
>
> ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux, CMD_PRI_LOW,
> - dpdmux_dev->token, 1);
> + dpdmux_dev->token, attr.default_if);
> if (ret) {
> DPAA2_PMD_ERR("setting default interface failed in %s",
> __func__);
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] net/dpaa2: fix dpdmux default interface
2022-03-29 13:30 ` Hemant Agrawal
@ 2022-03-29 13:45 ` Hemant Agrawal
0 siblings, 0 replies; 6+ messages in thread
From: Hemant Agrawal @ 2022-03-29 13:45 UTC (permalink / raw)
To: Hemant Agrawal, Tianli Lai, dev; +Cc: Sachin Saxena (OSS)
BTW, will you please add following fix tags to your commit message
Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization and configuration")
Cc: nipun.gupta@nxp.com
> -----Original Message-----
> From: Hemant Agrawal (OSS) <hemant.agrawal@oss.nxp.com>
> Sent: Tuesday, March 29, 2022 7:01 PM
> To: Tianli Lai <laitianli@tom.com>; dev@dpdk.org
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena (OSS)
> <sachin.saxena@oss.nxp.com>
> Subject: Re: [PATCH] net/dpaa2: fix dpdmux default interface
> Importance: High
>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
>
> On 3/30/2022 1:56 AM, Tianli Lai wrote:
> > if dpdmux objects created by restool tools with the argument
> > "--default-if=<if-id-number>", this function would change it to 1
> >
> > Signed-off-by: Tianli Lai <laitianli@tom.com>
> > ---
> > drivers/net/dpaa2/dpaa2_mux.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/dpaa2/dpaa2_mux.c
> > b/drivers/net/dpaa2/dpaa2_mux.c index bd4596b891..e8689a7832 100644
> > --- a/drivers/net/dpaa2/dpaa2_mux.c
> > +++ b/drivers/net/dpaa2/dpaa2_mux.c
> > @@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd
> __rte_unused,
> > }
> >
> > ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux,
> CMD_PRI_LOW,
> > - dpdmux_dev->token, 1);
> > + dpdmux_dev->token, attr.default_if);
> > if (ret) {
> > DPAA2_PMD_ERR("setting default interface failed in %s",
> > __func__);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] net/dpaa2: fix dpdmux default interface
@ 2022-03-29 20:26 Tianli Lai
2022-03-29 13:30 ` Hemant Agrawal
2022-03-29 22:01 ` [PATCH v2] " Tianli Lai
0 siblings, 2 replies; 6+ messages in thread
From: Tianli Lai @ 2022-03-29 20:26 UTC (permalink / raw)
To: dev; +Cc: Hemant Agrawal, Sachin Saxena
if dpdmux objects created by restool tools with
the argument "--default-if=<if-id-number>", this
function would change it to 1
Signed-off-by: Tianli Lai <laitianli@tom.com>
---
drivers/net/dpaa2/dpaa2_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
index bd4596b891..e8689a7832 100644
--- a/drivers/net/dpaa2/dpaa2_mux.c
+++ b/drivers/net/dpaa2/dpaa2_mux.c
@@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused,
}
ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux, CMD_PRI_LOW,
- dpdmux_dev->token, 1);
+ dpdmux_dev->token, attr.default_if);
if (ret) {
DPAA2_PMD_ERR("setting default interface failed in %s",
__func__);
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] net/dpaa2: fix dpdmux default interface
2022-03-29 20:26 [PATCH] net/dpaa2: fix dpdmux default interface Tianli Lai
2022-03-29 13:30 ` Hemant Agrawal
@ 2022-03-29 22:01 ` Tianli Lai
2022-03-31 10:19 ` Hemant Agrawal
1 sibling, 1 reply; 6+ messages in thread
From: Tianli Lai @ 2022-03-29 22:01 UTC (permalink / raw)
To: dev; +Cc: hemant.agrawal, nipun.gupta, Sachin Saxena, Shreyansh Jain
if dpdmux objects created by restool tools with
the argument "--default-if=<if-id-number>", this
function would change it to 1
Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization and configuration")
Cc: nipun.gupta@nxp.com
Signed-off-by: Tianli Lai <laitianli@tom.com>
---
drivers/net/dpaa2/dpaa2_mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
index bd4596b891..e8689a7832 100644
--- a/drivers/net/dpaa2/dpaa2_mux.c
+++ b/drivers/net/dpaa2/dpaa2_mux.c
@@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused,
}
ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux, CMD_PRI_LOW,
- dpdmux_dev->token, 1);
+ dpdmux_dev->token, attr.default_if);
if (ret) {
DPAA2_PMD_ERR("setting default interface failed in %s",
__func__);
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net/dpaa2: fix dpdmux default interface
2022-03-29 22:01 ` [PATCH v2] " Tianli Lai
@ 2022-03-31 10:19 ` Hemant Agrawal
2022-04-07 8:33 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Hemant Agrawal @ 2022-03-31 10:19 UTC (permalink / raw)
To: Tianli Lai, dev
Cc: hemant.agrawal, nipun.gupta, Sachin Saxena, Shreyansh Jain
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
On 3/30/2022 3:31 AM, Tianli Lai wrote:
> if dpdmux objects created by restool tools with
> the argument "--default-if=<if-id-number>", this
> function would change it to 1
>
> Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization and configuration")
> Cc: nipun.gupta@nxp.com
>
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
> drivers/net/dpaa2/dpaa2_mux.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c
> index bd4596b891..e8689a7832 100644
> --- a/drivers/net/dpaa2/dpaa2_mux.c
> +++ b/drivers/net/dpaa2/dpaa2_mux.c
> @@ -296,7 +296,7 @@ dpaa2_create_dpdmux_device(int vdev_fd __rte_unused,
> }
>
> ret = dpdmux_if_set_default(&dpdmux_dev->dpdmux, CMD_PRI_LOW,
> - dpdmux_dev->token, 1);
> + dpdmux_dev->token, attr.default_if);
> if (ret) {
> DPAA2_PMD_ERR("setting default interface failed in %s",
> __func__);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net/dpaa2: fix dpdmux default interface
2022-03-31 10:19 ` Hemant Agrawal
@ 2022-04-07 8:33 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2022-04-07 8:33 UTC (permalink / raw)
To: Tianli Lai
Cc: dev, hemant.agrawal, nipun.gupta, Sachin Saxena, Shreyansh Jain,
hemant.agrawal
31/03/2022 12:19, Hemant Agrawal:
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> On 3/30/2022 3:31 AM, Tianli Lai wrote:
> > if dpdmux objects created by restool tools with
> > the argument "--default-if=<if-id-number>", this
> > function would change it to 1
> >
> > Fixes: 1def64c2d79e ("net/dpaa2: add dpdmux initialization and configuration")
> > Cc: nipun.gupta@nxp.com
> >
> > Signed-off-by: Tianli Lai <laitianli@tom.com>
Applied in next-net, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-07 8:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-29 20:26 [PATCH] net/dpaa2: fix dpdmux default interface Tianli Lai
2022-03-29 13:30 ` Hemant Agrawal
2022-03-29 13:45 ` Hemant Agrawal
2022-03-29 22:01 ` [PATCH v2] " Tianli Lai
2022-03-31 10:19 ` Hemant Agrawal
2022-04-07 8:33 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.