[PATCH 0/3] Populate entries for 4.17

[PATCH 0/3] Populate entries for 4.17

[Henry Wang]

Hello,

The following changes are preparation work for the 4.17 release. This
is my first pass at the log for the release, it's likely missing more
entries.

I'm Ccing all maintainers in this cover letter and also in patch #2 for
further feedback on missing items.

Thanks,
Henry

Henry Wang (3):
  CHANGELOG: Update link for RELEASE-4.16.0
  CHANGELOG: Add missing entries for work during the 4.17 release
  CHANGELOG: Start new "unstable" section

 CHANGELOG.md | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

-- 
2.25.1

[PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0

[Henry Wang]

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5e4bae5f35..adbbb216fa 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,7 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ### Removed / support downgraded
  - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options
 
-## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02
+## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.16.0) - 2021-12-02
 
 ### Removed
  - XENSTORED_ROOTDIR environment variable from configuartion files and
-- 
2.25.1

[PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Henry Wang]

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
 CHANGELOG.md | 29 +++++++++++++++++++++++++++--
 1 file changed, 27 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index adbbb216fa..fa8cc476b3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,16 +4,41 @@ Notable changes to Xen will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
-## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
+## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-??
 
 ### Changed
  - On x86 "vga=current" can now be used together with GrUB2's gfxpayload setting. Note that
    this requires use of "multiboot2" (and "module2") as the GrUB commands loading Xen.
+ - The "gnttab" option now has a new command line sub-option for disabling the
+   GNTTABOP_transfer functionality.
+ - The x86 MCE command line option info is now updated.
 
 ### Added / support upgraded
+ - Out-of-tree builds for the hypervisor now supported.
+ - The project has officially adopted 4 directives and 24 rules of MISRA-C,
+   added MISRA-C checker build integration, and defined how to document
+   deviations.
  - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones
    when they don't share page tables with the CPU (HAP / EPT / NPT).
- - Support VIRT_SSBD feature for HVM guests on AMD.
+ - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for
+   SVM guests.
+ - Improved TSC, CPU frequency calibration and APIC on x86.
+ - Improved support for CET Indirect Branch Tracking on x86.
+ - Improved mwait-idle support for SPR and ADL on x86.
+ - Extend security support for hosts to 12 TiB of memory on x86.
+ - Add command line option to set cpuid parameters for dom0 at boot time on x86.
+ - Improved static configuration options on Arm.
+ - cpupools can be specified at boot using device tree on Arm.
+ - It is possible to use PV drivers with dom0less guests, allowing statically
+   booted dom0less guests with PV devices.
+ - On Arm, p2m structures are now allocated out of a pool of memory set aside at
+   domain creation.
+ - Improved mitigations against Spectre-BHB on Arm.
+ - Add support for VirtIO toolstack on Arm.
+ - Allow setting the number of CPUs to activate at runtime from command line
+   option on Arm.
+ - Improved toolstack build system.
+ - Add Xue - console over USB 3 Debug Capability.
 
 ### Removed / support downgraded
  - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options
-- 
2.25.1

[PATCH 3/3] CHANGELOG: Start new "unstable" section

[Henry Wang]

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa8cc476b3..d2ed1fdcb9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
+## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
+
 ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-??
 
 ### Changed
-- 
2.25.1

Re: [PATCH 3/3] CHANGELOG: Start new "unstable" section

[Julien Grall]

Hi Henry,

On 11/11/2022 11:22, Henry Wang wrote:
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

> ---
>   CHANGELOG.md | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index fa8cc476b3..d2ed1fdcb9 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file.
>   
>   The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>   
> +## [unstable UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD

AFAICT, this patch should only be merged after we branched for 4.17.

> +
>   ## [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2022-11-??
>   
>   ### Changed

Cheers,

-- 
Julien Grall

Re: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0

[Julien Grall]

Hi Henry,

On 11/11/2022 11:22, Henry Wang wrote:
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>

Acked-by: Julien Grall <jgrall@amazon.com>

This also wants to be backported to staging-4.16.

Cheers,

> ---
>   CHANGELOG.md | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 5e4bae5f35..adbbb216fa 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -18,7 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>   ### Removed / support downgraded
>    - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap" command line options
>   
> -## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - 2021-12-02
> +## [4.16.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.16.0) - 2021-12-02
>   
>   ### Removed
>    - XENSTORED_ROOTDIR environment variable from configuartion files and

-- 
Julien Grall

RE: [PATCH 3/3] CHANGELOG: Start new "unstable" section

[Henry Wang]

Hi Julien,

> -----Original Message-----
> Subject: Re: [PATCH 3/3] CHANGELOG: Start new "unstable" section
> 
> Hi Henry,
> 
> On 11/11/2022 11:22, Henry Wang wrote:
> > Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> 
> Acked-by: Julien Grall <jgrall@amazon.com>

Thanks very much!

> 
> > ---
> >   CHANGELOG.md | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/CHANGELOG.md b/CHANGELOG.md
> > index fa8cc476b3..d2ed1fdcb9 100644
> > --- a/CHANGELOG.md
> > +++ b/CHANGELOG.md
> > @@ -4,6 +4,8 @@ Notable changes to Xen will be documented in this file.
> >
> >   The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> >
> > +## [unstable
> UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=stagin
> g) - TBD
> 
> AFAICT, this patch should only be merged after we branched for 4.17.

Yes I fully agree. I was just starting early in case I forgot this or some unexpected
stuff...

Kind regards,
Henry

> 
> > +
> >   ##
> [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) -
> 2022-11-??
> >
> >   ### Changed
> 
> Cheers,
> 
> --
> Julien Grall

Re: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Jan Beulich]

(reducing the Cc list to just xen-devel@)

On 11.11.2022 12:22, Henry Wang wrote:
>  ### Added / support upgraded
> + - Out-of-tree builds for the hypervisor now supported.
> + - The project has officially adopted 4 directives and 24 rules of MISRA-C,
> +   added MISRA-C checker build integration, and defined how to document
> +   deviations.
>   - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH ones
>     when they don't share page tables with the CPU (HAP / EPT / NPT).
> - - Support VIRT_SSBD feature for HVM guests on AMD.
> + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL feature for
> +   SVM guests.
> + - Improved TSC, CPU frequency calibration and APIC on x86.

Maybe better "Improved TSC, CPU, and APIC clock frequency calibration on x86"?

> + - Improved support for CET Indirect Branch Tracking on x86.
> + - Improved mwait-idle support for SPR and ADL on x86.

SPR and ADL support is new in the driver, not improved.

Jan

Re: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0

[Christian Lindig]

> On 11 Nov 2022, at 11:22, Henry Wang <Henry.Wang@arm.com> wrote:
> 
> Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> ---
> CHANGELOG.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Christian Lindig <christian.lindig@citrix.com>

Hi Henry,

The changes don’t seem to be specific to the OCaml tools/ part that I care about and so not sure if you were looking for an an Ack but happy to provide for this and your 2 other CHANGELOG patches.

— C

RE: [PATCH 1/3] CHANGELOG: Update link for RELEASE-4.16.0

[Henry Wang]

Hi Christian,

(trim the CC list to avoid spamming)

> -----Original Message-----
> From: Christian Lindig <christian.lindig@citrix.com>
> > On 11 Nov 2022, at 11:22, Henry Wang <Henry.Wang@arm.com> wrote:
> >
> > Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> > ---
> > CHANGELOG.md | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Christian Lindig <christian.lindig@citrix.com>
> 
> Hi Henry,
> 
> The changes don’t seem to be specific to the OCaml tools/ part that I care
> about and so not sure if you were looking for an an Ack but happy to provide
> for this and your 2 other CHANGELOG patches.

Thank you very much! I will keep your ack for this patch.

For the other two, I might be wrong but I think you only need to raise your
concerns and objections about the patches if you have any. Thanks :)

Kind regards,
Henry 


> 
> — C

RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Henry Wang]

Hi Jan,

> -----Original Message-----
> Subject: Re: [PATCH 2/3] CHANGELOG: Add missing entries for work during
> the 4.17 release
> 
> (reducing the Cc list to just xen-devel@)

Thanks for doing this :) I was just not sure who would be interested in the series.

> 
> On 11.11.2022 12:22, Henry Wang wrote:
> >  ### Added / support upgraded
> > + - Out-of-tree builds for the hypervisor now supported.
> > + - The project has officially adopted 4 directives and 24 rules of MISRA-C,
> > +   added MISRA-C checker build integration, and defined how to document
> > +   deviations.
> >   - IOMMU superpage support on x86, affecting PV guests as well as
> HVM/PVH ones
> >     when they don't share page tables with the CPU (HAP / EPT / NPT).
> > - - Support VIRT_SSBD feature for HVM guests on AMD.
> > + - Support VIRT_SSBD feature for HVM guests on AMD and
> MSR_SPEC_CTRL feature for
> > +   SVM guests.
> > + - Improved TSC, CPU frequency calibration and APIC on x86.
> 
> Maybe better "Improved TSC, CPU, and APIC clock frequency calibration on
> x86"?

Thanks for your feedback for this and my previous email. They are really
useful.

Yes of course, I guess I misunderstood the original series and thought
there is another improvement for the APIC.

> 
> > + - Improved support for CET Indirect Branch Tracking on x86.
> > + - Improved mwait-idle support for SPR and ADL on x86.
> 
> SPR and ADL support is new in the driver, not improved.

I will correct this in V2.

Another question for adding another entry for x86 that worth to
brag about a little bit: I did another dig into patchwork and found that
this [1] might be a good candidate. IIUC __ro_after_init is a good
feature that both x86 and Arm have leveraged in different level today,
so probably the __ro_after_init might worth an entry in CHANGELOG.

However I saw your comments in [1] so I am not really sure if you are
happy with that, maybe we need to change the wording a little bit to
remove your concern? Would you mind sharing some thoughts?

Thanks!

[1] https://patchwork.kernel.org/project/xen-devel/patch/20220309123936.16991-3-andrew.cooper3@citrix.com/

Kind regards,
Henry
> 
> Jan

Re: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Jan Beulich]

On 11.11.2022 14:58, Henry Wang wrote:
> Another question for adding another entry for x86 that worth to
> brag about a little bit: I did another dig into patchwork and found that
> this [1] might be a good candidate. IIUC __ro_after_init is a good
> feature that both x86 and Arm have leveraged in different level today,
> so probably the __ro_after_init might worth an entry in CHANGELOG.
> 
> However I saw your comments in [1] so I am not really sure if you are
> happy with that, maybe we need to change the wording a little bit to
> remove your concern? Would you mind sharing some thoughts?

My view hasn't changed, but if Andrew and Roger think this should be mentioned,
then I'm not going to stand in the way.

Jan

> [1] https://patchwork.kernel.org/project/xen-devel/patch/20220309123936.16991-3-andrew.cooper3@citrix.com/
> 
> Kind regards,
> Henry
>>
>> Jan

RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Henry Wang]

Hi Jan,

> -----Original Message-----
> On 11.11.2022 14:58, Henry Wang wrote:
> > Another question for adding another entry for x86 that worth to
> > brag about a little bit: I did another dig into patchwork and found that
> > this [1] might be a good candidate. IIUC __ro_after_init is a good
> > feature that both x86 and Arm have leveraged in different level today,
> > so probably the __ro_after_init might worth an entry in CHANGELOG.
> >
> > However I saw your comments in [1] so I am not really sure if you are
> > happy with that, maybe we need to change the wording a little bit to
> > remove your concern? Would you mind sharing some thoughts?
> 
> My view hasn't changed, but if Andrew and Roger think this should be
> mentioned,
> then I'm not going to stand in the way.

Thanks for the confirmation. I will wait for Roger's back on next Monday
then.

Kind regards,
Henry

> 
> Jan
> 
> > [1] https://patchwork.kernel.org/project/xen-
> devel/patch/20220309123936.16991-3-andrew.cooper3@citrix.com/
> >
> > Kind regards,
> > Henry
> >>
> >> Jan

Re: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Oleksandr Tyshchenko]

[-- Attachment #1: Type: text/plain, Size: 3361 bytes --]

On Fri, Nov 11, 2022 at 11:23 AM Henry Wang <Henry.Wang@arm.com> wrote:

Hello Henry

[leave only xen-devel@lists.xenproject.org in CC]
[sorry for the possible format issues]

Signed-off-by: Henry Wang <Henry.Wang@arm.com>
> ---
>  CHANGELOG.md | 29 +++++++++++++++++++++++++++--
>  1 file changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index adbbb216fa..fa8cc476b3 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -4,16 +4,41 @@ Notable changes to Xen will be documented in this file.
>
>  The format is based on [Keep a Changelog](
> https://keepachangelog.com/en/1.0.0/)
>
> -## [unstable UNRELEASED](
> https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) - TBD
> +## [4.17.0](
> https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging) -
> 2022-11-??
>
>  ### Changed
>   - On x86 "vga=current" can now be used together with GrUB2's gfxpayload
> setting. Note that
>     this requires use of "multiboot2" (and "module2") as the GrUB commands
> loading Xen.
> + - The "gnttab" option now has a new command line sub-option for
> disabling the
> +   GNTTABOP_transfer functionality.
> + - The x86 MCE command line option info is now updated.
>
>  ### Added / support upgraded
> + - Out-of-tree builds for the hypervisor now supported.
> + - The project has officially adopted 4 directives and 24 rules of
> MISRA-C,
> +   added MISRA-C checker build integration, and defined how to document
> +   deviations.
>   - IOMMU superpage support on x86, affecting PV guests as well as HVM/PVH
> ones
>     when they don't share page tables with the CPU (HAP / EPT / NPT).
> - - Support VIRT_SSBD feature for HVM guests on AMD.
> + - Support VIRT_SSBD feature for HVM guests on AMD and MSR_SPEC_CTRL
> feature for
> +   SVM guests.
> + - Improved TSC, CPU frequency calibration and APIC on x86.
> + - Improved support for CET Indirect Branch Tracking on x86.
> + - Improved mwait-idle support for SPR and ADL on x86.
> + - Extend security support for hosts to 12 TiB of memory on x86.
> + - Add command line option to set cpuid parameters for dom0 at boot time
> on x86.
> + - Improved static configuration options on Arm.
> + - cpupools can be specified at boot using device tree on Arm.
> + - It is possible to use PV drivers with dom0less guests, allowing
> statically
> +   booted dom0less guests with PV devices.
> + - On Arm, p2m structures are now allocated out of a pool of memory set
> aside at
> +   domain creation.
> + - Improved mitigations against Spectre-BHB on Arm.
> + - Add support for VirtIO toolstack on Arm.
>

I would clarify that only virtio-mmio is supported on Arm.


> + - Allow setting the number of CPUs to activate at runtime from command
> line
> +   option on Arm.
> + - Improved toolstack build system.
> + - Add Xue - console over USB 3 Debug Capability.
>

I would probably also add the following:

- Add Renesas R-Car Gen4 IPMMU-VMSA support (Arm)
- grant-table support on Arm was improved and hardened by implementing
“simplified M2P-like
approach for the xenheap pages”



>
>  ### Removed / support downgraded
>   - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap"
> command line options
> --
> 2.25.1
>
>
>

-- 
Regards,

Oleksandr Tyshchenko

[-- Attachment #2: Type: text/html, Size: 5267 bytes --]

RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Henry Wang]

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

Hi Oleksandr,

(+ Arm maintainers for a question)

Please see below inline comments (I somehow cannot reply as plain text for this email).

+ - Add support for VirtIO toolstack on Arm.

I would clarify that only virtio-mmio is supported on Arm.

(Henry): Sure, will clarify that.

+ - Allow setting the number of CPUs to activate at runtime from command line
+   option on Arm.
+ - Improved toolstack build system.
+ - Add Xue - console over USB 3 Debug Capability.

I would probably also add the following:

- Add Renesas R-Car Gen4 IPMMU-VMSA support (Arm)

(Henry): If something from a specific vendor needs to be included, I wonder if “add i.MX lpuart and i.MX8QM initial support” also qualify. I will let Arm maintainers to do the final call here. Hope you would be fine with that.

- grant-table support on Arm was improved and hardened by implementing “simplified M2P-like
approach for the xenheap pages”

(Henry): Sure, I will add this.

Kind regards,
Henry

[-- Attachment #2: Type: text/html, Size: 4151 bytes --]

RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Stefano Stabellini]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

On Fri, 11 Nov 2022, Henry Wang wrote:
> - Add Renesas R-Car Gen4 IPMMU-VMSA support (Arm)
> 
>  
> 
> (Henry): If something from a specific vendor needs to be included, I wonder if “add i.MX lpuart and i.MX8QM initial support” also qualify.
> I will let Arm maintainers to do the final call here. Hope you would be fine with that.
 
Yes I think that's fine to add things from a specific vendor, including
i.MX related stuff

RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Henry Wang]

Hi Roger,

> -----Original Message-----
> Subject: RE: [PATCH 2/3] CHANGELOG: Add missing entries for work during
> the 4.17 release
> 
> Hi Jan,
> 
> > -----Original Message-----
> > On 11.11.2022 14:58, Henry Wang wrote:
> > > Another question for adding another entry for x86 that worth to
> > > brag about a little bit: I did another dig into patchwork and found that
> > > this [1] might be a good candidate. IIUC __ro_after_init is a good
> > > feature that both x86 and Arm have leveraged in different level today,
> > > so probably the __ro_after_init might worth an entry in CHANGELOG.
> > >
> > > However I saw your comments in [1] so I am not really sure if you are
> > > happy with that, maybe we need to change the wording a little bit to
> > > remove your concern? Would you mind sharing some thoughts?
> >
> > My view hasn't changed, but if Andrew and Roger think this should be
> > mentioned,
> > then I'm not going to stand in the way.
> 
> Thanks for the confirmation. I will wait for Roger's back on next Monday
> then.

Sorry I forgot to add you to the thread in last email, could you please share
Your opinion about this one? Thanks.

Kind regards,
Henry