All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henry Wang <Henry.Wang@arm.com>
To: Julien Grall <julien@xen.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: RE: [PATCH] xen/common: Constify the parameter of _spin_is_locked()
Date: Sat, 28 Jan 2023 03:34:29 +0000	[thread overview]
Message-ID: <AS8PR08MB79916E7213108E3960B79AEA92CD9@AS8PR08MB7991.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20230127190516.52994-1-julien@xen.org>

Hi Julien,

> -----Original Message-----
> Subject: [PATCH] xen/common: Constify the parameter of _spin_is_locked()
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> The lock is not meant to be modified by _spin_is_locked(). So constify
> it.
> 
> This is helpful to be able to assert the locked is taken when the

Nit: s/locked/lock/
This definitely can be fixed on commit.

> underlying structure is const.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

I tried to test this patch on FVP (both Arm32 and Arm64) to play safe.
This patch is good (as expected of course :)), so:

Reviewed-by: Henry Wang <Henry.Wang@arm.com>
Tested-by: Henry Wang <Henry.Wang@arm.com> #Arm

Kind regards,
Henry


  reply	other threads:[~2023-01-28  3:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 19:05 [PATCH] xen/common: Constify the parameter of _spin_is_locked() Julien Grall
2023-01-28  3:34 ` Henry Wang [this message]
2023-01-30  8:11 ` Jan Beulich
2023-01-30 10:04   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS8PR08MB79916E7213108E3960B79AEA92CD9@AS8PR08MB7991.eurprd08.prod.outlook.com \
    --to=henry.wang@arm.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgrall@amazon.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.