All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Julien Grall <jgrall@amazon.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/common: Constify the parameter of _spin_is_locked()
Date: Mon, 30 Jan 2023 09:11:23 +0100	[thread overview]
Message-ID: <eddf2879-1914-9401-d715-b711aaa7ed6c@suse.com> (raw)
In-Reply-To: <20230127190516.52994-1-julien@xen.org>

On 27.01.2023 20:05, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
> 
> The lock is not meant to be modified by _spin_is_locked(). So constify
> it.
> 
> This is helpful to be able to assert the locked is taken when the
> underlying structure is const.
> 
> Signed-off-by: Julien Grall <jgrall@amazon.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

But: Could I talk you into doing the same for _rw_is{,_write}_locked() for
consistency?

Jan


  parent reply	other threads:[~2023-01-30  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 19:05 [PATCH] xen/common: Constify the parameter of _spin_is_locked() Julien Grall
2023-01-28  3:34 ` Henry Wang
2023-01-30  8:11 ` Jan Beulich [this message]
2023-01-30 10:04   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eddf2879-1914-9401-d715-b711aaa7ed6c@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jgrall@amazon.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.