* [PATCH 1/2] qla2xxx: Remove free_sg command flag
@ 2022-04-15 12:42 Chesnokov Gleb
2022-04-19 19:37 ` Himanshu Madhani
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chesnokov Gleb @ 2022-04-15 12:42 UTC (permalink / raw)
To: linux-scsi
The use of the free_sg command flag was dropped in 2c39b5ca2a8c
("qla2xxx: Remove SRR code"). Hence remove this flag and its check.
Signed-off-by: Gleb Chesnokov <Chesnokov.G@raidix.com>
---
drivers/scsi/qla2xxx/qla_target.c | 2 --
drivers/scsi/qla2xxx/qla_target.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 85dbf81f3204..2d30578aebcf 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3863,8 +3863,6 @@ void qlt_free_cmd(struct qla_tgt_cmd *cmd)
BUG_ON(cmd->sg_mapped);
cmd->jiffies_at_free = get_jiffies_64();
- if (unlikely(cmd->free_sg))
- kfree(cmd->sg);
if (!sess || !sess->se_sess) {
WARN_ON(1);
diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
index 156b950ca7e7..de3942b8efc4 100644
--- a/drivers/scsi/qla2xxx/qla_target.h
+++ b/drivers/scsi/qla2xxx/qla_target.h
@@ -883,7 +883,6 @@ struct qla_tgt_cmd {
/* to save extra sess dereferences */
unsigned int conf_compl_supported:1;
unsigned int sg_mapped:1;
- unsigned int free_sg:1;
unsigned int write_data_transferred:1;
unsigned int q_full:1;
unsigned int term_exchg:1;
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] qla2xxx: Remove free_sg command flag
2022-04-15 12:42 [PATCH 1/2] qla2xxx: Remove free_sg command flag Chesnokov Gleb
@ 2022-04-19 19:37 ` Himanshu Madhani
2022-04-26 2:26 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Himanshu Madhani @ 2022-04-19 19:37 UTC (permalink / raw)
To: Chesnokov Gleb; +Cc: linux-scsi
> On Apr 15, 2022, at 5:42 AM, Chesnokov Gleb <Chesnokov.G@raidix.com> wrote:
>
> The use of the free_sg command flag was dropped in 2c39b5ca2a8c
> ("qla2xxx: Remove SRR code"). Hence remove this flag and its check.
>
> Signed-off-by: Gleb Chesnokov <Chesnokov.G@raidix.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 2 --
> drivers/scsi/qla2xxx/qla_target.h | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 85dbf81f3204..2d30578aebcf 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3863,8 +3863,6 @@ void qlt_free_cmd(struct qla_tgt_cmd *cmd)
>
> BUG_ON(cmd->sg_mapped);
> cmd->jiffies_at_free = get_jiffies_64();
> - if (unlikely(cmd->free_sg))
> - kfree(cmd->sg);
>
> if (!sess || !sess->se_sess) {
> WARN_ON(1);
> diff --git a/drivers/scsi/qla2xxx/qla_target.h b/drivers/scsi/qla2xxx/qla_target.h
> index 156b950ca7e7..de3942b8efc4 100644
> --- a/drivers/scsi/qla2xxx/qla_target.h
> +++ b/drivers/scsi/qla2xxx/qla_target.h
> @@ -883,7 +883,6 @@ struct qla_tgt_cmd {
> /* to save extra sess dereferences */
> unsigned int conf_compl_supported:1;
> unsigned int sg_mapped:1;
> - unsigned int free_sg:1;
> unsigned int write_data_transferred:1;
> unsigned int q_full:1;
> unsigned int term_exchg:1;
> --
> 2.35.1
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] qla2xxx: Remove free_sg command flag
2022-04-15 12:42 [PATCH 1/2] qla2xxx: Remove free_sg command flag Chesnokov Gleb
2022-04-19 19:37 ` Himanshu Madhani
@ 2022-04-26 2:26 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-04-26 2:26 UTC (permalink / raw)
To: Chesnokov Gleb; +Cc: linux-scsi
> The use of the free_sg command flag was dropped in 2c39b5ca2a8c
> ("qla2xxx: Remove SRR code"). Hence remove this flag and its check.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] qla2xxx: Remove free_sg command flag
2022-04-15 12:42 [PATCH 1/2] qla2xxx: Remove free_sg command flag Chesnokov Gleb
2022-04-19 19:37 ` Himanshu Madhani
2022-04-26 2:26 ` Martin K. Petersen
@ 2022-05-03 0:51 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw)
To: Chesnokov Gleb, linux-scsi; +Cc: Martin K . Petersen
On Fri, 15 Apr 2022 12:42:24 +0000, Chesnokov Gleb wrote:
> The use of the free_sg command flag was dropped in 2c39b5ca2a8c
> ("qla2xxx: Remove SRR code"). Hence remove this flag and its check.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/2] qla2xxx: Remove free_sg command flag
https://git.kernel.org/mkp/scsi/c/ad14649fc5ab
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-04 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-15 12:42 [PATCH 1/2] qla2xxx: Remove free_sg command flag Chesnokov Gleb
2022-04-19 19:37 ` Himanshu Madhani
2022-04-26 2:26 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.