All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian Kohlschütter" <christian@kohlschutter.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Xiaobo Tian <peterwillcn@gmail.com>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
Date: Sat, 1 Oct 2022 00:18:21 +0200	[thread overview]
Message-ID: <B0573352-BA0C-47BC-971A-74314659A50E@kohlschutter.com> (raw)
In-Reply-To: <CAPnjgZ3gY5U4hxCxkC07jj_Q3pNz0vGFzLWaAqhqgmvxwy3qBQ@mail.gmail.com>

On 30. Sep 2022, at 01:55, Simon Glass <sjg@chromium.org> wrote:
...
>> Is there a tool to sort these values in a certain order?
> 
> $ echo nanopi-r4s-rk3399_defconfig >asc
> $ ./tools/moveconfig.py -s -d asc
> 
> (it could use a new flag to just specific the board, if you want to
> send a patch)
> 
> Should these not be in alphabetical order?
> 
> No it is in order of the Kconfig tree (use 'make menuconfig' or 'make
> xconfig' to see it).
> 
> Regards,
> Simon

I tried the above commands to no avail. moveconfig hangs.

I assume you meant "cat" instead of "echo"? But even then it doesn't sort the values.
Fixing that I just got a bunch of "no defconfig matched" warnings.

What is the motivation of sorting these values in Kconfig order? Is it just for the sake of keeping comments in the right place?
Would sorting in alphabetical order cause other issues?

Should there perhaps be a make target to take care of automatically cleaning up defconfig files?


  reply	other threads:[~2022-09-30 22:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  0:15 [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo Christian Kohlschütter
2022-09-29  2:36 ` Simon Glass
2022-09-29 14:29   ` Christian Kohlschütter
2022-09-29 23:55     ` Simon Glass
2022-09-30 22:18       ` Christian Kohlschütter [this message]
2022-10-17 13:21 ` Kever Yang
2022-10-17 13:25   ` Kever Yang
2022-10-17 19:02     ` [PATCH v2] " Christian Kohlschütter
2023-02-22  6:38       ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B0573352-BA0C-47BC-971A-74314659A50E@kohlschutter.com \
    --to=christian@kohlschutter.com \
    --cc=kever.yang@rock-chips.com \
    --cc=peterwillcn@gmail.com \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.