From: Simon Glass <sjg@chromium.org>
To: "Christian Kohlschütter" <christian@kohlschutter.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Xiaobo Tian <peterwillcn@gmail.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo
Date: Wed, 28 Sep 2022 20:36:00 -0600 [thread overview]
Message-ID: <CAPnjgZ2mjVGRRAicV_q8FmwW2TQCwBGewwJSMMGs12VFR2BaKQ@mail.gmail.com> (raw)
In-Reply-To: <20220929001520.9095-1-christian@kohlschutter.com>
On Wed, 28 Sept 2022 at 18:15, Christian Kohlschütter
<christian@kohlschutter.com> wrote:
>
> Provide human-readable manufacturer and product names for the
> FriendlyELEC NanoPi R4S.
>
> Enable CONFIG_SYSINFO and CONFIG_SYSINFO_SMBIOS by default.
>
> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
> ---
> arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi | 22 ++++++++++++++++++++++
> configs/nanopi-r4s-rk3399_defconfig | 2 ++
> 2 files changed, 24 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
>
> diff --git a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> index cd1642527b..69800cc368 100644
> --- a/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-nanopi-r4s-u-boot.dtsi
> @@ -14,3 +14,25 @@
>
> #include "rk3399-nanopi4-u-boot.dtsi"
> #include "rk3399-sdram-lpddr4-100.dtsi"
> +
> +/ {
> + smbios {
> + compatible = "u-boot,sysinfo-smbios";
> +
> + smbios {
> + system {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + baseboard {
> + manufacturer = "FriendlyELEC";
> + product = "NanoPi R4S";
> + };
> +
> + chassis {
> + manufacturer = "FriendlyELEC";
> + };
> + };
> + };
> +};
> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
> index dd2579d2e0..502f007e6e 100644
> --- a/configs/nanopi-r4s-rk3399_defconfig
> +++ b/configs/nanopi-r4s-rk3399_defconfig
> @@ -75,3 +75,5 @@ CONFIG_MISC=y
> CONFIG_MISC_INIT_R=y
> CONFIG_ROCKCHIP_EFUSE=y
> CONFIG_ROCKCHIP_OTP=y
> +CONFIG_SYSINFO=y
> +CONFIG_SYSINFO_SMBIOS=y
Is the ordering right, here?
Regards,
Simon
> --
> 2.36.2
>
next prev parent reply other threads:[~2022-09-29 2:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 0:15 [PATCH] arm: dts: rockchip: rk3399: nanopi-r4s: Provide smbios sysinfo Christian Kohlschütter
2022-09-29 2:36 ` Simon Glass [this message]
2022-09-29 14:29 ` Christian Kohlschütter
2022-09-29 23:55 ` Simon Glass
2022-09-30 22:18 ` Christian Kohlschütter
2022-10-17 13:21 ` Kever Yang
2022-10-17 13:25 ` Kever Yang
2022-10-17 19:02 ` [PATCH v2] " Christian Kohlschütter
2023-02-22 6:38 ` Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPnjgZ2mjVGRRAicV_q8FmwW2TQCwBGewwJSMMGs12VFR2BaKQ@mail.gmail.com \
--to=sjg@chromium.org \
--cc=christian@kohlschutter.com \
--cc=kever.yang@rock-chips.com \
--cc=peterwillcn@gmail.com \
--cc=philipp.tomsich@vrull.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.