* [PATCH 2.6.10] tg3: 5750 fixes
@ 2005-01-26 18:01 Michael Chan
2005-01-26 23:29 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michael Chan @ 2005-01-26 18:01 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
Some misc. fixes for 5750. The first 2 fixes below are for correctness.
- Do not set extended MAC addresses for 5750
- Do not set NIC ring addresses in send ring and receive return ring RCBs for
5750
- Check eeprom write protect bit for 5750
Signed-off-by: Michael Chan <mchan@broadcom.com>
[-- Attachment #2: tg3_5750.patch --]
[-- Type: application/octet-stream, Size: 1532 bytes --]
diff -Nru 3/tg3.c 4/tg3.c
--- 3/tg3.c 2005-01-23 13:37:16.000000000 -0800
+++ 4/tg3.c 2005-01-25 09:16:34.000000000 -0800
@@ -4858,9 +4858,8 @@
tw32(MAC_ADDR_0_LOW + (i * 8), addr_low);
}
- if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700 &&
- GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701 &&
- GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705) {
+ if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5703 ||
+ GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) {
for (i = 0; i < 12; i++) {
tw32(MAC_EXTADDR_0_HIGH + (i * 8), addr_high);
tw32(MAC_EXTADDR_0_LOW + (i * 8), addr_low);
@@ -4906,7 +4905,8 @@
(bdinfo_addr + TG3_BDINFO_MAXLEN_FLAGS),
maxlen_flags);
- if (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705)
+ if ((GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5705) &&
+ (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5750))
tg3_write_mem(tp,
(bdinfo_addr + TG3_BDINFO_NIC_ADDR),
nic_addr);
@@ -7569,9 +7569,8 @@
tp->pdev->subsystem_vendor == PCI_VENDOR_ID_DELL)
tp->led_ctrl = LED_CTRL_MODE_PHY_2;
- if (((GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5703) ||
- (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704) ||
- (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5705)) &&
+ if ((GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5700) &&
+ (GET_ASIC_REV(tp->pci_chip_rev_id) != ASIC_REV_5701) &&
(nic_cfg & NIC_SRAM_DATA_CFG_EEPROM_WP))
tp->tg3_flags |= TG3_FLAG_EEPROM_WRITE_PROT;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.10] tg3: 5750 fixes
2005-01-26 18:01 [PATCH 2.6.10] tg3: 5750 fixes Michael Chan
@ 2005-01-26 23:29 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2005-01-26 23:29 UTC (permalink / raw)
To: Michael Chan; +Cc: netdev
On Wed, 26 Jan 2005 10:01:42 -0800
"Michael Chan" <mchan@broadcom.com> wrote:
> Some misc. fixes for 5750. The first 2 fixes below are for correctness.
Looks great, patch applied, thanks Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-01-26 23:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-01-26 18:01 [PATCH 2.6.10] tg3: 5750 fixes Michael Chan
2005-01-26 23:29 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.