* [patch 1/2] drivers/message/fusion/mptsas.c: fix warning
@ 2011-01-18 22:01 akpm
2011-01-19 14:06 ` Desai, Kashyap
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2011-01-18 22:01 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, akpm, Eric.Moore
From: Andrew Morton <akpm@linux-foundation.org>
drivers/message/fusion/mptsas.c: In function 'mptsas_event_process':
drivers/message/fusion/mptsas.c:5010: warning: unused variable 'log_info'
Cc: "Moore, Eric Dean" <Eric.Moore@lsil.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/message/fusion/mptsas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/message/fusion/mptsas.c~drivers-message-fusion-mptsasc-fix-warning drivers/message/fusion/mptsas.c
--- a/drivers/message/fusion/mptsas.c~drivers-message-fusion-mptsasc-fix-warning
+++ a/drivers/message/fusion/mptsas.c
@@ -5009,7 +5009,6 @@ mptsas_event_process(MPT_ADAPTER *ioc, E
(ioc_stat & MPI_IOCSTATUS_FLAG_LOG_INFO_AVAILABLE)) {
VirtTarget *vtarget = NULL;
u8 id, channel;
- u32 log_info = le32_to_cpu(reply->IOCLogInfo);
id = sas_event_data->TargetID;
channel = sas_event_data->Bus;
@@ -5020,7 +5019,8 @@ mptsas_event_process(MPT_ADAPTER *ioc, E
"LogInfo (0x%x) available for "
"INTERNAL_DEVICE_RESET"
"fw_id %d fw_channel %d\n", ioc->name,
- log_info, id, channel));
+ le32_to_cpu(reply->IOCLogInfo), id,
+ channel));
if (vtarget->raidVolume) {
devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT
"Skipping Raid Volume for inDMD\n",
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [patch 1/2] drivers/message/fusion/mptsas.c: fix warning
2011-01-18 22:01 [patch 1/2] drivers/message/fusion/mptsas.c: fix warning akpm
@ 2011-01-19 14:06 ` Desai, Kashyap
0 siblings, 0 replies; 2+ messages in thread
From: Desai, Kashyap @ 2011-01-19 14:06 UTC (permalink / raw)
To: akpm, James.Bottomley; +Cc: linux-scsi, Moore, Eric
Without debug enable log_info will not be used.
Please consider this patch as an ACKed.
Thanks, Kashyap
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-
> owner@vger.kernel.org] On Behalf Of akpm@linux-foundation.org
> Sent: Wednesday, January 19, 2011 3:32 AM
> To: James.Bottomley@HansenPartnership.com
> Cc: linux-scsi@vger.kernel.org; akpm@linux-foundation.org; Moore, Eric
> Subject: [patch 1/2] drivers/message/fusion/mptsas.c: fix warning
>
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/message/fusion/mptsas.c: In function 'mptsas_event_process':
> drivers/message/fusion/mptsas.c:5010: warning: unused variable
> 'log_info'
>
> Cc: "Moore, Eric Dean" <Eric.Moore@lsil.com>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/message/fusion/mptsas.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -puN drivers/message/fusion/mptsas.c~drivers-message-fusion-
> mptsasc-fix-warning drivers/message/fusion/mptsas.c
> --- a/drivers/message/fusion/mptsas.c~drivers-message-fusion-mptsasc-
> fix-warning
> +++ a/drivers/message/fusion/mptsas.c
> @@ -5009,7 +5009,6 @@ mptsas_event_process(MPT_ADAPTER *ioc, E
> (ioc_stat & MPI_IOCSTATUS_FLAG_LOG_INFO_AVAILABLE)) {
> VirtTarget *vtarget = NULL;
> u8 id, channel;
> - u32 log_info = le32_to_cpu(reply->IOCLogInfo);
>
> id = sas_event_data->TargetID;
> channel = sas_event_data->Bus;
> @@ -5020,7 +5019,8 @@ mptsas_event_process(MPT_ADAPTER *ioc, E
> "LogInfo (0x%x) available for "
> "INTERNAL_DEVICE_RESET"
> "fw_id %d fw_channel %d\n", ioc->name,
> - log_info, id, channel));
> + le32_to_cpu(reply->IOCLogInfo), id,
> + channel));
> if (vtarget->raidVolume) {
> devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT
> "Skipping Raid Volume for inDMD\n",
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-19 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-18 22:01 [patch 1/2] drivers/message/fusion/mptsas.c: fix warning akpm
2011-01-19 14:06 ` Desai, Kashyap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.