* [PATCH 0/7] hpsa updates
@ 2016-02-23 21:16 Don Brace
2016-02-23 21:16 ` [PATCH 1/7] hpsa: do not get enclosure info for external devices Don Brace
` (7 more replies)
0 siblings, 8 replies; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
These patches are based on Linus's tree
The changes are:
- stop requesting enclosure info for external devices
- add in SMR support
- correct lun data caching macro definition
- add abort support for hba devices
- check for null pointer in ioaccel2 path
- remove definition for sanitize_inquiry_string
This patch depends on
- commit ac10a3e4ed64
("Export function scsi_scan.c:sanitize_inquiry_string")
- update copyright information
---
Don Brace (7):
hpsa: do not get enclosure info for external devices
hpsa: add SMR drive support
hpsa: correct lun data caching bitmap definition
hpsa: correct abort tmf for hba devices
hpsa: check for a null phys_disk pointer in ioaccel2 path
hpsa: remove function definition for sanitize_inquiry_string
hpsa: update copyright information
drivers/scsi/hpsa.c | 52 +++++++++++++++++++++++++----------------------
drivers/scsi/hpsa.h | 3 ++-
drivers/scsi/hpsa_cmd.h | 5 +++--
3 files changed, 33 insertions(+), 27 deletions(-)
--
Signature
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/7] hpsa: do not get enclosure info for external devices
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
@ 2016-02-23 21:16 ` Don Brace
2016-02-23 23:17 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 2/7] hpsa: add SMR drive support Don Brace
` (6 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
Stop annoying "Error, could not get enclosure information"
messages.
Reviewed-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Reviewed-by: Justin Lindley <justin.lindley@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 38ce0e3..098e8de 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3208,8 +3208,10 @@ static void hpsa_get_enclosure_info(struct ctlr_info *h,
bmic_device_index = GET_BMIC_DRIVE_NUMBER(&rle->lunid[0]);
- if (bmic_device_index == 0xFF00)
+ if (bmic_device_index == 0xFF00 || MASKED_DEVICE(&rle->lunid[0])) {
+ rc = IO_OK;
goto out;
+ }
bssbp = kzalloc(sizeof(*bssbp), GFP_KERNEL);
if (!bssbp)
@@ -4197,7 +4199,8 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h)
ncurrent++;
break;
case TYPE_ENCLOSURE:
- hpsa_get_enclosure_info(h, lunaddrbytes,
+ if (!this_device->external)
+ hpsa_get_enclosure_info(h, lunaddrbytes,
physdev_list, phys_dev_index,
this_device);
ncurrent++;
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/7] hpsa: add SMR drive support
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
2016-02-23 21:16 ` [PATCH 1/7] hpsa: do not get enclosure info for external devices Don Brace
@ 2016-02-23 21:16 ` Don Brace
2016-02-23 23:21 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 3/7] hpsa: correct lun data caching bitmap definition Don Brace
` (5 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
Reviewed-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Reviewed-by: Justin Lindley <justin.lindley@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 098e8de..671ad57 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -809,7 +809,8 @@ static ssize_t path_info_show(struct device *dev,
PAGE_SIZE - output_len,
"PORT: %.2s ",
phys_connector);
- if (hdev->devtype == TYPE_DISK && hdev->expose_device) {
+ if ((hdev->devtype == TYPE_DISK || hdev->devtype == TYPE_ZBC) &&
+ hdev->expose_device) {
if (box == 0 || box == 0xFF) {
output_len += scnprintf(buf + output_len,
PAGE_SIZE - output_len,
@@ -1166,6 +1167,7 @@ static void hpsa_show_dev_msg(const char *level, struct ctlr_info *h,
snprintf(label, LABEL_SIZE, "enclosure");
break;
case TYPE_DISK:
+ case TYPE_ZBC:
if (dev->external)
snprintf(label, LABEL_SIZE, "external");
else if (!is_logical_dev_addr_mode(dev->scsi3addr))
@@ -1636,6 +1638,8 @@ static void hpsa_figure_phys_disk_ptrs(struct ctlr_info *h,
continue;
if (dev[j]->devtype != TYPE_DISK)
continue;
+ if (dev[j]->devtype != TYPE_ZBC)
+ continue;
if (is_logical_device(dev[j]))
continue;
if (dev[j]->ioaccel_handle != dd[i].ioaccel_handle)
@@ -1681,6 +1685,8 @@ static void hpsa_update_log_drive_phys_drive_ptrs(struct ctlr_info *h,
continue;
if (dev[i]->devtype != TYPE_DISK)
continue;
+ if (dev[i]->devtype != TYPE_ZBC)
+ continue;
if (!is_logical_device(dev[i]))
continue;
@@ -3715,7 +3721,8 @@ static int hpsa_update_device_info(struct ctlr_info *h,
hpsa_get_device_id(h, scsi3addr, this_device->device_id, 8,
sizeof(this_device->device_id));
- if (this_device->devtype == TYPE_DISK &&
+ if ((this_device->devtype == TYPE_DISK ||
+ this_device->devtype == TYPE_ZBC) &&
is_logical_dev_addr_mode(scsi3addr)) {
int volume_offline;
@@ -4183,6 +4190,7 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h)
ncurrent++;
break;
case TYPE_DISK:
+ case TYPE_ZBC:
if (this_device->physical_device) {
/* The disk is in HBA mode. */
/* Never use RAID mapper in HBA mode. */
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/7] hpsa: correct lun data caching bitmap definition
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
2016-02-23 21:16 ` [PATCH 1/7] hpsa: do not get enclosure info for external devices Don Brace
2016-02-23 21:16 ` [PATCH 2/7] hpsa: add SMR drive support Don Brace
@ 2016-02-23 21:16 ` Don Brace
2016-02-23 23:22 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 4/7] hpsa: correct abort tmf for hba devices Don Brace
` (4 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
The bitmap was changed after this definition was added
to the driver. Correcting the bitmap definition.
Reviewed-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Reviewed-by: Justin Lindley <justin.lindley@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
index 6a919ad..dffda96 100644
--- a/drivers/scsi/hpsa_cmd.h
+++ b/drivers/scsi/hpsa_cmd.h
@@ -289,7 +289,7 @@ struct SenseSubsystem_info {
#define BMIC_IDENTIFY_CONTROLLER 0x11
#define BMIC_SET_DIAG_OPTIONS 0xF4
#define BMIC_SENSE_DIAG_OPTIONS 0xF5
-#define HPSA_DIAG_OPTS_DISABLE_RLD_CACHING 0x40000000
+#define HPSA_DIAG_OPTS_DISABLE_RLD_CACHING 0x80000000
#define BMIC_SENSE_SUBSYSTEM_INFORMATION 0x66
#define BMIC_SENSE_STORAGE_BOX_PARAMS 0x65
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 4/7] hpsa: correct abort tmf for hba devices
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
` (2 preceding siblings ...)
2016-02-23 21:16 ` [PATCH 3/7] hpsa: correct lun data caching bitmap definition Don Brace
@ 2016-02-23 21:16 ` Don Brace
2016-02-23 23:22 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path Don Brace
` (3 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
Aborts were not being sent down to HBA devices
Reviewed-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Reviewed-by: Justin Lindley <justin.lindley@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 671ad57..589b44e 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5846,7 +5846,7 @@ static int hpsa_send_abort_ioaccel2(struct ctlr_info *h,
}
static int hpsa_send_abort_both_ways(struct ctlr_info *h,
- unsigned char *scsi3addr, struct CommandList *abort, int reply_queue)
+ struct hpsa_scsi_dev_t *dev, struct CommandList *abort, int reply_queue)
{
/*
* ioccelerator mode 2 commands should be aborted via the
@@ -5855,14 +5855,16 @@ static int hpsa_send_abort_both_ways(struct ctlr_info *h,
* Change abort to physical device reset when abort TMF is unsupported.
*/
if (abort->cmd_type == CMD_IOACCEL2) {
- if (HPSATMF_IOACCEL_ENABLED & h->TMFSupportFlags)
+ if ((HPSATMF_IOACCEL_ENABLED & h->TMFSupportFlags) ||
+ dev->physical_device)
return hpsa_send_abort_ioaccel2(h, abort,
reply_queue);
else
- return hpsa_send_reset_as_abort_ioaccel2(h, scsi3addr,
+ return hpsa_send_reset_as_abort_ioaccel2(h,
+ dev->scsi3addr,
abort, reply_queue);
}
- return hpsa_send_abort(h, scsi3addr, abort, reply_queue);
+ return hpsa_send_abort(h, dev->scsi3addr, abort, reply_queue);
}
/* Find out which reply queue a command was meant to return on */
@@ -6000,7 +6002,7 @@ static int hpsa_eh_abort_handler(struct scsi_cmnd *sc)
cmd_free(h, abort);
return FAILED;
}
- rc = hpsa_send_abort_both_ways(h, dev->scsi3addr, abort, reply_queue);
+ rc = hpsa_send_abort_both_ways(h, dev, abort, reply_queue);
atomic_inc(&h->abort_cmds_available);
wake_up_all(&h->abort_cmd_wait_queue);
if (rc != 0) {
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
` (3 preceding siblings ...)
2016-02-23 21:16 ` [PATCH 4/7] hpsa: correct abort tmf for hba devices Don Brace
@ 2016-02-23 21:16 ` Don Brace
2016-02-23 23:22 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string Don Brace
` (2 subsequent siblings)
7 siblings, 1 reply; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
An oops can occur when submitting ioaccel2 commands
when the phys_disk pointer is NULL in hpsa_scsi_ioaccel_raid_map.
Happens when there are configuration changes during I/O operations.
If the phys_disk pointer is NULL, send the command down the RAID path.
Reviewed-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Reviewed-by: Justin Lindley <justin.lindley@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 589b44e..edbecf8 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -4981,6 +4981,8 @@ static int hpsa_scsi_ioaccel_raid_map(struct ctlr_info *h,
return IO_ACCEL_INELIGIBLE;
c->phys_disk = dev->phys_disk[map_index];
+ if (!c->phys_disk)
+ return IO_ACCEL_INELIGIBLE;
disk_handle = dd[map_index].ioaccel_handle;
disk_block = le64_to_cpu(map->disk_starting_blk) +
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
` (4 preceding siblings ...)
2016-02-23 21:16 ` [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path Don Brace
@ 2016-02-23 21:16 ` Don Brace
2016-02-23 23:24 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 7/7] hpsa: update copyright information Don Brace
2016-02-24 2:03 ` [PATCH 0/7] hpsa updates Martin K. Petersen
7 siblings, 1 reply; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
This patch depends on patch
- commit ac10a3e4ed64
("Export function scsi_scan.c:sanitize_inquiry_string")
Suggested-by: Hannes Reinecke <hare@suse.de>
Suggested-by: Matthew R. Ochs mrochs@linux.vnet.ibm.com
Reviewed-by: Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>
Reviewed-by: Justin Lindley <justin.lindley@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index edbecf8..725eb8d 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3665,18 +3665,6 @@ static int hpsa_device_supports_aborts(struct ctlr_info *h,
return rc;
}
-static void sanitize_inquiry_string(unsigned char *s, int len)
-{
- bool terminated = false;
-
- for (; len > 0; (--len, ++s)) {
- if (*s == 0)
- terminated = true;
- if (terminated || *s < 0x20 || *s > 0x7e)
- *s = ' ';
- }
-}
-
static int hpsa_update_device_info(struct ctlr_info *h,
unsigned char scsi3addr[], struct hpsa_scsi_dev_t *this_device,
unsigned char *is_OBDR_device)
@@ -3707,8 +3695,8 @@ static int hpsa_update_device_info(struct ctlr_info *h,
goto bail_out;
}
- sanitize_inquiry_string(&inq_buff[8], 8);
- sanitize_inquiry_string(&inq_buff[16], 16);
+ scsi_sanitize_inquiry_string(&inq_buff[8], 8);
+ scsi_sanitize_inquiry_string(&inq_buff[16], 16);
this_device->devtype = (inq_buff[0] & 0x1f);
memcpy(this_device->scsi3addr, scsi3addr, 8);
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 7/7] hpsa: update copyright information
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
` (5 preceding siblings ...)
2016-02-23 21:16 ` [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string Don Brace
@ 2016-02-23 21:16 ` Don Brace
2016-02-23 23:24 ` Matthew R. Ochs
2016-02-24 2:03 ` [PATCH 0/7] hpsa updates Martin K. Petersen
7 siblings, 1 reply; 16+ messages in thread
From: Don Brace @ 2016-02-23 21:16 UTC (permalink / raw)
To: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott
Cc: linux-scsi
Reviewed-by: Justin Lindley <justin.lindley@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
drivers/scsi/hpsa.c | 3 ++-
drivers/scsi/hpsa.h | 3 ++-
drivers/scsi/hpsa_cmd.h | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 725eb8d..5be944c 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -1,5 +1,6 @@
/*
* Disk Array driver for HP Smart Array SAS controllers
+ * Copyright 2016 Microsemi Corporation
* Copyright 2014-2015 PMC-Sierra, Inc.
* Copyright 2000,2009-2015 Hewlett-Packard Development Company, L.P.
*
@@ -12,7 +13,7 @@
* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
* NON INFRINGEMENT. See the GNU General Public License for more details.
*
- * Questions/Comments/Bugfixes to storagedev@pmcs.com
+ * Questions/Comments/Bugfixes to esc.storagedev@microsemi.com
*
*/
diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h
index fdd39fc..d06bb74 100644
--- a/drivers/scsi/hpsa.h
+++ b/drivers/scsi/hpsa.h
@@ -1,5 +1,6 @@
/*
* Disk Array driver for HP Smart Array SAS controllers
+ * Copyright 2016 Microsemi Corporation
* Copyright 2014-2015 PMC-Sierra, Inc.
* Copyright 2000,2009-2015 Hewlett-Packard Development Company, L.P.
*
@@ -12,7 +13,7 @@
* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
* NON INFRINGEMENT. See the GNU General Public License for more details.
*
- * Questions/Comments/Bugfixes to storagedev@pmcs.com
+ * Questions/Comments/Bugfixes to esc.storagedev@microsemi.com
*
*/
#ifndef HPSA_H
diff --git a/drivers/scsi/hpsa_cmd.h b/drivers/scsi/hpsa_cmd.h
index dffda96..a5be153 100644
--- a/drivers/scsi/hpsa_cmd.h
+++ b/drivers/scsi/hpsa_cmd.h
@@ -1,5 +1,6 @@
/*
* Disk Array driver for HP Smart Array SAS controllers
+ * Copyright 2016 Microsemi Corporation
* Copyright 2014-2015 PMC-Sierra, Inc.
* Copyright 2000,2009-2015 Hewlett-Packard Development Company, L.P.
*
@@ -12,7 +13,7 @@
* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
* NON INFRINGEMENT. See the GNU General Public License for more details.
*
- * Questions/Comments/Bugfixes to storagedev@pmcs.com
+ * Questions/Comments/Bugfixes to esc.storagedev@microsemi.com
*
*/
#ifndef HPSA_CMD_H
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/7] hpsa: do not get enclosure info for external devices
2016-02-23 21:16 ` [PATCH 1/7] hpsa: do not get enclosure info for external devices Don Brace
@ 2016-02-23 23:17 ` Matthew R. Ochs
0 siblings, 0 replies; 16+ messages in thread
From: Matthew R. Ochs @ 2016-02-23 23:17 UTC (permalink / raw)
To: Don Brace
Cc: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott, linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/7] hpsa: add SMR drive support
2016-02-23 21:16 ` [PATCH 2/7] hpsa: add SMR drive support Don Brace
@ 2016-02-23 23:21 ` Matthew R. Ochs
0 siblings, 0 replies; 16+ messages in thread
From: Matthew R. Ochs @ 2016-02-23 23:21 UTC (permalink / raw)
To: Don Brace
Cc: James Bottomley, Viswas.G, scott.teel, Kevin.Barnett,
scott.benesh, Mahesh.Rajashekhara, Christoph Hellwig,
Justin.Lindley, elliott, linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/7] hpsa: correct lun data caching bitmap definition
2016-02-23 21:16 ` [PATCH 3/7] hpsa: correct lun data caching bitmap definition Don Brace
@ 2016-02-23 23:22 ` Matthew R. Ochs
0 siblings, 0 replies; 16+ messages in thread
From: Matthew R. Ochs @ 2016-02-23 23:22 UTC (permalink / raw)
To: Don Brace
Cc: James Bottomley, Viswas.G, scott.teel, Kevin.Barnett,
scott.benesh, Mahesh.Rajashekhara, Christoph Hellwig,
Justin.Lindley, elliott, linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 4/7] hpsa: correct abort tmf for hba devices
2016-02-23 21:16 ` [PATCH 4/7] hpsa: correct abort tmf for hba devices Don Brace
@ 2016-02-23 23:22 ` Matthew R. Ochs
0 siblings, 0 replies; 16+ messages in thread
From: Matthew R. Ochs @ 2016-02-23 23:22 UTC (permalink / raw)
To: Don Brace
Cc: James Bottomley, Viswas.G, scott.teel, Kevin.Barnett,
scott.benesh, Mahesh.Rajashekhara, Christoph Hellwig,
Justin.Lindley, elliott, linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path
2016-02-23 21:16 ` [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path Don Brace
@ 2016-02-23 23:22 ` Matthew R. Ochs
0 siblings, 0 replies; 16+ messages in thread
From: Matthew R. Ochs @ 2016-02-23 23:22 UTC (permalink / raw)
To: Don Brace
Cc: James Bottomley, Viswas.G, scott.teel, Kevin.Barnett,
scott.benesh, Mahesh.Rajashekhara, Christoph Hellwig,
Justin.Lindley, elliott, linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string
2016-02-23 21:16 ` [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string Don Brace
@ 2016-02-23 23:24 ` Matthew R. Ochs
0 siblings, 0 replies; 16+ messages in thread
From: Matthew R. Ochs @ 2016-02-23 23:24 UTC (permalink / raw)
To: Don Brace
Cc: James Bottomley, Viswas.G, scott.teel, Kevin.Barnett,
scott.benesh, Mahesh.Rajashekhara, Christoph Hellwig,
Justin.Lindley, elliott, linux-scsi
Thanks again for implementing this feedback!
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 7/7] hpsa: update copyright information
2016-02-23 21:16 ` [PATCH 7/7] hpsa: update copyright information Don Brace
@ 2016-02-23 23:24 ` Matthew R. Ochs
0 siblings, 0 replies; 16+ messages in thread
From: Matthew R. Ochs @ 2016-02-23 23:24 UTC (permalink / raw)
To: Don Brace
Cc: James Bottomley, Viswas.G, scott.teel, Kevin.Barnett,
scott.benesh, Mahesh.Rajashekhara, Christoph Hellwig,
Justin.Lindley, elliott, linux-scsi
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/7] hpsa updates
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
` (6 preceding siblings ...)
2016-02-23 21:16 ` [PATCH 7/7] hpsa: update copyright information Don Brace
@ 2016-02-24 2:03 ` Martin K. Petersen
7 siblings, 0 replies; 16+ messages in thread
From: Martin K. Petersen @ 2016-02-24 2:03 UTC (permalink / raw)
To: Don Brace
Cc: JBottomley, Viswas.G, scott.teel, Kevin.Barnett, scott.benesh,
Mahesh.Rajashekhara, hch, Justin.Lindley, elliott, linux-scsi,
Matthew R. Ochs
>>>>> "Don" == Don Brace <don.brace@microsemi.com> writes:
Don> These patches are based on Linus's tree The changes are: - stop
Don> requesting enclosure info for external devices - add in SMR support
Don> - correct lun data caching macro definition - add abort support for
Don> hba devices - check for null pointer in ioaccel2 path - remove
Don> definition for sanitize_inquiry_string This patch depends on -
Don> commit ac10a3e4ed64 ("Export function
Don> scsi_scan.c:sanitize_inquiry_string") - update copyright
Don> information ---
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-02-24 2:03 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-23 21:16 [PATCH 0/7] hpsa updates Don Brace
2016-02-23 21:16 ` [PATCH 1/7] hpsa: do not get enclosure info for external devices Don Brace
2016-02-23 23:17 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 2/7] hpsa: add SMR drive support Don Brace
2016-02-23 23:21 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 3/7] hpsa: correct lun data caching bitmap definition Don Brace
2016-02-23 23:22 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 4/7] hpsa: correct abort tmf for hba devices Don Brace
2016-02-23 23:22 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 5/7] hpsa: check for a null phys_disk pointer in ioaccel2 path Don Brace
2016-02-23 23:22 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 6/7] hpsa: remove function definition for sanitize_inquiry_string Don Brace
2016-02-23 23:24 ` Matthew R. Ochs
2016-02-23 21:16 ` [PATCH 7/7] hpsa: update copyright information Don Brace
2016-02-23 23:24 ` Matthew R. Ochs
2016-02-24 2:03 ` [PATCH 0/7] hpsa updates Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.