* Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup
@ 2022-02-12 2:47 Arınç ÜNAL
2022-02-13 12:31 ` Alvin Šipraga
0 siblings, 1 reply; 5+ messages in thread
From: Arınç ÜNAL @ 2022-02-12 2:47 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca
Cc: netdev, linus.walleij, andrew, vivien.didelot, f.fainelli,
olteanv, davem, kuba, alsi, Frank Wunderlich
>
> On 12 Feb 2022, at 05:27, Luiz Angelo Daros de Luca <luizluca@gmail.com> wrote:
>
> Some devices, like the switch in Banana Pi BPI R64 only starts to answer
> after a HW reset. It is the same reset code from realtek-smi.
>
> In realtek-smi, only assert the reset when the gpio is defined.
If realtek-smi also resets before setup with this patch (I don’t understand code very well) can you mention it next to mdio in the summary too?
In any case:
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> Tested-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ---
> drivers/net/dsa/realtek/realtek-mdio.c | 19 +++++++++++++++++++
> drivers/net/dsa/realtek/realtek-smi.c | 17 ++++++++++-------
> drivers/net/dsa/realtek/realtek.h | 3 +++
> 3 files changed, 32 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c
> index 0c5f2bdced9d..fa2339763c71 100644
> --- a/drivers/net/dsa/realtek/realtek-mdio.c
> +++ b/drivers/net/dsa/realtek/realtek-mdio.c
> @@ -152,6 +152,21 @@ static int realtek_mdio_probe(struct mdio_device *mdiodev)
> /* TODO: if power is software controlled, set up any regulators here */
> priv->leds_disabled = of_property_read_bool(np, "realtek,disable-leds");
>
> + /* Assert then deassert RESET */
> + priv->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
> + if (IS_ERR(priv->reset)) {
> + dev_err(dev, "failed to get RESET GPIO\n");
> + return PTR_ERR(priv->reset);
> + }
> +
> + if (priv->reset) {
> + dev_dbg(dev, "asserted RESET\n");
> + msleep(REALTEK_HW_STOP_DELAY);
> + gpiod_set_value(priv->reset, 0);
> + msleep(REALTEK_HW_START_DELAY);
> + dev_dbg(dev, "deasserted RESET\n");
> + }
> +
> ret = priv->ops->detect(priv);
> if (ret) {
> dev_err(dev, "unable to detect switch\n");
> @@ -185,6 +200,10 @@ static void realtek_mdio_remove(struct mdio_device *mdiodev)
>
> dsa_unregister_switch(priv->ds);
>
> + /* leave the device reset asserted */
> + if (priv->reset)
> + gpiod_set_value(priv->reset, 1);
> +
> dev_set_drvdata(&mdiodev->dev, NULL);
> }
>
> diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c
> index 946fbbd70153..a13ef07080a2 100644
> --- a/drivers/net/dsa/realtek/realtek-smi.c
> +++ b/drivers/net/dsa/realtek/realtek-smi.c
> @@ -43,8 +43,6 @@
> #include "realtek.h"
>
> #define REALTEK_SMI_ACK_RETRY_COUNT 5
> -#define REALTEK_SMI_HW_STOP_DELAY 25 /* msecs */
> -#define REALTEK_SMI_HW_START_DELAY 100 /* msecs */
>
> static inline void realtek_smi_clk_delay(struct realtek_priv *priv)
> {
> @@ -426,10 +424,13 @@ static int realtek_smi_probe(struct platform_device *pdev)
> dev_err(dev, "failed to get RESET GPIO\n");
> return PTR_ERR(priv->reset);
> }
> - msleep(REALTEK_SMI_HW_STOP_DELAY);
> - gpiod_set_value(priv->reset, 0);
> - msleep(REALTEK_SMI_HW_START_DELAY);
> - dev_info(dev, "deasserted RESET\n");
> + if (priv->reset) {
> + dev_dbg(dev, "asserted RESET\n");
> + msleep(REALTEK_HW_STOP_DELAY);
> + gpiod_set_value(priv->reset, 0);
> + msleep(REALTEK_HW_START_DELAY);
> + dev_dbg(dev, "deasserted RESET\n");
> + }
>
> /* Fetch MDIO pins */
> priv->mdc = devm_gpiod_get_optional(dev, "mdc", GPIOD_OUT_LOW);
> @@ -474,7 +475,9 @@ static int realtek_smi_remove(struct platform_device *pdev)
> dsa_unregister_switch(priv->ds);
> if (priv->slave_mii_bus)
> of_node_put(priv->slave_mii_bus->dev.of_node);
> - gpiod_set_value(priv->reset, 1);
> +
> + if (priv->reset)
> + gpiod_set_value(priv->reset, 1);
>
> platform_set_drvdata(pdev, NULL);
>
> diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
> index 3512b832b148..e7d3e1bcf8b8 100644
> --- a/drivers/net/dsa/realtek/realtek.h
> +++ b/drivers/net/dsa/realtek/realtek.h
> @@ -13,6 +13,9 @@
> #include <linux/gpio/consumer.h>
> #include <net/dsa.h>
>
> +#define REALTEK_HW_STOP_DELAY 25 /* msecs */
> +#define REALTEK_HW_START_DELAY 100 /* msecs */
> +
> struct realtek_ops;
> struct dentry;
> struct inode;
> --
> 2.35.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup
2022-02-12 2:47 [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup Arınç ÜNAL
@ 2022-02-13 12:31 ` Alvin Šipraga
2022-02-13 22:28 ` Luiz Angelo Daros de Luca
0 siblings, 1 reply; 5+ messages in thread
From: Alvin Šipraga @ 2022-02-13 12:31 UTC (permalink / raw)
To: Arınç ÜNAL
Cc: Luiz Angelo Daros de Luca, netdev, linus.walleij, andrew,
vivien.didelot, f.fainelli, olteanv, davem, kuba,
Frank Wunderlich
Arınç ÜNAL <arinc.unal@arinc9.com> writes:
>
>>
>> On 12 Feb 2022, at 05:27, Luiz Angelo Daros de Luca <luizluca@gmail.com> wrote:
>>
>> Some devices, like the switch in Banana Pi BPI R64 only starts to answer
>> after a HW reset. It is the same reset code from realtek-smi.
>>
>> In realtek-smi, only assert the reset when the gpio is defined.
>
> If realtek-smi also resets before setup with this patch (I don’t understand code very well) can you mention it next to mdio in the summary too?
realtek-smi was already asserting reset. I just asked Luiz to send a
patch to only try the reset if reset-gpio is actually specified, else it
prints "asserting RESET" without actually doing it. So this is largely
cosmetic. But it is odd to touch realtek-smi when the subject is
realtek-mdio.
Arguably this could be separated into a few patches; something to
consider if you decide to send a v3 per Florian's comment:
1. realtek-smi: add if block around reset-gpio assertion
2. realtek-smi: demote dev_info to dev_dbg in reset-gpio assertion
3. realtek-mdio: add HW reset here too, based on realtek-smi (with
dev_dbg)
Kind regards,
Alvin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup
2022-02-13 12:31 ` Alvin Šipraga
@ 2022-02-13 22:28 ` Luiz Angelo Daros de Luca
0 siblings, 0 replies; 5+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-02-13 22:28 UTC (permalink / raw)
To: Alvin Šipraga
Cc: Arınç ÜNAL, netdev, linus.walleij, andrew,
vivien.didelot, f.fainelli, olteanv, davem, kuba,
Frank Wunderlich
> > If realtek-smi also resets before setup with this patch (I don’t understand code very well) can you mention it next to mdio in the summary too?
>
> realtek-smi was already asserting reset. I just asked Luiz to send a
> patch to only try the reset if reset-gpio is actually specified, else it
> prints "asserting RESET" without actually doing it. So this is largely
> cosmetic. But it is odd to touch realtek-smi when the subject is
> realtek-mdio.
>
> Arguably this could be separated into a few patches; something to
> consider if you decide to send a v3 per Florian's comment:
>
> 1. realtek-smi: add if block around reset-gpio assertion
> 2. realtek-smi: demote dev_info to dev_dbg in reset-gpio assertion
> 3. realtek-mdio: add HW reset here too, based on realtek-smi (with
> dev_dbg)
I won't be a problem.
>
> Kind regards,
> Alvin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup
2022-02-12 2:27 Luiz Angelo Daros de Luca
@ 2022-02-12 3:50 ` Florian Fainelli
0 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2022-02-12 3:50 UTC (permalink / raw)
To: Luiz Angelo Daros de Luca, netdev
Cc: linus.walleij, andrew, vivien.didelot, olteanv, davem, kuba,
alsi, arinc.unal, Frank Wunderlich
On 2/11/2022 6:27 PM, Luiz Angelo Daros de Luca wrote:
> Some devices, like the switch in Banana Pi BPI R64 only starts to answer
> after a HW reset. It is the same reset code from realtek-smi.
>
> In realtek-smi, only assert the reset when the gpio is defined.
>
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> Tested-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ---
> drivers/net/dsa/realtek/realtek-mdio.c | 19 +++++++++++++++++++
> drivers/net/dsa/realtek/realtek-smi.c | 17 ++++++++++-------
> drivers/net/dsa/realtek/realtek.h | 3 +++
> 3 files changed, 32 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c
> index 0c5f2bdced9d..fa2339763c71 100644
> --- a/drivers/net/dsa/realtek/realtek-mdio.c
> +++ b/drivers/net/dsa/realtek/realtek-mdio.c
> @@ -152,6 +152,21 @@ static int realtek_mdio_probe(struct mdio_device *mdiodev)
> /* TODO: if power is software controlled, set up any regulators here */
> priv->leds_disabled = of_property_read_bool(np, "realtek,disable-leds");
>
> + /* Assert then deassert RESET */
This is extra nitpicky and I would not want you to submit a v3 just
because of that, but the comment applies to the block of code after that
one. Immediately below is when you fetch the reset line.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup
@ 2022-02-12 2:27 Luiz Angelo Daros de Luca
2022-02-12 3:50 ` Florian Fainelli
0 siblings, 1 reply; 5+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-02-12 2:27 UTC (permalink / raw)
To: netdev
Cc: linus.walleij, andrew, vivien.didelot, f.fainelli, olteanv,
davem, kuba, alsi, arinc.unal, Luiz Angelo Daros de Luca,
Frank Wunderlich
Some devices, like the switch in Banana Pi BPI R64 only starts to answer
after a HW reset. It is the same reset code from realtek-smi.
In realtek-smi, only assert the reset when the gpio is defined.
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Tested-by: Frank Wunderlich <frank-w@public-files.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
---
drivers/net/dsa/realtek/realtek-mdio.c | 19 +++++++++++++++++++
drivers/net/dsa/realtek/realtek-smi.c | 17 ++++++++++-------
drivers/net/dsa/realtek/realtek.h | 3 +++
3 files changed, 32 insertions(+), 7 deletions(-)
diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c
index 0c5f2bdced9d..fa2339763c71 100644
--- a/drivers/net/dsa/realtek/realtek-mdio.c
+++ b/drivers/net/dsa/realtek/realtek-mdio.c
@@ -152,6 +152,21 @@ static int realtek_mdio_probe(struct mdio_device *mdiodev)
/* TODO: if power is software controlled, set up any regulators here */
priv->leds_disabled = of_property_read_bool(np, "realtek,disable-leds");
+ /* Assert then deassert RESET */
+ priv->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
+ if (IS_ERR(priv->reset)) {
+ dev_err(dev, "failed to get RESET GPIO\n");
+ return PTR_ERR(priv->reset);
+ }
+
+ if (priv->reset) {
+ dev_dbg(dev, "asserted RESET\n");
+ msleep(REALTEK_HW_STOP_DELAY);
+ gpiod_set_value(priv->reset, 0);
+ msleep(REALTEK_HW_START_DELAY);
+ dev_dbg(dev, "deasserted RESET\n");
+ }
+
ret = priv->ops->detect(priv);
if (ret) {
dev_err(dev, "unable to detect switch\n");
@@ -185,6 +200,10 @@ static void realtek_mdio_remove(struct mdio_device *mdiodev)
dsa_unregister_switch(priv->ds);
+ /* leave the device reset asserted */
+ if (priv->reset)
+ gpiod_set_value(priv->reset, 1);
+
dev_set_drvdata(&mdiodev->dev, NULL);
}
diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c
index 946fbbd70153..a13ef07080a2 100644
--- a/drivers/net/dsa/realtek/realtek-smi.c
+++ b/drivers/net/dsa/realtek/realtek-smi.c
@@ -43,8 +43,6 @@
#include "realtek.h"
#define REALTEK_SMI_ACK_RETRY_COUNT 5
-#define REALTEK_SMI_HW_STOP_DELAY 25 /* msecs */
-#define REALTEK_SMI_HW_START_DELAY 100 /* msecs */
static inline void realtek_smi_clk_delay(struct realtek_priv *priv)
{
@@ -426,10 +424,13 @@ static int realtek_smi_probe(struct platform_device *pdev)
dev_err(dev, "failed to get RESET GPIO\n");
return PTR_ERR(priv->reset);
}
- msleep(REALTEK_SMI_HW_STOP_DELAY);
- gpiod_set_value(priv->reset, 0);
- msleep(REALTEK_SMI_HW_START_DELAY);
- dev_info(dev, "deasserted RESET\n");
+ if (priv->reset) {
+ dev_dbg(dev, "asserted RESET\n");
+ msleep(REALTEK_HW_STOP_DELAY);
+ gpiod_set_value(priv->reset, 0);
+ msleep(REALTEK_HW_START_DELAY);
+ dev_dbg(dev, "deasserted RESET\n");
+ }
/* Fetch MDIO pins */
priv->mdc = devm_gpiod_get_optional(dev, "mdc", GPIOD_OUT_LOW);
@@ -474,7 +475,9 @@ static int realtek_smi_remove(struct platform_device *pdev)
dsa_unregister_switch(priv->ds);
if (priv->slave_mii_bus)
of_node_put(priv->slave_mii_bus->dev.of_node);
- gpiod_set_value(priv->reset, 1);
+
+ if (priv->reset)
+ gpiod_set_value(priv->reset, 1);
platform_set_drvdata(pdev, NULL);
diff --git a/drivers/net/dsa/realtek/realtek.h b/drivers/net/dsa/realtek/realtek.h
index 3512b832b148..e7d3e1bcf8b8 100644
--- a/drivers/net/dsa/realtek/realtek.h
+++ b/drivers/net/dsa/realtek/realtek.h
@@ -13,6 +13,9 @@
#include <linux/gpio/consumer.h>
#include <net/dsa.h>
+#define REALTEK_HW_STOP_DELAY 25 /* msecs */
+#define REALTEK_HW_START_DELAY 100 /* msecs */
+
struct realtek_ops;
struct dentry;
struct inode;
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-13 22:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 2:47 [PATCH net-next v2] net: dsa: realtek: realtek-mdio: reset before setup Arınç ÜNAL
2022-02-13 12:31 ` Alvin Šipraga
2022-02-13 22:28 ` Luiz Angelo Daros de Luca
-- strict thread matches above, loose matches on Subject: below --
2022-02-12 2:27 Luiz Angelo Daros de Luca
2022-02-12 3:50 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.