[PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[laerdevstudios]

From: Parth Sane <laerdevstudios@gmail.com>

Fixed multiple assignment checkpatch warning by rearranging code.

Signed-off-by: Parth Sane <laerdevstudios@gmail.com>

---
 drivers/staging/netlogic/platform_net.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index 7806c2b..daee1b2 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
 
 	res++;
 	res->name = "gmac";
-	res->start = res->end = irq;
+	res->end = irq;
+	res->start = res->end;
 	res->flags = IORESOURCE_IRQ;
 }
 
-- 
2.1.4

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Parth Sane]

[-- Attachment #1.1: Type: text/plain, Size: 1057 bytes --]

Hi,
I haven’t received any feedback as to whether my patch has been accepted. Would request someone to kindly help me out. Maybe you could weigh in here Greg?
Regards,
Parth Sane
> On 15-Mar-2016, at 10:16 PM, laerdevstudios@gmail.com wrote:
> 
> From: Parth Sane <laerdevstudios@gmail.com>
> 
> Fixed multiple assignment checkpatch warning by rearranging code.
> 
> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> 
> ---
> drivers/staging/netlogic/platform_net.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index 7806c2b..daee1b2 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
> 
> 	res++;
> 	res->name = "gmac";
> -	res->start = res->end = irq;
> +	res->end = irq;
> +	res->start = res->end;
> 	res->flags = IORESOURCE_IRQ;
> }
> 
> --
> 2.1.4
> 


[-- Attachment #1.2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

[-- Attachment #2: Type: text/plain, Size: 169 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Roger H Newell]

On Sat, Mar 19, 2016 at 2:04 PM, Parth Sane <laerdevstudios@gmail.com> wrote:
> Hi,
> I haven’t received any feedback as to whether my patch has been accepted. Would request someone to kindly help me out. Maybe you could weigh in here Greg?
> Regards,
> Parth Sane
>> On 15-Mar-2016, at 10:16 PM, laerdevstudios@gmail.com wrote:
>>
>> From: Parth Sane <laerdevstudios@gmail.com>
>>
>> Fixed multiple assignment checkpatch warning by rearranging code.
>>
>> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
>>
>> ---
>> drivers/staging/netlogic/platform_net.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
>> index 7806c2b..daee1b2 100644
>> --- a/drivers/staging/netlogic/platform_net.c
>> +++ b/drivers/staging/netlogic/platform_net.c
>> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
>>
>>       res++;
>>       res->name = "gmac";
>> -     res->start = res->end = irq;
>> +     res->end = irq;
>> +     res->start = res->end;
>>       res->flags = IORESOURCE_IRQ;
>> }
>>
>> --
>> 2.1.4
>>
>
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>

This patch is only 4 days old. It's likely in Gregs queue and you just
have to wait a bit longer.  I don't think you need the From: line in
the body of the patch. The Signed-off-by: should suffice.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Parth Sane]

[-- Attachment #1: Type: text/plain, Size: 1967 bytes --]

Hi Roger,
Can I submit more patches similarly until this has been accepted? I’ll be sure to remove the from part in my next patch(I hope I don’t have to submit the earlier patch again).Thanks for your wise comments!
Regards,
Parth Sane
> On 19-Mar-2016, at 10:33 PM, Roger H Newell <newell.roger@gmail.com> wrote:
> 
> On Sat, Mar 19, 2016 at 2:04 PM, Parth Sane <laerdevstudios@gmail.com> wrote:
>> Hi,
>> I haven’t received any feedback as to whether my patch has been accepted. Would request someone to kindly help me out. Maybe you could weigh in here Greg?
>> Regards,
>> Parth Sane
>>> On 15-Mar-2016, at 10:16 PM, laerdevstudios@gmail.com wrote:
>>> 
>>> From: Parth Sane <laerdevstudios@gmail.com>
>>> 
>>> Fixed multiple assignment checkpatch warning by rearranging code.
>>> 
>>> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
>>> 
>>> ---
>>> drivers/staging/netlogic/platform_net.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
>>> index 7806c2b..daee1b2 100644
>>> --- a/drivers/staging/netlogic/platform_net.c
>>> +++ b/drivers/staging/netlogic/platform_net.c
>>> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
>>> 
>>>     res++;
>>>     res->name = "gmac";
>>> -     res->start = res->end = irq;
>>> +     res->end = irq;
>>> +     res->start = res->end;
>>>     res->flags = IORESOURCE_IRQ;
>>> }
>>> 
>>> --
>>> 2.1.4
>>> 
>> 
>> 
>> _______________________________________________
>> devel mailing list
>> devel@linuxdriverproject.org
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>> 
> 
> This patch is only 4 days old. It's likely in Gregs queue and you just
> have to wait a bit longer.  I don't think you need the From: line in
> the body of the patch. The Signed-off-by: should suffice.


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Greg KH]

On Sat, Mar 19, 2016 at 10:04:23PM +0530, Parth Sane wrote:
> Hi,
> I haven’t received any feedback as to whether my patch has been accepted. Would request someone to kindly help me out. Maybe you could weigh in here Greg?
> Regards,
> Parth Sane
> > On 15-Mar-2016, at 10:16 PM, laerdevstudios@gmail.com wrote:

4 days later in the middle of a merge window when I can't add any new
patches to my queue?  Please be patient, I will get to this after
4.6-rc1 is out.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Parth Sane]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Hi,
Thanks for getting back to me Greg! I’m still learning, so thanks again for bearing with me!
Regards,
Parth Sane
> On 19-Mar-2016, at 10:43 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> On Sat, Mar 19, 2016 at 10:04:23PM +0530, Parth Sane wrote:
>> Hi,
>> I haven’t received any feedback as to whether my patch has been accepted. Would request someone to kindly help me out. Maybe you could weigh in here Greg?
>> Regards,
>> Parth Sane
>>> On 15-Mar-2016, at 10:16 PM, laerdevstudios@gmail.com wrote:
> 
> 4 days later in the middle of a merge window when I can't add any new
> patches to my queue?  Please be patient, I will get to this after
> 4.6-rc1 is out.
> 
> thanks,
> 
> greg k-h


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Greg KH]

On Tue, Mar 15, 2016 at 04:46:24PM +0000, laerdevstudios@gmail.com wrote:
> From: Parth Sane <laerdevstudios@gmail.com>
> 
> Fixed multiple assignment checkpatch warning by rearranging code.
> 
> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> 
> ---
>  drivers/staging/netlogic/platform_net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index 7806c2b..daee1b2 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
>  
>  	res++;
>  	res->name = "gmac";
> -	res->start = res->end = irq;
> +	res->end = irq;
> +	res->start = res->end;
>  	res->flags = IORESOURCE_IRQ;
>  }
>  

This patch is already in Linus's tree, be sure to always work against
the linux-next tree at the very least.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Greg KH]

On Tue, Mar 15, 2016 at 04:23:12PM +0000, laerdevstudios@gmail.com wrote:
> From: Parth Sane <laerdevstudios@gmail.com>
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index 7806c2b..daee1b2 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
>  
>  	res++;
>  	res->name = "gmac";
> -	res->start = res->end = irq;
> +	res->end = irq;
> +	res->start = res->end;
>  	res->flags = IORESOURCE_IRQ;
>  }
>  
> -- 
> 2.1.4


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[laerdevstudios]

From: Parth Sane <laerdevstudios@gmail.com>

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index 7806c2b..daee1b2 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
 
 	res++;
 	res->name = "gmac";
-	res->start = res->end = irq;
+	res->end = irq;
+	res->start = res->end;
 	res->flags = IORESOURCE_IRQ;
 }
 
-- 
2.1.4

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Michal Marek]

This should go to the staging mailing list.

Michal

Dne 11.3.2016 v 10:22 laerdevstudios@gmail.com napsal(a):
> From: Parth Sane <laerdevstudios@gmail.com>
> 
> Fixed netlogic checkpatch multiple assignment warning in platform_net.c
> 
> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> ---
>  drivers/staging/netlogic/platform_net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index 7806c2b..daee1b2 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
>  
>  	res++;
>  	res->name = "gmac";
> -	res->start = res->end = irq;
> +	res->end = irq;
> +	res->start = res->end;
>  	res->flags = IORESOURCE_IRQ;
>  }
>  
> 

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Michal Marek]

This should go to the staging mailing list.

Michal

Dne 11.3.2016 v 10:22 laerdevstudios@gmail.com napsal(a):
> From: Parth Sane <laerdevstudios@gmail.com>
> 
> Fixed netlogic checkpatch multiple assignment warning in platform_net.c
> 
> Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
> ---
>  drivers/staging/netlogic/platform_net.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index 7806c2b..daee1b2 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
>  
>  	res++;
>  	res->name = "gmac";
> -	res->start = res->end = irq;
> +	res->end = irq;
> +	res->start = res->end;
>  	res->flags = IORESOURCE_IRQ;
>  }
>  
> 

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[laerdevstudios]

From: Parth Sane <laerdevstudios@gmail.com>

Fixed netlogic checkpatch multiple assignment warning in platform_net.c

Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
---
 drivers/staging/netlogic/platform_net.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index 7806c2b..daee1b2 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
 
 	res++;
 	res->name = "gmac";
-	res->start = res->end = irq;
+	res->end = irq;
+	res->start = res->end;
 	res->flags = IORESOURCE_IRQ;
 }
 
-- 
2.1.4

Re: [PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[Parth Sane]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

Hi,
I forgot to add the signed off part in the patch please ignore the previous patches I have sent. Please bear with a kernel newbie.
Regards,
Parth Sane
> On 11-Mar-2016, at 2:45 PM, laerdevstudios@gmail.com wrote:
> 
> From: Parth Sane <laerdevstudios@gmail.com>
> 
> diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
> index 7806c2b..daee1b2 100644
> --- a/drivers/staging/netlogic/platform_net.c
> +++ b/drivers/staging/netlogic/platform_net.c
> @@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
> 
> 	res++;
> 	res->name = "gmac";
> -	res->start = res->end = irq;
> +	res->end = irq;
> +	res->start = res->end;
> 	res->flags = IORESOURCE_IRQ;
> }
> 
> --
> 2.1.4
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

[PATCH] staging: netlogic: removed 1 multiple assignment checkpatch warning

[laerdevstudios]

From: Parth Sane <laerdevstudios@gmail.com>

diff --git a/drivers/staging/netlogic/platform_net.c b/drivers/staging/netlogic/platform_net.c
index 7806c2b..daee1b2 100644
--- a/drivers/staging/netlogic/platform_net.c
+++ b/drivers/staging/netlogic/platform_net.c
@@ -86,7 +86,8 @@ static void xlr_resource_init(struct resource *res, int offset, int irq)
 
 	res++;
 	res->name = "gmac";
-	res->start = res->end = irq;
+	res->end = irq;
+	res->start = res->end;
 	res->flags = IORESOURCE_IRQ;
 }
 
-- 
2.1.4