[scsi:misc 64/77] drivers/scsi/aacraid/linit.c:1321:6: sparse: symbol 'aac_release_resources' was not declared. Should it be static?

[scsi:misc 64/77] drivers/scsi/aacraid/linit.c:1321:6: sparse: symbol 'aac_release_resources' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head:   46782becf4cc80153bdefebdb548ad35a5cd8b06
commit: de665f28f788ad72ff6a0ce6ac2721d77248b7cf [64/77] aacraid: Add Power Management support
reproduce:
        # apt-get install sparse
        git checkout de665f28f788ad72ff6a0ce6ac2721d77248b7cf
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/scsi/aacraid/linit.c:1321:6: sparse: symbol 'aac_release_resources' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH scsi] aacraid: aac_release_resources() can be static

[kbuild test robot]

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 linit.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 37375cf..7724583f 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -1318,7 +1318,7 @@ static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 }
 
 #if (defined(CONFIG_PM))
-void aac_release_resources(struct aac_dev *aac)
+static void aac_release_resources(struct aac_dev *aac)
 {
 	int i;
 

Re: [RFC PATCH scsi] aacraid: aac_release_resources() can be static

[Johannes Thumshirn]

On Tue, 2015-11-10 at 13:59 +0800, kbuild test robot wrote:
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  linit.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/linit.c
> b/drivers/scsi/aacraid/linit.c
> index 37375cf..7724583f 100644
> --- a/drivers/scsi/aacraid/linit.c
> +++ b/drivers/scsi/aacraid/linit.c
> @@ -1318,7 +1318,7 @@ static int aac_probe_one(struct pci_dev *pdev,
> const struct pci_device_id *id)
>  }
>  
>  #if (defined(CONFIG_PM))
> -void aac_release_resources(struct aac_dev *aac)
> +static void aac_release_resources(struct aac_dev *aac)
>  {
>  	int i;
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" 
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [RFC PATCH scsi] aacraid: aac_release_resources() can be static

[Mahesh Rajashekhara]

Reviewed-by: Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com] 
Sent: Tuesday, November 10, 2015 11:29 AM
To: Mahesh Rajashekhara
Cc: kbuild-all@01.org; linux-scsi@vger.kernel.org; James Bottomley; Tomas Henzl; Murthy Bhat; Karthikeya Sunkesula
Subject: [RFC PATCH scsi] aacraid: aac_release_resources() can be static


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 linit.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 37375cf..7724583f 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -1318,7 +1318,7 @@ static int aac_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)  }
 
 #if (defined(CONFIG_PM))
-void aac_release_resources(struct aac_dev *aac)
+static void aac_release_resources(struct aac_dev *aac)
 {
 	int i;