* [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 7:22 ` Xing Zheng
0 siblings, 0 replies; 12+ messages in thread
From: Xing Zheng @ 2016-01-10 7:22 UTC (permalink / raw)
To: linux-rockchip
Cc: keescook, leozwang, heiko, Xing Zheng, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, devicetree,
linux-arm-kernel, linux-kernel
Because the RK3036 doesn't support EMAC, and only support the RMII mode
in the EMAC IP, we refer to the TRM CRU and update the new external
clock name for EMAC.
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---
.../bindings/clock/rockchip,rk3036-cru.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
index ace0599..20df350 100644
--- a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
+++ b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
@@ -30,7 +30,7 @@ that they are defined using standard clock bindings with following
clock-output-names:
- "xin24m" - crystal input - required,
- "ext_i2s" - external I2S clock - optional,
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional
Example: Clock controller node:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 7:22 ` Xing Zheng
0 siblings, 0 replies; 12+ messages in thread
From: Xing Zheng @ 2016-01-10 7:22 UTC (permalink / raw)
To: linux-arm-kernel
Because the RK3036 doesn't support EMAC, and only support the RMII mode
in the EMAC IP, we refer to the TRM CRU and update the new external
clock name for EMAC.
Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---
.../bindings/clock/rockchip,rk3036-cru.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
index ace0599..20df350 100644
--- a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
+++ b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
@@ -30,7 +30,7 @@ that they are defined using standard clock bindings with following
clock-output-names:
- "xin24m" - crystal input - required,
- "ext_i2s" - external I2S clock - optional,
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional
Example: Clock controller node:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 9:59 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2016-01-10 9:59 UTC (permalink / raw)
To: Xing Zheng
Cc: linux-rockchip, keescook, leozwang, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, devicetree,
linux-arm-kernel, linux-kernel
Hi Xing,
Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> Because the RK3036 doesn't support EMAC, and only support the RMII mode
> in the EMAC IP, we refer to the TRM CRU and update the new external
> clock name for EMAC.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
as I said in the other mail, I already fixed the original patch myself :-)
So I'm just going to drop this one.
Heiko
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 9:59 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2016-01-10 9:59 UTC (permalink / raw)
To: Xing Zheng
Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Pawel Moll,
Ian Campbell, Kumar Gala, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
keescook-hpIqsD4AKlfQT0dZR+AlfA, leozwang-hpIqsD4AKlfQT0dZR+AlfA
Hi Xing,
Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> Because the RK3036 doesn't support EMAC, and only support the RMII mode
> in the EMAC IP, we refer to the TRM CRU and update the new external
> clock name for EMAC.
>
> Signed-off-by: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
as I said in the other mail, I already fixed the original patch myself :-)
So I'm just going to drop this one.
Heiko
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 9:59 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2016-01-10 9:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Xing,
Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> Because the RK3036 doesn't support EMAC, and only support the RMII mode
> in the EMAC IP, we refer to the TRM CRU and update the new external
> clock name for EMAC.
>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
as I said in the other mail, I already fixed the original patch myself :-)
So I'm just going to drop this one.
Heiko
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
2016-01-10 9:59 ` Heiko Stuebner
@ 2016-01-10 10:29 ` Xing Zheng
-1 siblings, 0 replies; 12+ messages in thread
From: Xing Zheng @ 2016-01-10 10:29 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip, keescook, leozwang, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, devicetree,
linux-arm-kernel, linux-kernel, xing.zheng
Hi Heiko,
> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
>
> Hi Xing,
>
> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>> in the EMAC IP, we refer to the TRM CRU and update the new external
>> clock name for EMAC.
>>
>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>
> as I said in the other mail, I already fixed the original patch myself :-)
> So I'm just going to drop this one.
>
>
> Heiko
>
> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
>
I am sorry to misunderstand.
OK, thank you for your help. :)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 10:29 ` Xing Zheng
0 siblings, 0 replies; 12+ messages in thread
From: Xing Zheng @ 2016-01-10 10:29 UTC (permalink / raw)
To: linux-arm-kernel
Hi Heiko,
> ? 2016?1?10??17:59?Heiko Stuebner <heiko@sntech.de> ???
>
> Hi Xing,
>
> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>> in the EMAC IP, we refer to the TRM CRU and update the new external
>> clock name for EMAC.
>>
>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>
> as I said in the other mail, I already fixed the original patch myself :-)
> So I'm just going to drop this one.
>
>
> Heiko
>
> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
>
I am sorry to misunderstand.
OK, thank you for your help. :)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
2016-01-10 10:29 ` Xing Zheng
@ 2016-01-10 10:36 ` Xing Zheng
-1 siblings, 0 replies; 12+ messages in thread
From: Xing Zheng @ 2016-01-10 10:36 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip, keescook, leozwang, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, devicetree,
linux-arm-kernel, linux-kernel, xing.zheng
Hi Heiko,
> 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
>
>
> Hi Heiko,
>
>> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
>>
>> Hi Xing,
>>
>> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>>> in the EMAC IP, we refer to the TRM CRU and update the new external
>>> clock name for EMAC.
>>>
>>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>>
>> as I said in the other mail, I already fixed the original patch myself :-)
>> So I'm just going to drop this one.
>>
>>
>> Heiko
>>
>> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
> I am sorry to misunderstand.
>
> OK, thank you for your help. :)
Your patch is:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external GMAC clock - optional
I think that these should be like this:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional
Thanks. :)
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 10:36 ` Xing Zheng
0 siblings, 0 replies; 12+ messages in thread
From: Xing Zheng @ 2016-01-10 10:36 UTC (permalink / raw)
To: linux-arm-kernel
Hi Heiko,
> ? 2016?1?10??18:29?Xing Zheng <zhengxing@rock-chips.com> ???
>
>
> Hi Heiko,
>
>> ? 2016?1?10??17:59?Heiko Stuebner <heiko@sntech.de> ???
>>
>> Hi Xing,
>>
>> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>>> in the EMAC IP, we refer to the TRM CRU and update the new external
>>> clock name for EMAC.
>>>
>>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>>
>> as I said in the other mail, I already fixed the original patch myself :-)
>> So I'm just going to drop this one.
>>
>>
>> Heiko
>>
>> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
> I am sorry to misunderstand.
>
> OK, thank you for your help. :)
Your patch is:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external GMAC clock - optional
I think that these should be like this:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional
Thanks. :)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 18:23 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2016-01-10 18:23 UTC (permalink / raw)
To: Xing Zheng
Cc: linux-rockchip, keescook, leozwang, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, devicetree,
linux-arm-kernel, linux-kernel, xing.zheng
Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng:
> Hi Heiko,
>
> > 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
> >
> >
> > Hi Heiko,
> >
> >> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
> >>
> >> Hi Xing,
> >>
> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> >>> Because the RK3036 doesn't support EMAC, and only support the RMII
> >>> mode
> >>> in the EMAC IP, we refer to the TRM CRU and update the new external
> >>> clock name for EMAC.
> >>>
> >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> >>
> >> as I said in the other mail, I already fixed the original patch myself
> >> :-) So I'm just going to drop this one.
> >>
> >>
> >> Heiko
> >>
> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c
> >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931>
> > I am sorry to misunderstand.
> >
> > OK, thank you for your help. :)
>
> Your patch is:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external GMAC clock - optional
>
> I think that these should be like this:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external EMAC clock - optional
I fixed that up now, thanks for catching this.
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371
Heiko
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 18:23 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2016-01-10 18:23 UTC (permalink / raw)
To: Xing Zheng
Cc: Mark Rutland, devicetree-u79uwXL29TY76Z2rM5mHXA, Pawel Moll,
Ian Campbell, Kumar Gala, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Rob Herring,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
keescook-hpIqsD4AKlfQT0dZR+AlfA, leozwang-hpIqsD4AKlfQT0dZR+AlfA,
xing.zheng-TNX95d0MmH7DzftRWevZcw
Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng:
> Hi Heiko,
>
> > 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
> >
> >
> > Hi Heiko,
> >
> >> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
> >>
> >> Hi Xing,
> >>
> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> >>> Because the RK3036 doesn't support EMAC, and only support the RMII
> >>> mode
> >>> in the EMAC IP, we refer to the TRM CRU and update the new external
> >>> clock name for EMAC.
> >>>
> >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> >>
> >> as I said in the other mail, I already fixed the original patch myself
> >> :-) So I'm just going to drop this one.
> >>
> >>
> >> Heiko
> >>
> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c
> >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931>
> > I am sorry to misunderstand.
> >
> > OK, thank you for your help. :)
>
> Your patch is:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external GMAC clock - optional
>
> I think that these should be like this:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external EMAC clock - optional
I fixed that up now, thanks for catching this.
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
@ 2016-01-10 18:23 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2016-01-10 18:23 UTC (permalink / raw)
To: linux-arm-kernel
Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng:
> Hi Heiko,
>
> > ? 2016?1?10??18:29?Xing Zheng <zhengxing@rock-chips.com> ???
> >
> >
> > Hi Heiko,
> >
> >> ? 2016?1?10??17:59?Heiko Stuebner <heiko@sntech.de> ???
> >>
> >> Hi Xing,
> >>
> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> >>> Because the RK3036 doesn't support EMAC, and only support the RMII
> >>> mode
> >>> in the EMAC IP, we refer to the TRM CRU and update the new external
> >>> clock name for EMAC.
> >>>
> >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> >>
> >> as I said in the other mail, I already fixed the original patch myself
> >> :-) So I'm just going to drop this one.
> >>
> >>
> >> Heiko
> >>
> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c
> >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931>
> > I am sorry to misunderstand.
> >
> > OK, thank you for your help. :)
>
> Your patch is:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external GMAC clock - optional
>
> I think that these should be like this:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external EMAC clock - optional
I fixed that up now, thanks for catching this.
https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371
Heiko
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-01-10 18:24 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-10 7:22 [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng
2016-01-10 7:22 ` Xing Zheng
2016-01-10 9:59 ` Heiko Stuebner
2016-01-10 9:59 ` Heiko Stuebner
2016-01-10 9:59 ` Heiko Stuebner
2016-01-10 10:29 ` Xing Zheng
2016-01-10 10:29 ` Xing Zheng
2016-01-10 10:36 ` Xing Zheng
2016-01-10 10:36 ` Xing Zheng
2016-01-10 18:23 ` Heiko Stuebner
2016-01-10 18:23 ` Heiko Stuebner
2016-01-10 18:23 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.