From: keith.busch@intel.com (Busch, Keith)
Subject: [PATCH 1/2] NVMe: Make surprise removal work again
Date: Mon, 1 Feb 2016 15:27:24 +0000 [thread overview]
Message-ID: <B58D82457FDA0744A320A2FC5AC253B93D3D7E4F@fmsmsx104.amr.corp.intel.com> (raw)
In-Reply-To: <BJXPR01MB199DDC40C3949335FD70DEBE0DE0@BJXPR01MB199.CHNPR01.prod.partner.outlook.cn>
> Subject: RE: [PATCH 1/2] NVMe: Make surprise removal work again
>
> > blk_mq_abort_requeue_list(ns->queue);
> >+ __nvme_start_queue_locked(ns);
>
> Why is the queue stopped? Is it due to unsuccessful device reset (since device is hot removed)?
It could be from an unsuccessful reset if that's the path we took. We also could go straight to the removal case if the pci hotplug driver notifies the driver, in which case this patch will disables the controller first to halt new IO and reap outstanding requests. This also stops queues, so needed to restart it to flush out the pending requests.
Anyway, the direction I was given was to move the request ending to the block layer when we kill it, so this won't be necessary in the next revision (will be sent out today).
next prev parent reply other threads:[~2016-02-01 15:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 21:23 [PATCH 1/2] NVMe: Make surprise removal work again Keith Busch
2016-01-25 21:23 ` [PATCH 2/2] NVMe: Fix io incapable return values Keith Busch
2016-01-26 16:54 ` Christoph Hellwig
2016-01-26 18:11 ` Ming Lin
2016-01-27 11:19 ` Sagi Grimberg
2016-01-26 16:53 ` [PATCH 1/2] NVMe: Make surprise removal work again Christoph Hellwig
2016-01-26 23:59 ` Keith Busch
2016-01-27 11:47 ` Sagi Grimberg
2016-01-27 14:19 ` Keith Busch
2016-01-28 14:48 ` Sagi Grimberg
2016-01-28 14:55 ` Keith Busch
2016-01-28 15:20 ` Sagi Grimberg
2016-02-01 15:01 ` Wenbo Wang
2016-02-01 15:27 ` Busch, Keith [this message]
[not found] ` <B58D82457FDA0744A320A2FC5AC253B93D3D7E57@fmsmsx104.amr.corp.intel.com>
2016-02-02 1:17 ` Keith Busch
2016-02-02 2:41 ` Wenbo Wang
2016-02-02 5:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B58D82457FDA0744A320A2FC5AC253B93D3D7E4F@fmsmsx104.amr.corp.intel.com \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.