* [PATCH] Correctly fail to suspend when SDIO does not support power on suspend
@ 2017-08-31 23:37 Eric Bentley
0 siblings, 0 replies; 4+ messages in thread
From: Eric Bentley @ 2017-08-31 23:37 UTC (permalink / raw)
To: linux-wireless; +Cc: arend.vanspriel
DQpSZXR1cm4gZXJyb3Igd2hlbiBmYWlsaW5nIHRvIHNldCBwb3dlciBtYW5hZ2VtZW50IGNhcGFi
aWxpdGllcyBmbGFnLiAgVGhpcyB3aWxsIGNhdXNlIHRoZSBzdXNwZW5kIHRvIGZhaWwgYnV0IHRo
ZSByYWRpbw0Kd2lsbCBjb250aW51ZSB0byBvcGVyYXRlLiAgQWxsb3dpbmcgdGhpcyB0byBmYWls
IHdpdGhvdXQgcmVwb3J0aW5nIGVycm9yIHdpbGwgY2F1c2UgdGhlIHJhZGlvIHRvIGJlIG5vbi1m
dW5jdGlvbmFsIG9uIA0KcmVzdW1lIGFzIGl0IHdpbGwgaGF2ZSBsb3N0IHBvd2VyLg0KDQpTaWdu
ZWQtb2ZmLWJ5OiBFcmljIEJlbnRsZXkgPGVyaWMuYmVudGxleUBsYWlyZHRlY2guY29tPg0KDQot
LS0NCiBkcml2ZXJzL25ldC93aXJlbGVzcy9icm9hZGNvbS9icmNtODAyMTEvYnJjbWZtYWMvYmNt
c2RoLmMgfCA0ICsrKy0NCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0
aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC93aXJlbGVzcy9icm9hZGNvbS9icmNt
ODAyMTEvYnJjbWZtYWMvYmNtc2RoLmMgYi9kcml2ZXJzL25ldC93aXJlbGVzcy9icm9hZGNvbS9i
cmNtODAyMTEvYnJjbWZtYWMvYmNtc2RoLmMNCmluZGV4IDcyMTM5YjUuLjJmN2QwM2YgMTAwNjQ0
DQotLS0gYS9kcml2ZXJzL25ldC93aXJlbGVzcy9icm9hZGNvbS9icmNtODAyMTEvYnJjbWZtYWMv
YmNtc2RoLmMNCisrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2Jyb2FkY29tL2JyY204MDIxMS9i
cmNtZm1hYy9iY21zZGguYw0KQEAgLTEyNjQsOCArMTI2NCwxMCBAQCBzdGF0aWMgaW50IGJyY21m
X29wc19zZGlvX3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQ0KIAkJZWxzZQ0KIAkJCXNkaW9f
ZmxhZ3MgfD0gTU1DX1BNX1dBS0VfU0RJT19JUlE7DQogCX0NCi0JaWYgKHNkaW9fc2V0X2hvc3Rf
cG1fZmxhZ3Moc2Rpb2Rldi0+ZnVuY1sxXSwgc2Rpb19mbGFncykpDQorCWlmIChzZGlvX3NldF9o
b3N0X3BtX2ZsYWdzKHNkaW9kZXYtPmZ1bmNbMV0sIHNkaW9fZmxhZ3MpKSAoDQogCQlicmNtZl9l
cnIoIkZhaWxlZCB0byBzZXQgcG1fZmxhZ3MgJXhcbiIsIHNkaW9fZmxhZ3MpOw0KKwkJcmV0dXJu
IC1FSU5WQUw7DQorCX0NCiAJcmV0dXJuIDA7DQogfQ0KIA0KLS0gDQoyLjYuMC5HSVQNCg0KDQoN
Cg==
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Correctly fail to suspend when SDIO does not support power on suspend
2017-08-31 23:49 ` Steve deRosier
@ 2017-09-01 0:01 ` Eric Bentley
0 siblings, 0 replies; 4+ messages in thread
From: Eric Bentley @ 2017-09-01 0:01 UTC (permalink / raw)
To: Steve deRosier; +Cc: linux-wireless, arend.vanspriel
WWVwIOKAkyB0cmllZCB0byBjbGVhbiBzb21lIHdoaXRlIHNwYWNlIHVwIGF0IHRoZSBsYXN0IG1p
bnV0ZeKApnVnaA0KDQpPbiA4LzMxLzE3LCA3OjQ5IFBNLCAic3RldmUuZGVyb3NpZXJAZ21haWwu
Y29tIG9uIGJlaGFsZiBvZiBTdGV2ZSBkZVJvc2llciIgPHN0ZXZlLmRlcm9zaWVyQGdtYWlsLmNv
bSBvbiBiZWhhbGYgb2YgZGVyb3NpZXJAZ21haWwuY29tPiB3cm90ZToNCg0KICAgIE9uIFRodSwg
QXVnIDMxLCAyMDE3IGF0IDQ6NDQgUE0sIEVyaWMgQmVudGxleQ0KICAgIDxFcmljLkJlbnRsZXlA
bGFpcmR0ZWNoLmNvbT4gd3JvdGU6DQogICAgPiAtICAgICAgIGlmIChzZGlvX3NldF9ob3N0X3Bt
X2ZsYWdzKHNkaW9kZXYtPmZ1bmNbMV0sIHNkaW9fZmxhZ3MpKQ0KICAgID4gKyAgICAgICBpZiAo
c2Rpb19zZXRfaG9zdF9wbV9mbGFncyhzZGlvZGV2LT5mdW5jWzFdLCBzZGlvX2ZsYWdzKSkgKA0K
ICAgIA0KICAgIEhpIEVyaWMsDQogICAgDQogICAgU2hvdWxkbid0IHRoYXQgYmUgYSAneycgaW5z
dGVhZCBvZiAnKCc/ICBNYXliZSBJJ20gbWlzc2luZyBzb21lDQogICAgY29udGV4dCwgYnV0IHRo
YXQgZG9lc24ndCBsb29rIGNvbXBpbGFibGUuDQogICAgDQogICAgOikNCiAgICANCiAgICAtIFN0
ZXZlDQogICAgDQoNCg==
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Correctly fail to suspend when SDIO does not support power on suspend
2017-08-31 23:44 Eric Bentley
@ 2017-08-31 23:49 ` Steve deRosier
2017-09-01 0:01 ` Eric Bentley
0 siblings, 1 reply; 4+ messages in thread
From: Steve deRosier @ 2017-08-31 23:49 UTC (permalink / raw)
To: Eric Bentley; +Cc: linux-wireless, arend.vanspriel
On Thu, Aug 31, 2017 at 4:44 PM, Eric Bentley
<Eric.Bentley@lairdtech.com> wrote:
> - if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags))
> + if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags)) (
Hi Eric,
Shouldn't that be a '{' instead of '('? Maybe I'm missing some
context, but that doesn't look compilable.
:)
- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Correctly fail to suspend when SDIO does not support power on suspend
@ 2017-08-31 23:44 Eric Bentley
2017-08-31 23:49 ` Steve deRosier
0 siblings, 1 reply; 4+ messages in thread
From: Eric Bentley @ 2017-08-31 23:44 UTC (permalink / raw)
To: linux-wireless; +Cc: arend.vanspriel
Return error when failing to set power management capabilities flag.=A0 Thi=
s will cause the suspend to fail but the radio
will continue to operate.=A0 Allowing this to fail without reporting error =
will cause the radio to be non-functional on=A0
resume as it will have lost power.
Signed-off-by: Eric Bentley <eric.bentley@lairdtech.com>
---
=A0drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 4 +++-
=A01 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/dr=
ivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index 72139b5..2f7d03f 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
@@ -1264,8 +1264,10 @@ static int brcmf_ops_sdio_suspend(struct device *dev=
)
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 else
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 sd=
io_flags |=3D MMC_PM_WAKE_SDIO_IRQ;
=A0=A0=A0=A0=A0=A0=A0=A0 }
-=A0=A0=A0=A0=A0=A0 if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags=
))
+=A0=A0=A0=A0=A0=A0 if (sdio_set_host_pm_flags(sdiodev->func[1], sdio_flags=
)) (
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 brcmf_err("Failed to set p=
m_flags %x\n", sdio_flags);
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return -EINVAL;
+=A0=A0=A0=A0=A0=A0 }
=A0=A0=A0=A0=A0=A0=A0=A0 return 0;
=A0}
=A0
--=A0
2.6.0.GIT
=
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-01 0:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 23:37 [PATCH] Correctly fail to suspend when SDIO does not support power on suspend Eric Bentley
2017-08-31 23:44 Eric Bentley
2017-08-31 23:49 ` Steve deRosier
2017-09-01 0:01 ` Eric Bentley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.