* [U-Boot] [PATCH] lib: time: update module enable MACRO
@ 2019-03-29 14:17 Kever Yang
2019-03-29 14:28 ` Philipp Tomsich
2019-03-29 20:25 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Kever Yang @ 2019-03-29 14:17 UTC (permalink / raw)
To: u-boot
We'd better use correct way to check if module has enabled.
for we have 3 timer MACRO:
- CONFIG_TIMER
- CONFIG_SPL_TIMER
- CONFIG_TPL_TIMER
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
lib/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/time.c b/lib/time.c
index 3bf678a232..9c55da6f1b 100644
--- a/lib/time.c
+++ b/lib/time.c
@@ -56,7 +56,7 @@ ulong timer_get_boot_us(void)
extern unsigned long __weak timer_read_counter(void);
#endif
-#ifdef CONFIG_TIMER
+#if CONFIG_IS_ENABLED(TIMER)
ulong notrace get_tbclk(void)
{
if (!gd->timer) {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] lib: time: update module enable MACRO
2019-03-29 14:17 [U-Boot] [PATCH] lib: time: update module enable MACRO Kever Yang
@ 2019-03-29 14:28 ` Philipp Tomsich
2019-03-29 20:25 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Philipp Tomsich @ 2019-03-29 14:28 UTC (permalink / raw)
To: u-boot
> On 29.03.2019, at 15:17, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> We'd better use correct way to check if module has enabled.
> for we have 3 timer MACRO:
> - CONFIG_TIMER
> - CONFIG_SPL_TIMER
> - CONFIG_TPL_TIMER
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] lib: time: update module enable MACRO
2019-03-29 14:17 [U-Boot] [PATCH] lib: time: update module enable MACRO Kever Yang
2019-03-29 14:28 ` Philipp Tomsich
@ 2019-03-29 20:25 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2019-03-29 20:25 UTC (permalink / raw)
To: u-boot
On Fri, Mar 29, 2019 at 10:17:33PM +0800, Kever Yang wrote:
> We'd better use correct way to check if module has enabled.
> for we have 3 timer MACRO:
> - CONFIG_TIMER
> - CONFIG_SPL_TIMER
> - CONFIG_TPL_TIMER
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190329/83167ad6/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-29 20:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 14:17 [U-Boot] [PATCH] lib: time: update module enable MACRO Kever Yang
2019-03-29 14:28 ` Philipp Tomsich
2019-03-29 20:25 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.