* [PATCH] omap: OMAP_IOMMU not visible in menuconfig
@ 2010-09-08 14:51 Sanjeev Premi
2010-09-09 5:04 ` Hiroshi DOYU
0 siblings, 1 reply; 8+ messages in thread
From: Sanjeev Premi @ 2010-09-08 14:51 UTC (permalink / raw)
To: linux-omap; +Cc: Sanjeev Premi
The menu option to select CONFIG_OMAP_IOMMU
was not visible in the menuconfig due to missing
description.
Signed-off-by: Sanjeev Premi <premi@ti.com>
---
arch/arm/plat-omap/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index e39a417..2a114a9 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
module parameter).
config OMAP_IOMMU
- tristate
+ tristate "OMAP IOMMU support"
config OMAP_IOMMU_DEBUG
tristate "Export OMAP IOMMU internals in DebugFS"
--
1.6.2.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
2010-09-08 14:51 [PATCH] omap: OMAP_IOMMU not visible in menuconfig Sanjeev Premi
@ 2010-09-09 5:04 ` Hiroshi DOYU
2010-09-09 5:10 ` Premi, Sanjeev
2010-09-09 5:58 ` Felipe Balbi
0 siblings, 2 replies; 8+ messages in thread
From: Hiroshi DOYU @ 2010-09-09 5:04 UTC (permalink / raw)
To: premi; +Cc: linux-omap
Hi Sanjeev,
From: ext Sanjeev Premi <premi@ti.com>
Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
Date: Wed, 8 Sep 2010 16:51:21 +0200
> The menu option to select CONFIG_OMAP_IOMMU
> was not visible in the menuconfig due to missing
> description.
There's no point to make OMAP_IOMMU visible since this is a kind of
feature used by other device implicitly. OMAP_IOMMU on menu might confuse
users at kernel menuconfig. Instead this should be automatically
selected by its clients when it is selected. For exmaple, the case
that DSP or Tesla is selected. There was a discussion about this
before.
>
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
> arch/arm/plat-omap/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index e39a417..2a114a9 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
> module parameter).
>
> config OMAP_IOMMU
> - tristate
> + tristate "OMAP IOMMU support"
>
> config OMAP_IOMMU_DEBUG
> tristate "Export OMAP IOMMU internals in DebugFS"
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
2010-09-09 5:04 ` Hiroshi DOYU
@ 2010-09-09 5:10 ` Premi, Sanjeev
2010-09-09 5:24 ` Hiroshi DOYU
2010-09-09 5:58 ` Felipe Balbi
1 sibling, 1 reply; 8+ messages in thread
From: Premi, Sanjeev @ 2010-09-09 5:10 UTC (permalink / raw)
To: Hiroshi DOYU; +Cc: linux-omap
> -----Original Message-----
> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
> Sent: Thursday, September 09, 2010 10:35 AM
> To: Premi, Sanjeev
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
>
> Hi Sanjeev,
>
> From: ext Sanjeev Premi <premi@ti.com>
> Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
> Date: Wed, 8 Sep 2010 16:51:21 +0200
>
> > The menu option to select CONFIG_OMAP_IOMMU
> > was not visible in the menuconfig due to missing
> > description.
>
> There's no point to make OMAP_IOMMU visible since this is a kind of
> feature used by other device implicitly. OMAP_IOMMU on menu
> might confuse
> users at kernel menuconfig. Instead this should be automatically
> selected by its clients when it is selected. For exmaple, the case
> that DSP or Tesla is selected. There was a discussion about this
> before.
[sp] You would have noticed that there are mnay OMAP3 variants and
some of them are ARM only - detection being runtime, not compile
time.
All these processors share same defconfig.
Keeping/ maintaining specific defconfigs for each processor will
be too difficult.
~sanjeev
>
> >
> > Signed-off-by: Sanjeev Premi <premi@ti.com>
> > ---
> > arch/arm/plat-omap/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> > index e39a417..2a114a9 100644
> > --- a/arch/arm/plat-omap/Kconfig
> > +++ b/arch/arm/plat-omap/Kconfig
> > @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
> > module parameter).
> >
> > config OMAP_IOMMU
> > - tristate
> > + tristate "OMAP IOMMU support"
> >
> > config OMAP_IOMMU_DEBUG
> > tristate "Export OMAP IOMMU internals in DebugFS"
> > --
> > 1.6.2.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
2010-09-09 5:10 ` Premi, Sanjeev
@ 2010-09-09 5:24 ` Hiroshi DOYU
2010-09-09 5:30 ` Hiroshi DOYU
0 siblings, 1 reply; 8+ messages in thread
From: Hiroshi DOYU @ 2010-09-09 5:24 UTC (permalink / raw)
To: premi; +Cc: linux-omap
From: "ext Premi, Sanjeev" <premi@ti.com>
Subject: RE: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
Date: Thu, 9 Sep 2010 07:10:05 +0200
>> -----Original Message-----
>> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
>> Sent: Thursday, September 09, 2010 10:35 AM
>> To: Premi, Sanjeev
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
>>
>> Hi Sanjeev,
>>
>> From: ext Sanjeev Premi <premi@ti.com>
>> Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
>> Date: Wed, 8 Sep 2010 16:51:21 +0200
>>
>> > The menu option to select CONFIG_OMAP_IOMMU
>> > was not visible in the menuconfig due to missing
>> > description.
>>
>> There's no point to make OMAP_IOMMU visible since this is a kind of
>> feature used by other device implicitly. OMAP_IOMMU on menu
>> might confuse
>> users at kernel menuconfig. Instead this should be automatically
>> selected by its clients when it is selected. For exmaple, the case
>> that DSP or Tesla is selected. There was a discussion about this
>> before.
>
> [sp] You would have noticed that there are mnay OMAP3 variants and
> some of them are ARM only - detection being runtime, not compile
> time.
>
> All these processors share same defconfig.
Setting dependency correctly could solve this?
Modified drivers/staging/tidspbridge/Kconfig
diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig
index 93de4f2..ff64d46 100644
--- a/drivers/staging/tidspbridge/Kconfig
+++ b/drivers/staging/tidspbridge/Kconfig
@@ -6,6 +6,7 @@ menuconfig TIDSPBRIDGE
tristate "DSP Bridge driver"
depends on ARCH_OMAP3
select OMAP_MBOX_FWK
+ select OMAP_IOMMU
help
DSP/BIOS Bridge is designed for platforms that contain a GPP and
one or more attached DSPs. The GPP is considered the master or
>
> Keeping/ maintaining specific defconfigs for each processor will
> be too difficult.
>
> ~sanjeev
>
>>
>> >
>> > Signed-off-by: Sanjeev Premi <premi@ti.com>
>> > ---
>> > arch/arm/plat-omap/Kconfig | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
>> > index e39a417..2a114a9 100644
>> > --- a/arch/arm/plat-omap/Kconfig
>> > +++ b/arch/arm/plat-omap/Kconfig
>> > @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
>> > module parameter).
>> >
>> > config OMAP_IOMMU
>> > - tristate
>> > + tristate "OMAP IOMMU support"
>> >
>> > config OMAP_IOMMU_DEBUG
>> > tristate "Export OMAP IOMMU internals in DebugFS"
>> > --
>> > 1.6.2.4
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe
>> linux-omap" in
>> > the body of a message to majordomo@vger.kernel.org
>> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
2010-09-09 5:24 ` Hiroshi DOYU
@ 2010-09-09 5:30 ` Hiroshi DOYU
0 siblings, 0 replies; 8+ messages in thread
From: Hiroshi DOYU @ 2010-09-09 5:30 UTC (permalink / raw)
To: premi; +Cc: linux-omap
From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Subject: Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
Date: Thu, 09 Sep 2010 08:24:05 +0300 (EEST)
> From: "ext Premi, Sanjeev" <premi@ti.com>
> Subject: RE: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
> Date: Thu, 9 Sep 2010 07:10:05 +0200
>
>>> -----Original Message-----
>>> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
>>> Sent: Thursday, September 09, 2010 10:35 AM
>>> To: Premi, Sanjeev
>>> Cc: linux-omap@vger.kernel.org
>>> Subject: Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
>>>
>>> Hi Sanjeev,
>>>
>>> From: ext Sanjeev Premi <premi@ti.com>
>>> Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
>>> Date: Wed, 8 Sep 2010 16:51:21 +0200
>>>
>>> > The menu option to select CONFIG_OMAP_IOMMU
>>> > was not visible in the menuconfig due to missing
>>> > description.
>>>
>>> There's no point to make OMAP_IOMMU visible since this is a kind of
>>> feature used by other device implicitly. OMAP_IOMMU on menu
>>> might confuse
>>> users at kernel menuconfig. Instead this should be automatically
>>> selected by its clients when it is selected. For exmaple, the case
>>> that DSP or Tesla is selected. There was a discussion about this
>>> before.
>>
>> [sp] You would have noticed that there are mnay OMAP3 variants and
>> some of them are ARM only - detection being runtime, not compile
>> time.
For the runtime detection, can this be done at platform_device registration time?
>>
>> All these processors share same defconfig.
>
> Setting dependency correctly could solve this?
>
> Modified drivers/staging/tidspbridge/Kconfig
> diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig
> index 93de4f2..ff64d46 100644
> --- a/drivers/staging/tidspbridge/Kconfig
> +++ b/drivers/staging/tidspbridge/Kconfig
> @@ -6,6 +6,7 @@ menuconfig TIDSPBRIDGE
> tristate "DSP Bridge driver"
> depends on ARCH_OMAP3
> select OMAP_MBOX_FWK
> + select OMAP_IOMMU
> help
> DSP/BIOS Bridge is designed for platforms that contain a GPP and
> one or more attached DSPs. The GPP is considered the master or
>
>
>>
>> Keeping/ maintaining specific defconfigs for each processor will
>> be too difficult.
>>
>> ~sanjeev
>>
>>>
>>> >
>>> > Signed-off-by: Sanjeev Premi <premi@ti.com>
>>> > ---
>>> > arch/arm/plat-omap/Kconfig | 2 +-
>>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>>> >
>>> > diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
>>> > index e39a417..2a114a9 100644
>>> > --- a/arch/arm/plat-omap/Kconfig
>>> > +++ b/arch/arm/plat-omap/Kconfig
>>> > @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
>>> > module parameter).
>>> >
>>> > config OMAP_IOMMU
>>> > - tristate
>>> > + tristate "OMAP IOMMU support"
>>> >
>>> > config OMAP_IOMMU_DEBUG
>>> > tristate "Export OMAP IOMMU internals in DebugFS"
>>> > --
>>> > 1.6.2.4
>>> >
>>> > --
>>> > To unsubscribe from this list: send the line "unsubscribe
>>> linux-omap" in
>>> > the body of a message to majordomo@vger.kernel.org
>>> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
2010-09-09 5:04 ` Hiroshi DOYU
2010-09-09 5:10 ` Premi, Sanjeev
@ 2010-09-09 5:58 ` Felipe Balbi
2010-09-09 6:22 ` Hiroshi DOYU
1 sibling, 1 reply; 8+ messages in thread
From: Felipe Balbi @ 2010-09-09 5:58 UTC (permalink / raw)
To: Hiroshi DOYU; +Cc: Premi, Sanjeev, linux-omap
On Thu, Sep 09, 2010 at 12:04:45AM -0500, Hiroshi DOYU wrote:
>Hi Sanjeev,
>
>From: ext Sanjeev Premi <premi@ti.com>
>Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
>Date: Wed, 8 Sep 2010 16:51:21 +0200
>
>> The menu option to select CONFIG_OMAP_IOMMU
>> was not visible in the menuconfig due to missing
>> description.
>
>There's no point to make OMAP_IOMMU visible since this is a kind of
>feature used by other device implicitly. OMAP_IOMMU on menu might confuse
>users at kernel menuconfig. Instead this should be automatically
>selected by its clients when it is selected. For exmaple, the case
>that DSP or Tesla is selected. There was a discussion about this
>before.
in that case...
>> @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
>> module parameter).
>>
>> config OMAP_IOMMU
>> - tristate
>> + tristate "OMAP IOMMU support"
it doesn't have to be tristate as select will always mark it 'y'
--
balbi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
2010-09-09 5:58 ` Felipe Balbi
@ 2010-09-09 6:22 ` Hiroshi DOYU
2010-09-09 10:52 ` Premi, Sanjeev
0 siblings, 1 reply; 8+ messages in thread
From: Hiroshi DOYU @ 2010-09-09 6:22 UTC (permalink / raw)
To: balbi; +Cc: Premi, Sanjeev, linux-omap
On Thu, 9 Sep 2010 07:58:55 +0200
ext Felipe Balbi <balbi@ti.com> wrote:
> On Thu, Sep 09, 2010 at 12:04:45AM -0500, Hiroshi DOYU wrote:
> >Hi Sanjeev,
> >
> >From: ext Sanjeev Premi <premi@ti.com>
> >Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
> >Date: Wed, 8 Sep 2010 16:51:21 +0200
> >
> >> The menu option to select CONFIG_OMAP_IOMMU
> >> was not visible in the menuconfig due to missing
> >> description.
> >
> >There's no point to make OMAP_IOMMU visible since this is a kind of
> >feature used by other device implicitly. OMAP_IOMMU on menu might confuse
> >users at kernel menuconfig. Instead this should be automatically
> >selected by its clients when it is selected. For exmaple, the case
> >that DSP or Tesla is selected. There was a discussion about this
> >before.
>
> in that case...
>
> >> @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
> >> module parameter).
> >>
> >> config OMAP_IOMMU
> >> - tristate
> >> + tristate "OMAP IOMMU support"
>
> it doesn't have to be tristate as select will always mark it 'y'
Right;p
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
2010-09-09 6:22 ` Hiroshi DOYU
@ 2010-09-09 10:52 ` Premi, Sanjeev
0 siblings, 0 replies; 8+ messages in thread
From: Premi, Sanjeev @ 2010-09-09 10:52 UTC (permalink / raw)
To: Hiroshi DOYU, Balbi, Felipe; +Cc: linux-omap
> -----Original Message-----
> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
> Sent: Thursday, September 09, 2010 11:52 AM
> To: Balbi, Felipe
> Cc: Premi, Sanjeev; linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
>
> On Thu, 9 Sep 2010 07:58:55 +0200
> ext Felipe Balbi <balbi@ti.com> wrote:
>
> > On Thu, Sep 09, 2010 at 12:04:45AM -0500, Hiroshi DOYU wrote:
> > >Hi Sanjeev,
> > >
> > >From: ext Sanjeev Premi <premi@ti.com>
> > >Subject: [PATCH] omap: OMAP_IOMMU not visible in menuconfig
> > >Date: Wed, 8 Sep 2010 16:51:21 +0200
> > >
> > >> The menu option to select CONFIG_OMAP_IOMMU
> > >> was not visible in the menuconfig due to missing
> > >> description.
> > >
> > >There's no point to make OMAP_IOMMU visible since this is a kind of
> > >feature used by other device implicitly. OMAP_IOMMU on
> menu might confuse
> > >users at kernel menuconfig. Instead this should be automatically
> > >selected by its clients when it is selected. For exmaple, the case
> > >that DSP or Tesla is selected. There was a discussion about this
> > >before.
> >
> > in that case...
> >
> > >> @@ -98,7 +98,7 @@ config OMAP_MBOX_KFIFO_SIZE
> > >> module parameter).
> > >>
> > >> config OMAP_IOMMU
> > >> - tristate
> > >> + tristate "OMAP IOMMU support"
> >
> > it doesn't have to be tristate as select will always mark it 'y'
>
> Right;p
>
[sp] So, we will need to "select" this option with ARCH_OMAP3.
And maybe for OMAP4...
~sanjeev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-09-09 10:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-08 14:51 [PATCH] omap: OMAP_IOMMU not visible in menuconfig Sanjeev Premi
2010-09-09 5:04 ` Hiroshi DOYU
2010-09-09 5:10 ` Premi, Sanjeev
2010-09-09 5:24 ` Hiroshi DOYU
2010-09-09 5:30 ` Hiroshi DOYU
2010-09-09 5:58 ` Felipe Balbi
2010-09-09 6:22 ` Hiroshi DOYU
2010-09-09 10:52 ` Premi, Sanjeev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.