From: "Premi, Sanjeev" <premi@ti.com>
To: Samuel Ortiz <sameo@linux.intel.com>,
"Koyamangalath, Abhilash" <abhilash.kv@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"Hilman, Kevin" <khilman@ti.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
"david.woodhouse@intel.com" <david.woodhouse@intel.com>
Subject: RE: [PATCH 3/3] OMAP3: Remove auto-selection of PMICs
Date: Mon, 22 Aug 2011 21:29:10 +0530 [thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB5930256DE2CDE@dbde02.ent.ti.com> (raw)
In-Reply-To: <20110822150301.GY4607@sortiz-mobl>
> From: Samuel Ortiz [sameo@linux.intel.com]
> Sent: Monday, August 22, 2011 8:33 PM
> To: Koyamangalath, Abhilash
> Cc: linux-omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> tony@atomide.com; linux@arm.linux.org.uk; Hilman, Kevin; Shilimkar, Santosh; Premi, Sanjeev;
> david.woodhouse@intel.com
> Subject: Re: [PATCH 3/3] OMAP3: Remove auto-selection of PMICs
>
> Hi Anhilash,
>
> On Fri, Aug 19, 2011 at 05:19:33PM +0530, Abhilash K V wrote:
> > The current implementation almost assumes that only
> > TWL4030/TWL5030/TWl6030 are (or can be) used with the
> > OMAP processors. This is, however, not true.
>
> I don't like the mfd/Kconfig change. Why would those drivers be only buildable
> on OMAP processors ?
> Unless there is a real reason for this, you should fix the drivers instead.
You are right. The change for config item TWL4030_CORE should be removed.
> - depends on I2C=y && GENERIC_HARDIRQS
> + depends on I2C=y && GENERIC_HARDIRQS && (ARCH_OMAP3 || ARCH_OMAP4)
In fact, change for TWL4030_POWER should be
- depends on TWL4030_CORE && ARM
+ depends on TWL4030_CORE
This would allow these PMICs to be used with other processors as well. There may
be issues run-time issues; but they would most likely surface only when there is
a combination without any of the OMAPs. (We would try a dummy build for another
processor with TWL4030 selected.)
The original idea was to ensure that nothing else breaks when the auto selection
of the PMICs is removed.
~sanjeev
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: premi@ti.com (Premi, Sanjeev)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] OMAP3: Remove auto-selection of PMICs
Date: Mon, 22 Aug 2011 21:29:10 +0530 [thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB5930256DE2CDE@dbde02.ent.ti.com> (raw)
In-Reply-To: <20110822150301.GY4607@sortiz-mobl>
> From: Samuel Ortiz [sameo at linux.intel.com]
> Sent: Monday, August 22, 2011 8:33 PM
> To: Koyamangalath, Abhilash
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
> tony at atomide.com; linux at arm.linux.org.uk; Hilman, Kevin; Shilimkar, Santosh; Premi, Sanjeev;
> david.woodhouse at intel.com
> Subject: Re: [PATCH 3/3] OMAP3: Remove auto-selection of PMICs
>
> Hi Anhilash,
>
> On Fri, Aug 19, 2011 at 05:19:33PM +0530, Abhilash K V wrote:
> > The current implementation almost assumes that only
> > TWL4030/TWL5030/TWl6030 are (or can be) used with the
> > OMAP processors. This is, however, not true.
>
> I don't like the mfd/Kconfig change. Why would those drivers be only buildable
> on OMAP processors ?
> Unless there is a real reason for this, you should fix the drivers instead.
You are right. The change for config item TWL4030_CORE should be removed.
> - depends on I2C=y && GENERIC_HARDIRQS
> + depends on I2C=y && GENERIC_HARDIRQS && (ARCH_OMAP3 || ARCH_OMAP4)
In fact, change for TWL4030_POWER should be
- depends on TWL4030_CORE && ARM
+ depends on TWL4030_CORE
This would allow these PMICs to be used with other processors as well. There may
be issues run-time issues; but they would most likely surface only when there is
a combination without any of the OMAPs. (We would try a dummy build for another
processor with TWL4030 selected.)
The original idea was to ensure that nothing else breaks when the auto selection
of the PMICs is removed.
~sanjeev
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
next prev parent reply other threads:[~2011-08-22 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 11:49 [PATCH 0/3] AM35x: Adding PM init Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-19 11:49 ` [PATCH 1/3] AM35x: voltage: Basic initialization Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-19 11:49 ` [PATCH 2/3] OMAP3: Add support for TPS65023 (AM35x only) Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-19 11:49 ` [PATCH 3/3] OMAP3: Remove auto-selection of PMICs Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-19 11:49 ` Abhilash K V
2011-08-22 15:03 ` Samuel Ortiz
2011-08-22 15:03 ` Samuel Ortiz
2011-08-22 15:59 ` Premi, Sanjeev [this message]
2011-08-22 15:59 ` Premi, Sanjeev
2011-08-22 15:59 ` Premi, Sanjeev
2011-08-30 22:26 ` [PATCH 1/3] AM35x: voltage: Basic initialization Kevin Hilman
2011-08-30 22:26 ` Kevin Hilman
2011-08-30 22:26 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B85A65D85D7EB246BE421B3FB0FBB5930256DE2CDE@dbde02.ent.ti.com \
--to=premi@ti.com \
--cc=abhilash.kv@ti.com \
--cc=david.woodhouse@intel.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sameo@linux.intel.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.