All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nori, Sekhar" <nsekhar@ti.com>
To: Axel Lin <axel.lin@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"Hilman, Kevin" <khilman@ti.com>,
	Russell King <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"davinci-linux-open-source@linux.davincidsp.com" 
	<davinci-linux-open-source@linux.davincidsp.com>
Subject: RE: [PATCH] [ARM] davinci: gpio: eliminate unused variable warnings
Date: Thu, 1 Sep 2011 20:02:51 +0530	[thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB5930257268CEC@dbde02.ent.ti.com> (raw)
In-Reply-To: <1313386893.25484.1.camel@phoenix>

Hi Axel,

On Mon, Aug 15, 2011 at 11:11:33, Axel Lin wrote:
> Since commit 5093aec872e5be7a55d8dd2b639e8a3818dc19db
> "arm: davinci: Cleanup irq chip code", 
> the variable 'mask' and 'g' are not being used in gpio_irq_type.
> 
> This patch eliminate below unused variable warnings:
> 
>   CC      arch/arm/mach-davinci/gpio.o
> arch/arm/mach-davinci/gpio.c: In function 'gpio_irq_type':
> arch/arm/mach-davinci/gpio.c:234: warning: unused variable 'mask'
> arch/arm/mach-davinci/gpio.c:233: warning: unused variable 'g'
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Thanks for the fix! There is a patch in linux-next
committed by Russell which moves the DaVinci gpio driver
to drivers/gpio/. 

Can you please redo this fix to apply on linux-next?

Once Russell approves, it can go though his patch
system so there are no conflicts.

Thanks,
Sekhar


WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Nori, Sekhar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] davinci: gpio: eliminate unused variable warnings
Date: Thu, 1 Sep 2011 20:02:51 +0530	[thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB5930257268CEC@dbde02.ent.ti.com> (raw)
In-Reply-To: <1313386893.25484.1.camel@phoenix>

Hi Axel,

On Mon, Aug 15, 2011 at 11:11:33, Axel Lin wrote:
> Since commit 5093aec872e5be7a55d8dd2b639e8a3818dc19db
> "arm: davinci: Cleanup irq chip code", 
> the variable 'mask' and 'g' are not being used in gpio_irq_type.
> 
> This patch eliminate below unused variable warnings:
> 
>   CC      arch/arm/mach-davinci/gpio.o
> arch/arm/mach-davinci/gpio.c: In function 'gpio_irq_type':
> arch/arm/mach-davinci/gpio.c:234: warning: unused variable 'mask'
> arch/arm/mach-davinci/gpio.c:233: warning: unused variable 'g'
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Thanks for the fix! There is a patch in linux-next
committed by Russell which moves the DaVinci gpio driver
to drivers/gpio/. 

Can you please redo this fix to apply on linux-next?

Once Russell approves, it can go though his patch
system so there are no conflicts.

Thanks,
Sekhar

  reply	other threads:[~2011-09-01 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15  5:41 [PATCH] [ARM] davinci: gpio: eliminate unused variable warnings Axel Lin
2011-08-15  5:41 ` Axel Lin
2011-09-01 14:32 ` Nori, Sekhar [this message]
2011-09-01 14:32   ` Nori, Sekhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B85A65D85D7EB246BE421B3FB0FBB5930257268CEC@dbde02.ent.ti.com \
    --to=nsekhar@ti.com \
    --cc=axel.lin@gmail.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.