All of lore.kernel.org
 help / color / mirror / Atom feed
From: nikolay@cumulusnetworks.com
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	davem@davemloft.net, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 1/4] net: bridge: check port state before br_allowed_egress
Date: Thu, 23 Jan 2020 19:58:35 +0200	[thread overview]
Message-ID: <B878D56B-BA6C-49A9-877D-5590BC4DC314@cumulusnetworks.com> (raw)
In-Reply-To: <20200123082542.06ed0a53@hermes.lan>

On 23 January 2020 18:25:42 EET, Stephen Hemminger <stephen@networkplumber.org> wrote:
>On Thu, 23 Jan 2020 15:28:04 +0200
>Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
>
>>  	return ((p->flags & BR_HAIRPIN_MODE) || skb->dev != p->dev) &&
>> -		br_allowed_egress(vg, skb) && p->state == BR_STATE_FORWARDING &&
>> +		p->state == BR_STATE_FORWARDING && br_allowed_egress(vg, skb) &&
>>  		nbp_switchdev_allowed_egress(p, skb) &&
>>  		!br_skb_isolated(p, skb);
>>  }
>
>Maybe break this complex return for readability?

Sure, sounds good, but is not the point of this commit. 
I'll prepare a separate cleanup patch for that. 

Thanks, 
  Nik


WARNING: multiple messages have this Message-ID (diff)
From: nikolay@cumulusnetworks.com
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
	bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 1/4] net: bridge: check port state before br_allowed_egress
Date: Thu, 23 Jan 2020 19:58:35 +0200	[thread overview]
Message-ID: <B878D56B-BA6C-49A9-877D-5590BC4DC314@cumulusnetworks.com> (raw)
In-Reply-To: <20200123082542.06ed0a53@hermes.lan>

On 23 January 2020 18:25:42 EET, Stephen Hemminger <stephen@networkplumber.org> wrote:
>On Thu, 23 Jan 2020 15:28:04 +0200
>Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
>
>>  	return ((p->flags & BR_HAIRPIN_MODE) || skb->dev != p->dev) &&
>> -		br_allowed_egress(vg, skb) && p->state == BR_STATE_FORWARDING &&
>> +		p->state == BR_STATE_FORWARDING && br_allowed_egress(vg, skb) &&
>>  		nbp_switchdev_allowed_egress(p, skb) &&
>>  		!br_skb_isolated(p, skb);
>>  }
>
>Maybe break this complex return for readability?

Sure, sounds good, but is not the point of this commit. 
I'll prepare a separate cleanup patch for that. 

Thanks, 
  Nik


  reply	other threads:[~2020-01-23 17:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 13:28 [PATCH net-next 0/4] net: bridge: add per-vlan state option Nikolay Aleksandrov
2020-01-23 13:28 ` [Bridge] " Nikolay Aleksandrov
2020-01-23 13:28 ` [PATCH net-next 1/4] net: bridge: check port state before br_allowed_egress Nikolay Aleksandrov
2020-01-23 13:28   ` [Bridge] " Nikolay Aleksandrov
2020-01-23 16:25   ` Stephen Hemminger
2020-01-23 16:25     ` [Bridge] " Stephen Hemminger
2020-01-23 17:58     ` nikolay [this message]
2020-01-23 17:58       ` nikolay
2020-01-23 13:28 ` [PATCH net-next 2/4] net: bridge: vlan: add basic option dumping support Nikolay Aleksandrov
2020-01-23 13:28   ` [Bridge] " Nikolay Aleksandrov
2020-01-23 13:28 ` [PATCH net-next 3/4] net: bridge: vlan: add basic option setting support Nikolay Aleksandrov
2020-01-23 13:28   ` [Bridge] " Nikolay Aleksandrov
2020-01-23 13:28 ` [PATCH net-next 4/4] net: bridge: vlan: add per-vlan state Nikolay Aleksandrov
2020-01-23 13:28   ` [Bridge] " Nikolay Aleksandrov
2020-01-23 21:10 ` [PATCH net-next 0/4] net: bridge: add per-vlan state option Nikolay Aleksandrov
2020-01-23 21:10   ` [Bridge] " Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B878D56B-BA6C-49A9-877D-5590BC4DC314@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.