All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Dinh <dinh.nguyen@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] net: designware: Add reset ctrl to driver
Date: Fri, 4 May 2018 14:30:12 +0000	[thread overview]
Message-ID: <BA1B5AF7D118E146A437E44412B8291307BEC6EE@fmsmsx122.amr.corp.intel.com> (raw)
In-Reply-To: <1525430961-45527-4-git-send-email-ley.foon.tan@intel.com>



> -----Original Message-----
> From: Tan, Ley Foon
> Sent: Friday, May 4, 2018 5:49 AM
> To: u-boot at lists.denx.de
> Cc: Marek Vasut <marex@denx.de>; Ley Foon Tan <lftan.linux@gmail.com>;
> See, Chin Liang <chin.liang.see@intel.com>; Nguyen, Dinh
> <dinh.nguyen@intel.com>; Tan, Ley Foon <ley.foon.tan@intel.com>
> Subject: [PATCH v2 3/3] net: designware: Add reset ctrl to driver
> 
> Add code to reset all reset signals as in Ethernet DT node. A reset property is an
> optional feature, so only print out a warning and do not fail if a reset property is
> not present.
> 
> If a reset property is discovered, then use it to deassert, thus bringing the IP out
> of reset.
> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
>  drivers/net/designware.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/designware.c b/drivers/net/designware.c index
> 765e356..03ef1eb 100644
> --- a/drivers/net/designware.c
> +++ b/drivers/net/designware.c
> @@ -16,6 +16,7 @@
>  #include <miiphy.h>
>  #include <malloc.h>
>  #include <pci.h>
> +#include <reset.h>
>  #include <linux/compiler.h>
>  #include <linux/err.h>
>  #include <linux/kernel.h>
> @@ -711,6 +712,16 @@ int designware_eth_probe(struct udevice *dev)
>  	}
>  #endif
> 
> +#ifdef CONFIG_DM_RESET

You don't need the above wrapper. It's already checked in reset.h

> +	struct reset_ctl_bulk reset_bulk;
> +
> +	ret = reset_get_bulk(dev, &reset_bulk);
> +	if (ret)
> +		dev_warn(dev, "Can't get reset: %d\n", ret);
> +	else
> +		reset_deassert_bulk(&reset_bulk);
> +#endif
> +
>  #ifdef CONFIG_DM_PCI
>  	/*
>  	 * If we are on PCI bus, either directly attached to a PCI root port,
> --
> 1.7.1

  reply	other threads:[~2018-05-04 14:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-04 10:49 [U-Boot] [PATCH v2 0/3] drivers: Add reset ctrl to drivers Ley Foon Tan
2018-05-04 10:49 ` [U-Boot] [PATCH v2 1/3] mmc: dwmmc: socfpga: Add reset ctrl to driver Ley Foon Tan
2018-05-04 10:49 ` [U-Boot] [PATCH v2 2/3] serial: ns16550: " Ley Foon Tan
2018-05-04 14:30   ` Nguyen, Dinh
2018-05-07  2:09     ` Ley Foon Tan
2018-05-04 10:49 ` [U-Boot] [PATCH v2 3/3] net: designware: " Ley Foon Tan
2018-05-04 14:30   ` Nguyen, Dinh [this message]
2018-05-07 21:18 ` [U-Boot] [PATCH v2 0/3] drivers: Add reset ctrl to drivers Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BA1B5AF7D118E146A437E44412B8291307BEC6EE@fmsmsx122.amr.corp.intel.com \
    --to=dinh.nguyen@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.