* [PATCH] sysctl: net: call unregister_net_sysctl_table where needed
@ 2011-05-01 11:44 Lucian Adrian Grijincu
2011-05-01 11:48 ` Lucian Adrian Grijincu
0 siblings, 1 reply; 3+ messages in thread
From: Lucian Adrian Grijincu @ 2011-05-01 11:44 UTC (permalink / raw)
To: netdev, davem; +Cc: Lucian Adrian Grijincu
ctl_table_headers registered with register_net_sysctl_table should
have been unregistered with the equivalent unregister_net_sysctl_table
Signed-off-by: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
---
net/ipv4/devinet.c | 2 +-
net/ipv6/addrconf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index 5345b0b..cd9ca08 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1680,7 +1680,7 @@ static void __devinet_sysctl_unregister(struct ipv4_devconf *cnf)
return;
cnf->sysctl = NULL;
- unregister_sysctl_table(t->sysctl_header);
+ unregister_net_sysctl_table(t->sysctl_header);
kfree(t->dev_name);
kfree(t);
}
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 1493534..a7bda07 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -4537,7 +4537,7 @@ static void __addrconf_sysctl_unregister(struct ipv6_devconf *p)
t = p->sysctl;
p->sysctl = NULL;
- unregister_sysctl_table(t->sysctl_header);
+ unregister_net_sysctl_table(t->sysctl_header);
kfree(t->dev_name);
kfree(t);
}
--
1.7.5.134.g1c08b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sysctl: net: call unregister_net_sysctl_table where needed
2011-05-01 11:44 [PATCH] sysctl: net: call unregister_net_sysctl_table where needed Lucian Adrian Grijincu
@ 2011-05-01 11:48 ` Lucian Adrian Grijincu
2011-05-02 23:12 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Lucian Adrian Grijincu @ 2011-05-01 11:48 UTC (permalink / raw)
To: netdev, davem; +Cc: Lucian Adrian Grijincu
On Sun, May 1, 2011 at 1:44 PM, Lucian Adrian Grijincu
<lucian.grijincu@gmail.com> wrote:
> ctl_table_headers registered with register_net_sysctl_table should
> have been unregistered with the equivalent unregister_net_sysctl_table
>
> Signed-off-by: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
David: I sent you this patch a while back but it was mixed with other
unrelated patches that were mostly ignored.
Again, to clarify: it does not matter at the moment if
register_net_sysctl_table or unregister_sysctl_table is called because
both to the same thing:
void unregister_net_sysctl_table(struct ctl_table_header *header)
{
unregister_sysctl_table(header);
}
EXPORT_SYMBOL_GPL(unregister_net_sysctl_table);
We should either get rid of unregister_net_sysctl_table or use it consistently.
--
.
..: Lucian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sysctl: net: call unregister_net_sysctl_table where needed
2011-05-01 11:48 ` Lucian Adrian Grijincu
@ 2011-05-02 23:12 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-05-02 23:12 UTC (permalink / raw)
To: lucian.grijincu; +Cc: netdev
From: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
Date: Sun, 1 May 2011 13:48:04 +0200
> On Sun, May 1, 2011 at 1:44 PM, Lucian Adrian Grijincu
> <lucian.grijincu@gmail.com> wrote:
>> ctl_table_headers registered with register_net_sysctl_table should
>> have been unregistered with the equivalent unregister_net_sysctl_table
>>
>> Signed-off-by: Lucian Adrian Grijincu <lucian.grijincu@gmail.com>
>
>
> David: I sent you this patch a while back but it was mixed with other
> unrelated patches that were mostly ignored.
>
> Again, to clarify: it does not matter at the moment if
> register_net_sysctl_table or unregister_sysctl_table is called because
> both to the same thing:
...
> We should either get rid of unregister_net_sysctl_table or use it consistently.
Applied to net-2.6, thanks Lucian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-02 23:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-01 11:44 [PATCH] sysctl: net: call unregister_net_sysctl_table where needed Lucian Adrian Grijincu
2011-05-01 11:48 ` Lucian Adrian Grijincu
2011-05-02 23:12 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.