From: Per Forlin <per.forlin@linaro.org> To: Nickolay Nickolaev <nicknickolaev@gmail.com> Cc: linaro-dev@lists.linaro.org, Nicolas Pitre <nicolas.pitre@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Venkatraman S <svenkatr@ti.com> Subject: Re: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req Date: Wed, 22 Jun 2011 11:31:16 +0200 [thread overview] Message-ID: <BANLkTi=GT=1u0YEtUaJre24BOhRyDNGUSg@mail.gmail.com> (raw) In-Reply-To: <BANLkTikqeKg=Mr9BxVYL7x=9k_jzGeLnQQ@mail.gmail.com> On 22 June 2011 10:51, Nickolay Nickolaev <nicknickolaev@gmail.com> wrote: > Hello, > > this one's causing me compilation trouble troubles when CONFIG_DMA_ENGINE is > not defined. > I don't see this issue when I compile the kernel for a Pandaboard without CONFIG_DMA_ENGINE being set. Could you please clarify or show me your build log? I don't see how host->next_data.cookie is connected to DMA_ENGINE. > On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin <per.forlin@linaro.org> wrote: >> >> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct >> platform_device *pdev) >> host->mapbase = res->start; >> host->base = ioremap(host->mapbase, SZ_4K); >> host->power_mode = MMC_POWER_OFF; >> + host->next_data.cookie = 1; >> >> platform_set_drvdata(pdev, host); >> INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); >> -- >> 1.7.4.1 >> >> > > Maybe we can wrap it in a function as the others. > > regards, > Nikolay Nikolaev > Regards, Per
WARNING: multiple messages have this Message-ID (diff)
From: per.forlin@linaro.org (Per Forlin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req Date: Wed, 22 Jun 2011 11:31:16 +0200 [thread overview] Message-ID: <BANLkTi=GT=1u0YEtUaJre24BOhRyDNGUSg@mail.gmail.com> (raw) In-Reply-To: <BANLkTikqeKg=Mr9BxVYL7x=9k_jzGeLnQQ@mail.gmail.com> On 22 June 2011 10:51, Nickolay Nickolaev <nicknickolaev@gmail.com> wrote: > Hello, > > this one's causing me compilation trouble troubles when CONFIG_DMA_ENGINE is > not defined. > I don't see this issue when I compile the kernel for a Pandaboard without CONFIG_DMA_ENGINE being set. Could you please clarify or show me your build log? I don't see how host->next_data.cookie is connected to DMA_ENGINE. > On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin <per.forlin@linaro.org> wrote: >> >> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct >> platform_device *pdev) >> ? ? ? ?host->mapbase ? = res->start; >> ? ? ? ?host->base ? ? ?= ioremap(host->mapbase, SZ_4K); >> ? ? ? ?host->power_mode = MMC_POWER_OFF; >> + ? ? ? host->next_data.cookie = 1; >> >> ? ? ? ?platform_set_drvdata(pdev, host); >> ? ? ? ?INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); >> -- >> 1.7.4.1 >> >> > > Maybe we can wrap it in a function as the others. > > regards, > Nikolay Nikolaev > Regards, Per
next prev parent reply other threads:[~2011-06-22 9:31 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-21 23:38 [PATCH v7 00/11] use nonblock mmc requests to minimize latency Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 01/11] mmc: add non-blocking mmc request function Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-22 7:42 ` Venkatraman S 2011-06-22 7:42 ` Venkatraman S 2011-06-22 8:45 ` Per Forlin 2011-06-22 8:45 ` Per Forlin 2011-06-22 8:53 ` S, Venkatraman 2011-06-22 8:53 ` S, Venkatraman 2011-06-22 9:08 ` Per Forlin 2011-06-22 9:08 ` Per Forlin 2011-06-22 11:05 ` S, Venkatraman 2011-06-22 11:05 ` S, Venkatraman 2011-06-21 23:38 ` [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin [not found] ` <1308699521-20556-3-git-send-email-per.forlin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2011-06-22 8:51 ` Nickolay Nickolaev 2011-06-22 9:31 ` Per Forlin [this message] 2011-06-22 9:31 ` Per Forlin 2011-06-22 9:38 ` Per Forlin 2011-06-22 9:38 ` Per Forlin 2011-06-22 9:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 03/11] mmci: implement pre_req() and post_req() Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-22 10:01 ` Per Forlin 2011-06-22 10:01 ` Per Forlin 2011-06-22 10:01 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 04/11] mmc: mmc_test: add debugfs file to list all tests Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 05/11] mmc: mmc_test: add test for non-blocking transfers Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 06/11] mmc: add member in mmc queue struct to hold request data Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 07/11] mmc: add a block request prepare function Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 08/11] mmc: move error code in mmc_block_issue_rw_rq to a separate function Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 09/11] mmc: add a second mmc queue request member Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 10/11] mmc: test: add random fault injection in core.c Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` [PATCH v7 11/11] mmc: add handling for two parallel block requests in issue_rw_rq Per Forlin 2011-06-21 23:38 ` Per Forlin 2011-06-21 23:38 ` Per Forlin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='BANLkTi=GT=1u0YEtUaJre24BOhRyDNGUSg@mail.gmail.com' \ --to=per.forlin@linaro.org \ --cc=linaro-dev@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=nicknickolaev@gmail.com \ --cc=nicolas.pitre@linaro.org \ --cc=svenkatr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.