All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] sh-18n: quell "unused variable" warning
Date: Thu, 26 May 2011 01:33:26 +0200	[thread overview]
Message-ID: <BANLkTi=Mgd7=eriOsz1phDBJ25Com2Y=mQ@mail.gmail.com> (raw)
In-Reply-To: <62c2e1619edcb37c0411f29a34b6bc10e3899a97.1306317312.git.git@drmicha.warpmail.net>

On Wed, May 25, 2011 at 11:55, Michael J Gruber
<git@drmicha.warpmail.net> wrote:

I suppose it was inevitable that we'd end up maintaining this since
upstream only maintains the GPLv3 version now.

>   /* Default values for command line options.  */
> -  unsigned short int show_variables = 0;
> +  /* unsigned short int show_variables = 0; */

> -         show_variables = 1;
> +         /* show_variables = 1; */

Can we just remove these lines instead of commenting them out?

  parent reply	other threads:[~2011-05-25 23:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25  9:55 [PATCH] sh-18n: quell "unused variable" warning Michael J Gruber
2011-05-25 16:35 ` Junio C Hamano
2011-05-25 23:33 ` Ævar Arnfjörð Bjarmason [this message]
2011-05-26 13:03   ` Michael J Gruber
2011-05-26 13:46     ` Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=Mgd7=eriOsz1phDBJ25Com2Y=mQ@mail.gmail.com' \
    --to=avarab@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.