* [PATCH] sh-18n: quell "unused variable" warning
@ 2011-05-25 9:55 Michael J Gruber
2011-05-25 16:35 ` Junio C Hamano
2011-05-25 23:33 ` Ævar Arnfjörð Bjarmason
0 siblings, 2 replies; 5+ messages in thread
From: Michael J Gruber @ 2011-05-25 9:55 UTC (permalink / raw)
To: git; +Cc: Ævar Arnfjörð Bjarmason, Junio C Hamano
CC sh-i18n--envsubst.o
sh-i18n--envsubst.c: In Funktion »main«:
sh-i18n--envsubst.c:71:22: Warnung: Variable »show_variables« gesetzt,
aber nicht verwendet [-Wunused-but-set-variable]
show_variables is indeed unused. Comment it out rather than remove it so
that the relation with upstream remains clear.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
Why is it that even with LANG=C exported, gcc gives localized warnings?
And yes, I'm on gcc 4.6 now (F15)...
---
sh-i18n--envsubst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sh-i18n--envsubst.c b/sh-i18n--envsubst.c
index 7125093..2eb0ee4 100644
--- a/sh-i18n--envsubst.c
+++ b/sh-i18n--envsubst.c
@@ -68,7 +68,7 @@ int
main (int argc, char *argv[])
{
/* Default values for command line options. */
- unsigned short int show_variables = 0;
+ /* unsigned short int show_variables = 0; */
switch (argc)
{
@@ -88,7 +88,7 @@ main (int argc, char *argv[])
/* git sh-i18n--envsubst --variables '$foo and $bar' */
if (strcmp(argv[1], "--variables"))
error ("first argument must be --variables when two are given");
- show_variables = 1;
+ /* show_variables = 1; */
print_variables (argv[2]);
break;
default:
--
1.7.5.2.639.gce8e1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] sh-18n: quell "unused variable" warning
2011-05-25 9:55 [PATCH] sh-18n: quell "unused variable" warning Michael J Gruber
@ 2011-05-25 16:35 ` Junio C Hamano
2011-05-25 23:33 ` Ævar Arnfjörð Bjarmason
1 sibling, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2011-05-25 16:35 UTC (permalink / raw)
To: Michael J Gruber; +Cc: git, Ævar Arnfjörð Bjarmason
Michael J Gruber <git@drmicha.warpmail.net> writes:
> CC sh-i18n--envsubst.o
> sh-i18n--envsubst.c: In Funktion »main«:
> sh-i18n--envsubst.c:71:22: Warnung: Variable »show_variables« gesetzt,
> aber nicht verwendet [-Wunused-but-set-variable]
>
> show_variables is indeed unused. Comment it out rather than remove it so
> that the relation with upstream remains clear.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> Why is it that even with LANG=C exported, gcc gives localized warnings?
Because you probably do not have LC_ALL=C?
In any case, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sh-18n: quell "unused variable" warning
2011-05-25 9:55 [PATCH] sh-18n: quell "unused variable" warning Michael J Gruber
2011-05-25 16:35 ` Junio C Hamano
@ 2011-05-25 23:33 ` Ævar Arnfjörð Bjarmason
2011-05-26 13:03 ` Michael J Gruber
1 sibling, 1 reply; 5+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2011-05-25 23:33 UTC (permalink / raw)
To: Michael J Gruber; +Cc: git, Junio C Hamano
On Wed, May 25, 2011 at 11:55, Michael J Gruber
<git@drmicha.warpmail.net> wrote:
I suppose it was inevitable that we'd end up maintaining this since
upstream only maintains the GPLv3 version now.
> /* Default values for command line options. */
> - unsigned short int show_variables = 0;
> + /* unsigned short int show_variables = 0; */
> - show_variables = 1;
> + /* show_variables = 1; */
Can we just remove these lines instead of commenting them out?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sh-18n: quell "unused variable" warning
2011-05-25 23:33 ` Ævar Arnfjörð Bjarmason
@ 2011-05-26 13:03 ` Michael J Gruber
2011-05-26 13:46 ` Ævar Arnfjörð Bjarmason
0 siblings, 1 reply; 5+ messages in thread
From: Michael J Gruber @ 2011-05-26 13:03 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: git, Junio C Hamano
Ævar Arnfjörð Bjarmason venit, vidit, dixit 26.05.2011 01:33:
> On Wed, May 25, 2011 at 11:55, Michael J Gruber
> <git@drmicha.warpmail.net> wrote:
>
> I suppose it was inevitable that we'd end up maintaining this since
> upstream only maintains the GPLv3 version now.
>
>> /* Default values for command line options. */
>> - unsigned short int show_variables = 0;
>> + /* unsigned short int show_variables = 0; */
>
>> - show_variables = 1;
>> + /* show_variables = 1; */
>
> Can we just remove these lines instead of commenting them out?
Sure, I just didn't know what is more convenient for the maintainer. I
noticed a few comments in there already but have not compared with
upstream. Resend necessary?
Michael
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sh-18n: quell "unused variable" warning
2011-05-26 13:03 ` Michael J Gruber
@ 2011-05-26 13:46 ` Ævar Arnfjörð Bjarmason
0 siblings, 0 replies; 5+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2011-05-26 13:46 UTC (permalink / raw)
To: Michael J Gruber; +Cc: git, Junio C Hamano
On Thu, May 26, 2011 at 15:03, Michael J Gruber
<git@drmicha.warpmail.net> wrote:
> Ævar Arnfjörð Bjarmason venit, vidit, dixit 26.05.2011 01:33:
>> On Wed, May 25, 2011 at 11:55, Michael J Gruber
>> <git@drmicha.warpmail.net> wrote:
>>
>> I suppose it was inevitable that we'd end up maintaining this since
>> upstream only maintains the GPLv3 version now.
>>
>>> /* Default values for command line options. */
>>> - unsigned short int show_variables = 0;
>>> + /* unsigned short int show_variables = 0; */
>>
>>> - show_variables = 1;
>>> + /* show_variables = 1; */
>>
>> Can we just remove these lines instead of commenting them out?
>
> Sure, I just didn't know what is more convenient for the maintainer. I
> noticed a few comments in there already but have not compared with
> upstream. Resend necessary?
No it's fine.
But I/we are the upstream for this program now, since GNU only
maintains the GPLv3 version.
We could just use that actually, since this is a stand-alone
program. Or do we have intrinsic objections to GPLv3 code in our
source tree?
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-26 13:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-25 9:55 [PATCH] sh-18n: quell "unused variable" warning Michael J Gruber
2011-05-25 16:35 ` Junio C Hamano
2011-05-25 23:33 ` Ævar Arnfjörð Bjarmason
2011-05-26 13:03 ` Michael J Gruber
2011-05-26 13:46 ` Ævar Arnfjörð Bjarmason
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.