[PATCH obexd] Return correct obex service driver in obex_session_start

[PATCH obexd] Return correct obex service driver in obex_session_start

[Hui Li]

From: Hui Li <nami@qca.qualcomm.com>

 The original return value is NULL.
---
 src/obex.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/obex.c b/src/obex.c
index 49d9c18..978894e 100644
--- a/src/obex.c
+++ b/src/obex.c
@@ -1377,8 +1377,7 @@ int obex_session_start(GIOChannel *io, uint16_t tx_mtu, uint16_t rx_mtu,

 	os = g_new0(struct obex_session, 1);

-	os->service = obex_service_driver_find(server->drivers, NULL,
-							0, NULL, 0);
+	os->service = server->drivers->data;
 	os->server = server;
 	os->rx_mtu = rx_mtu != 0 ? rx_mtu : DEFAULT_RX_MTU;
 	os->tx_mtu = tx_mtu != 0 ? tx_mtu : DEFAULT_TX_MTU;
--
1.7.1

Re: [PATCH obexd] Return correct obex service driver in obex_session_start

[Luiz Augusto von Dentz]

Hi,

On Thu, Jun 30, 2011 at 10:34 AM, Hui Li <nami.li@atheros.com> wrote:
> From: Hui Li <nami@qca.qualcomm.com>
>
>  The original return value is NULL.
> ---
>  src/obex.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/obex.c b/src/obex.c
> index 49d9c18..978894e 100644
> --- a/src/obex.c
> +++ b/src/obex.c
> @@ -1377,8 +1377,7 @@ int obex_session_start(GIOChannel *io, uint16_t tx_mtu, uint16_t rx_mtu,
>
>        os = g_new0(struct obex_session, 1);
>
> -       os->service = obex_service_driver_find(server->drivers, NULL,
> -                                                       0, NULL, 0);
> +       os->service = server->drivers->data;
>        os->server = server;
>        os->rx_mtu = rx_mtu != 0 ? rx_mtu : DEFAULT_RX_MTU;
>        os->tx_mtu = tx_mtu != 0 ? tx_mtu : DEFAULT_TX_MTU;
> --
> 1.7.1
>
> --

The idea here is to initialized with OPP driver which has no target
thus the NULL, so picking up the first driver in the list may not
enough. Btw, if passing a NULL was a bug OPP driver would never have
worked, so I wonder how you managed to get no driver as a response to
NULL target?



-- 
Luiz Augusto von Dentz

RE: [PATCH obexd] Return correct obex service driver in obex_session_start

[Li, Nami]

SGksIEx1aXoNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEx1aXogQXVndXN0
byB2b24gRGVudHogW21haWx0bzpsdWl6LmRlbnR6QGdtYWlsLmNvbV0gDQpTZW50OiAyMDEx5bm0
NuaciDMw5pelIDE2OjI1DQpUbzogTGksIE5hbWkNCkNjOiBsaW51eC1ibHVldG9vdGhAdmdlci5r
ZXJuZWwub3JnOyBMaSwgTmFtaQ0KU3ViamVjdDogUmU6IFtQQVRDSCBvYmV4ZF0gUmV0dXJuIGNv
cnJlY3Qgb2JleCBzZXJ2aWNlIGRyaXZlciBpbiBvYmV4X3Nlc3Npb25fc3RhcnQNCg0KSGksDQoN
Ck9uIFRodSwgSnVuIDMwLCAyMDExIGF0IDEwOjM0IEFNLCBIdWkgTGkgPG5hbWkubGlAYXRoZXJv
cy5jb20+IHdyb3RlOg0KPiBGcm9tOiBIdWkgTGkgPG5hbWlAcWNhLnF1YWxjb21tLmNvbT4NCj4N
Cj4gwqBUaGUgb3JpZ2luYWwgcmV0dXJuIHZhbHVlIGlzIE5VTEwuDQo+IC0tLQ0KPiDCoHNyYy9v
YmV4LmMgfCDCoCDCoDMgKy0tDQo+IMKgMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyks
IDIgZGVsZXRpb25zKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9zcmMvb2JleC5jIGIvc3JjL29iZXgu
Yw0KPiBpbmRleCA0OWQ5YzE4Li45Nzg4OTRlIDEwMDY0NA0KPiAtLS0gYS9zcmMvb2JleC5jDQo+
ICsrKyBiL3NyYy9vYmV4LmMNCj4gQEAgLTEzNzcsOCArMTM3Nyw3IEBAIGludCBvYmV4X3Nlc3Np
b25fc3RhcnQoR0lPQ2hhbm5lbCAqaW8sIHVpbnQxNl90IA0KPiB0eF9tdHUsIHVpbnQxNl90IHJ4
X210dSwNCj4NCj4gwqAgwqAgwqAgwqBvcyA9IGdfbmV3MChzdHJ1Y3Qgb2JleF9zZXNzaW9uLCAx
KTsNCj4NCj4gLSDCoCDCoCDCoCBvcy0+c2VydmljZSA9IG9iZXhfc2VydmljZV9kcml2ZXJfZmlu
ZChzZXJ2ZXItPmRyaXZlcnMsIE5VTEwsDQo+IC0gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgMCwg
TlVMTCwgMCk7DQo+ICsgwqAgwqAgwqAgb3MtPnNlcnZpY2UgPSBzZXJ2ZXItPmRyaXZlcnMtPmRh
dGE7DQo+IMKgIMKgIMKgIMKgb3MtPnNlcnZlciA9IHNlcnZlcjsNCj4gwqAgwqAgwqAgwqBvcy0+
cnhfbXR1ID0gcnhfbXR1ICE9IDAgPyByeF9tdHUgOiBERUZBVUxUX1JYX01UVTsNCj4gwqAgwqAg
wqAgwqBvcy0+dHhfbXR1ID0gdHhfbXR1ICE9IDAgPyB0eF9tdHUgOiBERUZBVUxUX1RYX01UVTsN
Cj4gLS0NCj4gMS43LjENCj4NCj4gLS0NCg0KVGhlIGlkZWEgaGVyZSBpcyB0byBpbml0aWFsaXpl
ZCB3aXRoIE9QUCBkcml2ZXIgd2hpY2ggaGFzIG5vIHRhcmdldCB0aHVzIHRoZSBOVUxMLCBzbyBw
aWNraW5nIHVwIHRoZSBmaXJzdCBkcml2ZXIgaW4gdGhlIGxpc3QgbWF5IG5vdCBlbm91Z2guIEJ0
dywgaWYgcGFzc2luZyBhIE5VTEwgd2FzIGEgYnVnIE9QUCBkcml2ZXIgd291bGQgbmV2ZXIgaGF2
ZSB3b3JrZWQsIHNvIEkgd29uZGVyIGhvdyB5b3UgbWFuYWdlZCB0byBnZXQgbm8gZHJpdmVyIGFz
IGEgcmVzcG9uc2UgdG8gTlVMTCB0YXJnZXQ/DQoNCg0KDQotLQ0KTHVpeiBBdWd1c3RvIHZvbiBE
ZW50eg0KDQoNCldlbGwsIGlmIHRoZSBwcm9maWxlIGlzIE9QUCwgdGhlbiB5b3UgY2FuIGdldCBj
b3JyZWN0IHNlcnZpY2UgZHJpdmVyLiBCdXQgaWYgdGhlIHByb2ZpbGUgaXMgRlRQLCBiZWNhdXNl
IGluIGZ0cC5jOg0KDQpzdGF0aWMgc3RydWN0IG9iZXhfc2VydmljZV9kcml2ZXIgZnRwID0gew0K
CS5uYW1lID0gIkZpbGUgVHJhbnNmZXIgc2VydmVyIiwNCgkuc2VydmljZSA9IE9CRVhfRlRQLA0K
CS5jaGFubmVsID0gRlRQX0NIQU5ORUwsDQoJLnBzbSA9IEZUUF9QU00sDQoJLnJlY29yZCA9IEZU
UF9SRUNPUkQsDQoJLnRhcmdldCA9IEZUUF9UQVJHRVQsDQoJLnRhcmdldF9zaXplID0gVEFSR0VU
X1NJWkUsDQoJLmNvbm5lY3QgPSBmdHBfY29ubmVjdCwNCgkuZ2V0ID0gZnRwX2dldCwNCgkucHV0
ID0gZnRwX3B1dCwNCgkuY2hrcHV0ID0gZnRwX2Noa3B1dCwNCgkuc2V0cGF0aCA9IGZ0cF9zZXRw
YXRoLA0KCS5kaXNjb25uZWN0ID0gZnRwX2Rpc2Nvbm5lY3QNCn07DQpJdGBzIHRhcmdldCBpcyBu
b3QgbnVsbCwgdGFyZ2V0X3NpemUgaXMgMTYsIHNvICIgb2JleF9zZXJ2aWNlX2RyaXZlcl9maW5k
KHNlcnZlci0+ZHJpdmVycywgTlVMTCwwLCBOVUxMLCAwKSIgd2lsbCByZXR1cm4gbnVsbC4NCg0K
QW5kIElgbSBub3QgcGlja2luZyB1cCB0aGUgZmlyc3QgZHJpdmVyIGluIHRoZSBsaXN0LCBhY3R1
YWxseSBpdCBpcyB0aGUgb25seSBvbmUgaW4gdGhlIGxpc3QuDQoNCg0KDQpSZWdhcmRzLA0KTmFt
aQ0KDQoNCg0K

Re: [PATCH obexd] Return correct obex service driver in obex_session_start

[Slawomir Bochenski]

On Thu, Jun 30, 2011 at 12:01 PM, Li, Nami <nami@qca.qualcomm.com> wrote:
> Well, if the profile is OPP, then you can get correct service driver. But if the profile is FTP, because in ftp.c:
>
> static struct obex_service_driver ftp = {
>        .name = "File Transfer server",
>        .service = OBEX_FTP,
>        .channel = FTP_CHANNEL,
>        .psm = FTP_PSM,
>        .record = FTP_RECORD,
>        .target = FTP_TARGET,
>        .target_size = TARGET_SIZE,
>        .connect = ftp_connect,
>        .get = ftp_get,
>        .put = ftp_put,
>        .chkput = ftp_chkput,
>        .setpath = ftp_setpath,
>        .disconnect = ftp_disconnect
> };
> It`s target is not null, target_size is 16, so " obex_service_driver_find(server->drivers, NULL,0, NULL, 0)" will return null.
>
> And I`m not picking up the first driver in the list, actually it is the only one in the list.

In case of other profiles, there is OBEX connect command required, and
then the appropriate driver will be selected in callback for OBEX
connect event (see cmd_connect()).

-- 
Slawomir Bochenski

RE: [PATCH obexd] Return correct obex service driver in obex_session_start

[Li, Nami]

DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBTbGF3b21pciBCb2NoZW5za2kg
W21haWx0bzpsa3NsYXdla0BnbWFpbC5jb21dIA0KU2VudDogMjAxMeW5tDbmnIgzMOaXpSAxODoy
Ng0KVG86IExpLCBOYW1pDQpDYzogTHVpeiBBdWd1c3RvIHZvbiBEZW50ejsgbGludXgtYmx1ZXRv
b3RoQHZnZXIua2VybmVsLm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSCBvYmV4ZF0gUmV0dXJuIGNv
cnJlY3Qgb2JleCBzZXJ2aWNlIGRyaXZlciBpbiBvYmV4X3Nlc3Npb25fc3RhcnQNCg0KT24gVGh1
LCBKdW4gMzAsIDIwMTEgYXQgMTI6MDEgUE0sIExpLCBOYW1pIDxuYW1pQHFjYS5xdWFsY29tbS5j
b20+IHdyb3RlOg0KPiBXZWxsLCBpZiB0aGUgcHJvZmlsZSBpcyBPUFAsIHRoZW4geW91IGNhbiBn
ZXQgY29ycmVjdCBzZXJ2aWNlIGRyaXZlci4gQnV0IGlmIHRoZSBwcm9maWxlIGlzIEZUUCwgYmVj
YXVzZSBpbiBmdHAuYzoNCj4NCj4gc3RhdGljIHN0cnVjdCBvYmV4X3NlcnZpY2VfZHJpdmVyIGZ0
cCA9IHsNCj4gwqAgwqAgwqAgwqAubmFtZSA9ICJGaWxlIFRyYW5zZmVyIHNlcnZlciIsDQo+IMKg
IMKgIMKgIMKgLnNlcnZpY2UgPSBPQkVYX0ZUUCwNCj4gwqAgwqAgwqAgwqAuY2hhbm5lbCA9IEZU
UF9DSEFOTkVMLA0KPiDCoCDCoCDCoCDCoC5wc20gPSBGVFBfUFNNLA0KPiDCoCDCoCDCoCDCoC5y
ZWNvcmQgPSBGVFBfUkVDT1JELA0KPiDCoCDCoCDCoCDCoC50YXJnZXQgPSBGVFBfVEFSR0VULA0K
PiDCoCDCoCDCoCDCoC50YXJnZXRfc2l6ZSA9IFRBUkdFVF9TSVpFLA0KPiDCoCDCoCDCoCDCoC5j
b25uZWN0ID0gZnRwX2Nvbm5lY3QsDQo+IMKgIMKgIMKgIMKgLmdldCA9IGZ0cF9nZXQsDQo+IMKg
IMKgIMKgIMKgLnB1dCA9IGZ0cF9wdXQsDQo+IMKgIMKgIMKgIMKgLmNoa3B1dCA9IGZ0cF9jaGtw
dXQsDQo+IMKgIMKgIMKgIMKgLnNldHBhdGggPSBmdHBfc2V0cGF0aCwNCj4gwqAgwqAgwqAgwqAu
ZGlzY29ubmVjdCA9IGZ0cF9kaXNjb25uZWN0DQo+IH07DQo+IEl0YHMgdGFyZ2V0IGlzIG5vdCBu
dWxsLCB0YXJnZXRfc2l6ZSBpcyAxNiwgc28gIiBvYmV4X3NlcnZpY2VfZHJpdmVyX2ZpbmQoc2Vy
dmVyLT5kcml2ZXJzLCBOVUxMLDAsIE5VTEwsIDApIiB3aWxsIHJldHVybiBudWxsLg0KPg0KPiBB
bmQgSWBtIG5vdCBwaWNraW5nIHVwIHRoZSBmaXJzdCBkcml2ZXIgaW4gdGhlIGxpc3QsIGFjdHVh
bGx5IGl0IGlzIHRoZSBvbmx5IG9uZSBpbiB0aGUgbGlzdC4NCg0KSW4gY2FzZSBvZiBvdGhlciBw
cm9maWxlcywgdGhlcmUgaXMgT0JFWCBjb25uZWN0IGNvbW1hbmQgcmVxdWlyZWQsIGFuZCB0aGVu
IHRoZSBhcHByb3ByaWF0ZSBkcml2ZXIgd2lsbCBiZSBzZWxlY3RlZCBpbiBjYWxsYmFjayBmb3Ig
T0JFWCBjb25uZWN0IGV2ZW50IChzZWUgY21kX2Nvbm5lY3QoKSkuDQoNCi0tDQpTbGF3b21pciBC
b2NoZW5za2kNCg0KDQpZZXAsIHlvdSBjYW4gZ2V0IHJpZ2h0IGRpdmVyIGFmdGVyIGNtZF9jb25u
ZWN0KCkuIEJ1dCBJIHRoaW5rIHVzZXIgc2hvdWxkIGdldCBjb3JyZWN0IGRyaXZlciBvbmNlIG9i
ZXggc2Vzc2lvbiBzdGFydCwgbm90IGFmdGVyIGNvbm5lY3QgY21kLiBXaGF0IGlmIHVzZXIgd2Fu
dCB0byB1c2UgZHJpdmVyIGluIG9iZXhfc2Vzc2lvbl9zdGFydCgpID8gSSBuZWVkIHRvIHVzZSBp
dCB3aGVuIGFkZCBPQkVYIG92ZXIgTDJDQVAuDQpGb3IgT1BQLCBpdCBkb2VzbmB0IHJlZ2lzdGVy
IHRhcmdldCBhbmQgdGFyZ2V0IHNpemUgaW4gb3BwLmMuIFNvIHdoZW4geW91IGNhbGwgIm9iZXhf
c2VydmljZV9kcml2ZXJfZmluZChzZXJ2ZXItPmRyaXZlcnMsIE5VTEwsIDAsIE5VTEwsIDApOyAi
LCBpdCBhbHNvIHJldHVybnMgb24gZmlyc3QgYW5kIG9ubHkgbGlzdCBtZW1iZXI6DQoNCgkJCQkJ
ICBpZiAobWVtbmNtcDAodGFyZ2V0LCB0YXJnZXRfc2l6ZSwgZHJpdmVyLT50YXJnZXQsZHJpdmVy
LT50YXJnZXRfc2l6ZSkgPT0gMCkJCQlyZXR1cm4gZHJpdmVyOw0Kd2hpY2ggaXMgYWN0dWFsbHkg
PT09PiAgICBpZiAobWVtbmNtcDAoTlVMTCwwLCBOVUxMLDApID09IDApCQkJcmV0dXJuIGRyaXZl
cjsNCg0KDQpTbyBJIHRoaW5rIG15IHBhdGNoIGlzIE9LLg0KDQpSZWdhcmRzLA0KTmFtaQ0KDQoN
Cg0K

Re: [PATCH obexd] Return correct obex service driver in obex_session_start

[Luiz Augusto von Dentz]

Hi,

On Fri, Jul 1, 2011 at 5:50 AM, Li, Nami <nami@qca.qualcomm.com> wrote:
>
>
> -----Original Message-----
> From: Slawomir Bochenski [mailto:lkslawek@gmail.com]
> Sent: 2011年6月30日 18:26
> To: Li, Nami
> Cc: Luiz Augusto von Dentz; linux-bluetooth@vger.kernel.org
> Subject: Re: [PATCH obexd] Return correct obex service driver in obex_session_start
>
> On Thu, Jun 30, 2011 at 12:01 PM, Li, Nami <nami@qca.qualcomm.com> wrote:
>> Well, if the profile is OPP, then you can get correct service driver. But if the profile is FTP, because in ftp.c:
>>
>> static struct obex_service_driver ftp = {
>>        .name = "File Transfer server",
>>        .service = OBEX_FTP,
>>        .channel = FTP_CHANNEL,
>>        .psm = FTP_PSM,
>>        .record = FTP_RECORD,
>>        .target = FTP_TARGET,
>>        .target_size = TARGET_SIZE,
>>        .connect = ftp_connect,
>>        .get = ftp_get,
>>        .put = ftp_put,
>>        .chkput = ftp_chkput,
>>        .setpath = ftp_setpath,
>>        .disconnect = ftp_disconnect
>> };
>> It`s target is not null, target_size is 16, so " obex_service_driver_find(server->drivers, NULL,0, NULL, 0)" will return null.
>>
>> And I`m not picking up the first driver in the list, actually it is the only one in the list.
>
> In case of other profiles, there is OBEX connect command required, and then the appropriate driver will be selected in callback for OBEX connect event (see cmd_connect()).
>
> --
> Slawomir Bochenski
>
>
> Yep, you can get right diver after cmd_connect(). But I think user should get correct driver once obex session start, not after connect cmd. What if user want to use driver in obex_session_start() ? I need to use it when add OBEX over L2CAP.
> For OPP, it doesn`t register target and target size in opp.c. So when you call "obex_service_driver_find(server->drivers, NULL, 0, NULL, 0); ", it also returns on first and only list member:
>
>                                          if (memncmp0(target, target_size, driver->target,driver->target_size) == 0)                   return driver;
> which is actually ===>    if (memncmp0(NULL,0, NULL,0) == 0)                    return driver;
>
>
> So I think my patch is OK.

There is no guarantee that the opp will be the first in the list, nor
that the first driver will have no target which is consider the
default, so Im not sure why you are needing this for OBEX over L2CAP
since you still need to figure out what is the real driver on
connect_cmd. Also the sentence about the obex_session_start having to
get the correct driver makes no sense to me, we only know the target
on connect_cmd so we can only guess on obex_session_start that it is
an OPP session, or do you have a better default? Btw, if you are
planning to match the psm/channel with service driver, I believe that
is not a good idea since on some transports there could be no such
separation e.g. usb.

-- 
Luiz Augusto von Dentz

RE: [PATCH obexd] Return correct obex service driver in obex_session_start

[Li, Nami]

SGksIEx1aXoNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IEx1aXogQXVndXN0
byB2b24gRGVudHogW21haWx0bzpsdWl6LmRlbnR6QGdtYWlsLmNvbV0gDQpTZW50OiAyMDEx5bm0
N+aciDHml6UgMTQ6NTINClRvOiBMaSwgTmFtaQ0KQ2M6IFNsYXdvbWlyIEJvY2hlbnNraTsgbGlu
dXgtYmx1ZXRvb3RoQHZnZXIua2VybmVsLm9yZw0KU3ViamVjdDogUmU6IFtQQVRDSCBvYmV4ZF0g
UmV0dXJuIGNvcnJlY3Qgb2JleCBzZXJ2aWNlIGRyaXZlciBpbiBvYmV4X3Nlc3Npb25fc3RhcnQN
Cg0KSGksDQoNCk9uIEZyaSwgSnVsIDEsIDIwMTEgYXQgNTo1MCBBTSwgTGksIE5hbWkgPG5hbWlA
cWNhLnF1YWxjb21tLmNvbT4gd3JvdGU6DQo+DQo+DQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFNsYXdvbWlyIEJvY2hlbnNraSBbbWFpbHRvOmxrc2xhd2VrQGdtYWlsLmNv
bV0NCj4gU2VudDogMjAxMeW5tDbmnIgzMOaXpSAxODoyNg0KPiBUbzogTGksIE5hbWkNCj4gQ2M6
IEx1aXogQXVndXN0byB2b24gRGVudHo7IGxpbnV4LWJsdWV0b290aEB2Z2VyLmtlcm5lbC5vcmcN
Cj4gU3ViamVjdDogUmU6IFtQQVRDSCBvYmV4ZF0gUmV0dXJuIGNvcnJlY3Qgb2JleCBzZXJ2aWNl
IGRyaXZlciBpbiANCj4gb2JleF9zZXNzaW9uX3N0YXJ0DQo+DQo+IE9uIFRodSwgSnVuIDMwLCAy
MDExIGF0IDEyOjAxIFBNLCBMaSwgTmFtaSA8bmFtaUBxY2EucXVhbGNvbW0uY29tPiB3cm90ZToN
Cj4+IFdlbGwsIGlmIHRoZSBwcm9maWxlIGlzIE9QUCwgdGhlbiB5b3UgY2FuIGdldCBjb3JyZWN0
IHNlcnZpY2UgZHJpdmVyLiBCdXQgaWYgdGhlIHByb2ZpbGUgaXMgRlRQLCBiZWNhdXNlIGluIGZ0
cC5jOg0KPj4NCj4+IHN0YXRpYyBzdHJ1Y3Qgb2JleF9zZXJ2aWNlX2RyaXZlciBmdHAgPSB7DQo+
PiDCoCDCoCDCoCDCoC5uYW1lID0gIkZpbGUgVHJhbnNmZXIgc2VydmVyIiwNCj4+IMKgIMKgIMKg
IMKgLnNlcnZpY2UgPSBPQkVYX0ZUUCwNCj4+IMKgIMKgIMKgIMKgLmNoYW5uZWwgPSBGVFBfQ0hB
Tk5FTCwNCj4+IMKgIMKgIMKgIMKgLnBzbSA9IEZUUF9QU00sDQo+PiDCoCDCoCDCoCDCoC5yZWNv
cmQgPSBGVFBfUkVDT1JELA0KPj4gwqAgwqAgwqAgwqAudGFyZ2V0ID0gRlRQX1RBUkdFVCwNCj4+
IMKgIMKgIMKgIMKgLnRhcmdldF9zaXplID0gVEFSR0VUX1NJWkUsDQo+PiDCoCDCoCDCoCDCoC5j
b25uZWN0ID0gZnRwX2Nvbm5lY3QsDQo+PiDCoCDCoCDCoCDCoC5nZXQgPSBmdHBfZ2V0LA0KPj4g
wqAgwqAgwqAgwqAucHV0ID0gZnRwX3B1dCwNCj4+IMKgIMKgIMKgIMKgLmNoa3B1dCA9IGZ0cF9j
aGtwdXQsDQo+PiDCoCDCoCDCoCDCoC5zZXRwYXRoID0gZnRwX3NldHBhdGgsDQo+PiDCoCDCoCDC
oCDCoC5kaXNjb25uZWN0ID0gZnRwX2Rpc2Nvbm5lY3QNCj4+IH07DQo+PiBJdGBzIHRhcmdldCBp
cyBub3QgbnVsbCwgdGFyZ2V0X3NpemUgaXMgMTYsIHNvICIgb2JleF9zZXJ2aWNlX2RyaXZlcl9m
aW5kKHNlcnZlci0+ZHJpdmVycywgTlVMTCwwLCBOVUxMLCAwKSIgd2lsbCByZXR1cm4gbnVsbC4N
Cj4+DQo+PiBBbmQgSWBtIG5vdCBwaWNraW5nIHVwIHRoZSBmaXJzdCBkcml2ZXIgaW4gdGhlIGxp
c3QsIGFjdHVhbGx5IGl0IGlzIHRoZSBvbmx5IG9uZSBpbiB0aGUgbGlzdC4NCj4NCj4gSW4gY2Fz
ZSBvZiBvdGhlciBwcm9maWxlcywgdGhlcmUgaXMgT0JFWCBjb25uZWN0IGNvbW1hbmQgcmVxdWly
ZWQsIGFuZCB0aGVuIHRoZSBhcHByb3ByaWF0ZSBkcml2ZXIgd2lsbCBiZSBzZWxlY3RlZCBpbiBj
YWxsYmFjayBmb3IgT0JFWCBjb25uZWN0IGV2ZW50IChzZWUgY21kX2Nvbm5lY3QoKSkuDQo+DQo+
IC0tDQo+IFNsYXdvbWlyIEJvY2hlbnNraQ0KPg0KPg0KPiBZZXAsIHlvdSBjYW4gZ2V0IHJpZ2h0
IGRpdmVyIGFmdGVyIGNtZF9jb25uZWN0KCkuIEJ1dCBJIHRoaW5rIHVzZXIgc2hvdWxkIGdldCBj
b3JyZWN0IGRyaXZlciBvbmNlIG9iZXggc2Vzc2lvbiBzdGFydCwgbm90IGFmdGVyIGNvbm5lY3Qg
Y21kLiBXaGF0IGlmIHVzZXIgd2FudCB0byB1c2UgZHJpdmVyIGluIG9iZXhfc2Vzc2lvbl9zdGFy
dCgpID8gSSBuZWVkIHRvIHVzZSBpdCB3aGVuIGFkZCBPQkVYIG92ZXIgTDJDQVAuDQo+IEZvciBP
UFAsIGl0IGRvZXNuYHQgcmVnaXN0ZXIgdGFyZ2V0IGFuZCB0YXJnZXQgc2l6ZSBpbiBvcHAuYy4g
U28gd2hlbiB5b3UgY2FsbCAib2JleF9zZXJ2aWNlX2RyaXZlcl9maW5kKHNlcnZlci0+ZHJpdmVy
cywgTlVMTCwgMCwgTlVMTCwgMCk7ICIsIGl0IGFsc28gcmV0dXJucyBvbiBmaXJzdCBhbmQgb25s
eSBsaXN0IG1lbWJlcjoNCj4NCj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBpZiAobWVtbmNtcDAodGFyZ2V0LCANCj4gdGFyZ2V0
X3NpemUsIGRyaXZlci0+dGFyZ2V0LGRyaXZlci0+dGFyZ2V0X3NpemUpID09IDApIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIA0KPiByZXR1cm4gZHJpdmVyOyB3aGljaCBpcyBhY3R1YWxseSA9
PT0+IMKgIMKgaWYgKG1lbW5jbXAwKE5VTEwsMCwgTlVMTCwwKSANCj4gPT0gMCkgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqByZXR1cm4gZHJpdmVyOw0KPg0KPg0KPiBTbyBJIHRoaW5rIG15
IHBhdGNoIGlzIE9LLg0KDQpUaGVyZSBpcyBubyBndWFyYW50ZWUgdGhhdCB0aGUgb3BwIHdpbGwg
YmUgdGhlIGZpcnN0IGluIHRoZSBsaXN0LCBub3IgdGhhdCB0aGUgZmlyc3QgZHJpdmVyIHdpbGwg
aGF2ZSBubyB0YXJnZXQgd2hpY2ggaXMgY29uc2lkZXIgdGhlIGRlZmF1bHQsIHNvIEltIG5vdCBz
dXJlIHdoeSB5b3UgYXJlIG5lZWRpbmcgdGhpcyBmb3IgT0JFWCBvdmVyIEwyQ0FQIHNpbmNlIHlv
dSBzdGlsbCBuZWVkIHRvIGZpZ3VyZSBvdXQgd2hhdCBpcyB0aGUgcmVhbCBkcml2ZXIgb24gY29u
bmVjdF9jbWQuIEFsc28gdGhlIHNlbnRlbmNlIGFib3V0IHRoZSBvYmV4X3Nlc3Npb25fc3RhcnQg
aGF2aW5nIHRvIGdldCB0aGUgY29ycmVjdCBkcml2ZXIgbWFrZXMgbm8gc2Vuc2UgdG8gbWUsIHdl
IG9ubHkga25vdyB0aGUgdGFyZ2V0IG9uIGNvbm5lY3RfY21kIHNvIHdlIGNhbiBvbmx5IGd1ZXNz
IG9uIG9iZXhfc2Vzc2lvbl9zdGFydCB0aGF0IGl0IGlzIGFuIE9QUCBzZXNzaW9uLCBvciBkbyB5
b3UgaGF2ZSBhIGJldHRlciBkZWZhdWx0PyBCdHcsIGlmIHlvdSBhcmUgcGxhbm5pbmcgdG8gbWF0
Y2ggdGhlIHBzbS9jaGFubmVsIHdpdGggc2VydmljZSBkcml2ZXIsIEkgYmVsaWV2ZSB0aGF0IGlz
IG5vdCBhIGdvb2QgaWRlYSBzaW5jZSBvbiBzb21lIHRyYW5zcG9ydHMgdGhlcmUgY291bGQgYmUg
bm8gc3VjaCBzZXBhcmF0aW9uIGUuZy4gdXNiLg0KDQotLQ0KTHVpeiBBdWd1c3RvIHZvbiBEZW50
eg0KDQoNCkkgZGlkIHNvbWUgdGVzdHMgYW5kIEkgZGlkbmB0IGZpbmQgd2hpY2ggY2FzZSB0aGUg
bGlzdCBtZW1iZXIgbGFyZ2UgdGhhbiBvbmUuIENhbiB5b3UgdGVsbCBtZSB3aGljaCBjYXNlIHRo
ZSBsaXN0IG1lbWJlciB3aWxsIGxhcmdlIHRoYW4gb25lPw0KSWYgT0JFWCBvdmVyIEwyQ0FQIHVz
ZSBTRVFQQUNLRVQsIHRoZW4gSSBuZWVkIHRvIHRlbGwgb3Blbm9iZXggdGhlIGRhdGEgZm9ybWF0
IGlzIFNFUVBBQ0tFVCB0byByZWNlaXZlIGRhdGEgY29ycmVjdGx5IGluY2x1ZGluZyBjb25uZWN0
IGNtZC4gU28gSSBuZWVkIHRvIGtub3cgT0JFWCBvdmVyIEwyQ0FQIG9yIFJGQ09NTSBpbiBvYmV4
X3Nlc3Npb25fc3RhcnQuDQpOb3csIEkgaGF2ZSBhIGRvdWJ0LCB3aHkgd2UgZ2V0IGRyaXZlciBi
eSB0YXJnZXQgYW5kIHdobz8gQ2FuIHdlIGdldCBkcml2ZXIgZGlyZWN0bHkgYnkgY2hhbm5lbCBz
aW5jZSBvYmV4IHByb2ZpbGVzIHVzaW5nIGRpZmZlcmVudCBjaGFubmVscz8gDQoNCg0KDQpSZWdh
cmRzLA0KTmFtaQ0KDQoNCg0K