All of lore.kernel.org
 help / color / mirror / Atom feed
* [ath9k-devel] broadcast rate
@ 2011-05-26 11:00 kcilc.dragos at mamber.net
  2011-05-26 13:24 ` Mohammed Shafi
  0 siblings, 1 reply; 4+ messages in thread
From: kcilc.dragos at mamber.net @ 2011-05-26 11:00 UTC (permalink / raw)
  To: ath9k-devel


Hi,

I am using compat-wireless-2.6.39 to try to inject broacast frames at HT 
rates using ath9k, but what comes out are frames at legacy rate. For 
example for 2.4GHz, my broadcast frames go out at 1Mbps, whereas for 5GHz 
they go at 6Mbps. That seems to be true for all bcast traffic - ARP, PING, 
or click.

Is there a setting to disable this behavior? Or a patch...?

Thanks,
-- 
Dragos

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ath9k-devel] broadcast rate
  2011-05-26 11:00 [ath9k-devel] broadcast rate kcilc.dragos at mamber.net
@ 2011-05-26 13:24 ` Mohammed Shafi
       [not found]   ` <alpine.DEB.2.00.1105261743501.11773@zor.elcom.pub.ro>
  0 siblings, 1 reply; 4+ messages in thread
From: Mohammed Shafi @ 2011-05-26 13:24 UTC (permalink / raw)
  To: ath9k-devel

On Thu, May 26, 2011 at 4:30 PM,  <kcilc.dragos@mamber.net> wrote:
>
> Hi,
>
> I am using compat-wireless-2.6.39 to try to inject broacast frames at HT
> rates using ath9k, but what comes out are frames at legacy rate. For
> example for 2.4GHz, my broadcast frames go out at 1Mbps, whereas for 5GHz
> they go at 6Mbps. That seems to be true for all bcast traffic - ARP, PING,
> or click.
>
> Is there a setting to disable this behavior? Or a patch...?

doest this help, please check

diff --git a/drivers/net/wireless/ath/ath9k/rc.c
b/drivers/net/wireless/ath/ath9k/rc.c
index 1754221..64814fb 100644
--- a/drivers/net/wireless/ath/ath9k/rc.c
+++ b/drivers/net/wireless/ath/ath9k/rc.c
@@ -746,8 +746,6 @@ static void ath_get_rate(void *priv, struct
ieee80211_sta *sta, void *priv_sta,
        u8 try_per_rate, i = 0, rix;
        int is_probe = 0;

-       if (rate_control_send_low(sta, priv_sta, txrc))
-               return;

        /*
         * For Multi Rate Retry we use a different number of



>
> Thanks,
> --
> Dragos
>
> _______________________________________________
> ath9k-devel mailing list
> ath9k-devel at lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [ath9k-devel] broadcast rate
       [not found]   ` <alpine.DEB.2.00.1105261743501.11773@zor.elcom.pub.ro>
@ 2011-05-26 14:51     ` Mohammed Shafi
       [not found]     ` <BANLkTi=t5kP4dG7QfmDO6k+8GKZ4fC0PVA@mail.gmail.com>
  1 sibling, 0 replies; 4+ messages in thread
From: Mohammed Shafi @ 2011-05-26 14:51 UTC (permalink / raw)
  To: ath9k-devel

On Thu, May 26, 2011 at 8:16 PM,  <kcilc.dragos@mamber.net> wrote:
>
>
>
> On Thu, 26 May 2011, Mohammed Shafi - shafi.ath9k at gmail.com wrote:
>
>> On Thu, May 26, 2011 at 4:30 PM, ?<kcilc.dragos@mamber.net> wrote:
>>>
>>> Hi,
>>>
>>> I am using compat-wireless-2.6.39 to try to inject broacast frames at HT
>>> rates using ath9k, but what comes out are frames at legacy rate. For
>>> example for 2.4GHz, my broadcast frames go out at 1Mbps, whereas for 5GHz
>>> they go at 6Mbps. That seems to be true for all bcast traffic - ARP,
>>> PING,
>>> or click.
>>>
>>> Is there a setting to disable this behavior? Or a patch...?
>>
>> doest this help, please check
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/rc.c
>> b/drivers/net/wireless/ath/ath9k/rc.c
>> index 1754221..64814fb 100644
>> --- a/drivers/net/wireless/ath/ath9k/rc.c
>> +++ b/drivers/net/wireless/ath/ath9k/rc.c
>> @@ -746,8 +746,6 @@ static void ath_get_rate(void *priv, struct
>> ieee80211_sta *sta, void *priv_sta,
>> ? ? ? u8 try_per_rate, i = 0, rix;
>> ? ? ? int is_probe = 0;
>>
>> - ? ? ? if (rate_control_send_low(sta, priv_sta, txrc))
>> - ? ? ? ? ? ? ? return;
>>
>> ? ? ? /*
>> ? ? ? ?* For Multi Rate Retry we use a different number of
>>
>
> The machine freezes, and then reboots with this patch. It happens right when
> after I try to iw connect...

:( sorry for it, let me see take a look it closely... I am not aware
of any other place we could do it.


>
> Thanks,
> --
> Drago?
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [ath9k-devel] broadcast rate
       [not found]     ` <BANLkTi=t5kP4dG7QfmDO6k+8GKZ4fC0PVA@mail.gmail.com>
@ 2011-05-26 15:15       ` Mohammed Shafi
  0 siblings, 0 replies; 4+ messages in thread
From: Mohammed Shafi @ 2011-05-26 15:15 UTC (permalink / raw)
  To: ath9k-devel

On Thu, May 26, 2011 at 8:40 PM, Mohammed Shafi <shafi.ath9k@gmail.com> wrote:
> On Thu, May 26, 2011 at 8:16 PM, ?<kcilc.dragos@mamber.net> wrote:
>>
>>
>>
>> On Thu, 26 May 2011, Mohammed Shafi - shafi.ath9k at gmail.com wrote:
>>
>>> On Thu, May 26, 2011 at 4:30 PM, ?<kcilc.dragos@mamber.net> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I am using compat-wireless-2.6.39 to try to inject broacast frames at HT
>>>> rates using ath9k, but what comes out are frames at legacy rate. For
>>>> example for 2.4GHz, my broadcast frames go out at 1Mbps, whereas for 5GHz
>>>> they go at 6Mbps. That seems to be true for all bcast traffic - ARP,
>>>> PING,
>>>> or click.
>>>>
>>>> Is there a setting to disable this behavior? Or a patch...?
>>>
>>> doest this help, please check
>>>
>>> diff --git a/drivers/net/wireless/ath/ath9k/rc.c
>>> b/drivers/net/wireless/ath/ath9k/rc.c
>>> index 1754221..64814fb 100644
>>> --- a/drivers/net/wireless/ath/ath9k/rc.c
>>> +++ b/drivers/net/wireless/ath/ath9k/rc.c
>>> @@ -746,8 +746,6 @@ static void ath_get_rate(void *priv, struct
>>> ieee80211_sta *sta, void *priv_sta,
>>> ? ? ? u8 try_per_rate, i = 0, rix;
>>> ? ? ? int is_probe = 0;
>>>
>>> - ? ? ? if (rate_control_send_low(sta, priv_sta, txrc))
>>> - ? ? ? ? ? ? ? return;
>>>
>>> ? ? ? /*
>>> ? ? ? ?* For Multi Rate Retry we use a different number of
>>>
>>
>> The machine freezes, and then reboots with this patch. It happens right when
>> after I try to iw connect...
>
>
> hmm yes true, I too got it .. few pointers may be NULL especially priv_sta
>
> now saw in mac80211.h
>
> **
> ?* rate_control_send_low - helper for drivers for management/no-ack frames
> ?*
> ?* Rate control algorithms that agree to use the lowest rate to
> ?* send management frames and NO_ACK data with the respective hw
> ?* retries should use this in the beginning of their mac80211 get_rate
> ?* callback. If true is returned the rate control can simply return.
> ?* If false is returned we guarantee that sta and sta and priv_sta is
> ?* not null.
> ?*
> ?* Rate control algorithms wishing to do more intelligent selection of
> ?* rate for multicast/broadcast frames may choose to not use this.
> ?*
> ?* @sta: &struct ieee80211_sta pointer to the target destination. Note
> ?* ? ? ?that this may be null.
> ?* @priv_sta: private rate control structure. This may be null.
> ?* @txrc: rate control information we sholud populate for mac802
>
>>


got some idea, may be we can return from the call back if any one of
the pointers priv_sta || sta is  NULL ?

>> Thanks,
>> --
>> Drago?
>>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-05-26 15:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-26 11:00 [ath9k-devel] broadcast rate kcilc.dragos at mamber.net
2011-05-26 13:24 ` Mohammed Shafi
     [not found]   ` <alpine.DEB.2.00.1105261743501.11773@zor.elcom.pub.ro>
2011-05-26 14:51     ` Mohammed Shafi
     [not found]     ` <BANLkTi=t5kP4dG7QfmDO6k+8GKZ4fC0PVA@mail.gmail.com>
2011-05-26 15:15       ` Mohammed Shafi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.