All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Menon, Nishanth" <nm@ti.com>
To: Shweta Gulati <shweta.gulati@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Benoit Cousson <b-cousson@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH V4] OMAP3+: SR Layer Cleanup
Date: Fri, 20 May 2011 08:23:02 -0500	[thread overview]
Message-ID: <BANLkTi=sLwrdaOanRNDM+NsnBGjxn5G6nQ@mail.gmail.com> (raw)
In-Reply-To: <1305268062-20046-1-git-send-email-shweta.gulati@ti.com>

On Fri, May 13, 2011 at 01:27, Shweta Gulati <shweta.gulati@ti.com> wrote:
[...]
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 3cd91ac..b1b11de 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -29,6 +29,7 @@
>
>  #include "omap_hwmod_common_data.h"
>
> +#include "smartreflex.h"
>  #include "prm-regbits-34xx.h"
>  #include "cm-regbits-34xx.h"
>  #include "wd_timer.h"
> @@ -2904,6 +2905,10 @@ static struct omap_hwmod_class omap36xx_smartreflex_hwmod_class = {
>  };
>
>  /* SR1 */
> +static struct omap_smartreflex_dev_attr sr1_dev_attr = {
> +       .sensor_voltdm_name   = "mpu_iva",
> +};

[...]
> diff --git a/arch/arm/mach-omap2/smartreflex.h b/arch/arm/mach-omap2/smartreflex.h
> index 5f35b9e..aeeec5f 100644
> --- a/arch/arm/mach-omap2/smartreflex.h
> +++ b/arch/arm/mach-omap2/smartreflex.h
> @@ -197,6 +197,16 @@ struct omap_sr_nvalue_table {
>  };
>
>  /**
> + * struct omap_smartreflex_dev_attr - Smartreflex Device attribute.
> + *
> + * @sensor_voltdm_name:       Name of voltdomain of SR instance
> + */
> +
> +struct omap_smartreflex_dev_attr {
> +       const char      *sensor_voltdm_name;
> +};
> +

This structure is in #ifdef CONFIG_SMART_REFLEX and breaks
hwmod_data.c when built without SR.
please move it out of the #ifdef in your next rev.

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Menon, Nishanth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4] OMAP3+: SR Layer Cleanup
Date: Fri, 20 May 2011 08:23:02 -0500	[thread overview]
Message-ID: <BANLkTi=sLwrdaOanRNDM+NsnBGjxn5G6nQ@mail.gmail.com> (raw)
In-Reply-To: <1305268062-20046-1-git-send-email-shweta.gulati@ti.com>

On Fri, May 13, 2011 at 01:27, Shweta Gulati <shweta.gulati@ti.com> wrote:
[...]
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 3cd91ac..b1b11de 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -29,6 +29,7 @@
>
> ?#include "omap_hwmod_common_data.h"
>
> +#include "smartreflex.h"
> ?#include "prm-regbits-34xx.h"
> ?#include "cm-regbits-34xx.h"
> ?#include "wd_timer.h"
> @@ -2904,6 +2905,10 @@ static struct omap_hwmod_class omap36xx_smartreflex_hwmod_class = {
> ?};
>
> ?/* SR1 */
> +static struct omap_smartreflex_dev_attr sr1_dev_attr = {
> + ? ? ? .sensor_voltdm_name ? = "mpu_iva",
> +};

[...]
> diff --git a/arch/arm/mach-omap2/smartreflex.h b/arch/arm/mach-omap2/smartreflex.h
> index 5f35b9e..aeeec5f 100644
> --- a/arch/arm/mach-omap2/smartreflex.h
> +++ b/arch/arm/mach-omap2/smartreflex.h
> @@ -197,6 +197,16 @@ struct omap_sr_nvalue_table {
> ?};
>
> ?/**
> + * struct omap_smartreflex_dev_attr - Smartreflex Device attribute.
> + *
> + * @sensor_voltdm_name: ? ? ? Name of voltdomain of SR instance
> + */
> +
> +struct omap_smartreflex_dev_attr {
> + ? ? ? const char ? ? ?*sensor_voltdm_name;
> +};
> +

This structure is in #ifdef CONFIG_SMART_REFLEX and breaks
hwmod_data.c when built without SR.
please move it out of the #ifdef in your next rev.

Regards,
Nishanth Menon

  parent reply	other threads:[~2011-05-20 13:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13  6:27 [PATCH V4] OMAP3+: SR Layer Cleanup Shweta Gulati
2011-05-13  6:27 ` Shweta Gulati
2011-05-19  8:59 ` Kevin Hilman
2011-05-19  8:59   ` Kevin Hilman
2011-05-19  9:39   ` Gulati, Shweta
2011-05-19  9:39     ` Gulati, Shweta
2011-05-20 13:23 ` Menon, Nishanth [this message]
2011-05-20 13:23   ` Menon, Nishanth
2011-05-20 13:49 ` Cousson, Benoit
2011-05-20 13:49   ` Cousson, Benoit
2011-05-23  4:40   ` Gulati, Shweta
2011-05-23  4:40     ` Gulati, Shweta
2011-05-24 11:52     ` Cousson, Benoit
2011-05-24 11:52       ` Cousson, Benoit
2011-05-25  6:39       ` Gulati, Shweta
2011-05-25  6:39         ` Gulati, Shweta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=sLwrdaOanRNDM+NsnBGjxn5G6nQ@mail.gmail.com' \
    --to=nm@ti.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=shweta.gulati@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.