From: Jason Hui <jason.hui@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V7 3/3] MX53: support for freescale MX53LOCO board
Date: Thu, 12 May 2011 13:31:22 +0800 [thread overview]
Message-ID: <BANLkTik2Lh4eVaYuwg17vHrfy5eYMWObow@mail.gmail.com> (raw)
In-Reply-To: <359310.456.qm@web39422.mail.mud.yahoo.com>
Hi, Fabio,
On Wed, May 11, 2011 at 8:03 PM, Fabio Estevam <fabioestevam@yahoo.com> wrote:
> Hi Jason,
>
> --- On Wed, 5/11/11, Jason Liu <jason.hui@linaro.org> wrote:
> ...
>> diff --git a/arch/arm/cpu/armv7/mx5/soc.c
>> b/arch/arm/cpu/armv7/mx5/soc.c
>> index 6f4e8db..9c03474 100644
>> --- a/arch/arm/cpu/armv7/mx5/soc.c
>> +++ b/arch/arm/cpu/armv7/mx5/soc.c
> ...
>
> This file is not MX53Loco specific, so it should be part of another patch.
>
>> mxc_get_clock(MXC_ARM_CLK) / 1000000);
>> -??? printf("Reset cause: %s\n", get_reset_cause());
>> +??? printf("Reset? cause: %s\n", get_reset_cause());
>> ???? return 0;
>
> What is the purpose of this change?
Just make the print looks good. Nothing else. I can remove it.
>
>> index f687503..2d7e9ed 100644
>> --- a/arch/arm/include/asm/arch-mx5/sys_proto.h
>> +++ b/arch/arm/include/asm/arch-mx5/sys_proto.h
>
> This file is not MX53Loco specific, so it should be part of another patch.
Will move to another file as Stefano suggest.
Jason
>
> Regards,
>
> Fabio Estevam
>
next prev parent reply other threads:[~2011-05-12 5:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 8:03 [U-Boot] [PATCH V7 1/3] MX5: clock: Add clock config interface Jason Liu
2011-05-11 8:03 ` [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support Jason Liu
2011-05-12 9:19 ` Stefano Babic
2011-05-13 3:08 ` Jason Liu
2011-05-13 6:38 ` Stefano Babic
2011-05-13 8:41 ` Jason Liu
2011-05-13 8:47 ` Stefano Babic
2011-05-13 9:04 ` Jason Hui
2011-05-11 8:03 ` [U-Boot] [PATCH V7 3/3] MX53: support for freescale MX53LOCO board Jason Liu
2011-05-11 12:03 ` Fabio Estevam
2011-05-12 5:31 ` Jason Hui [this message]
2011-05-11 12:37 ` Stefano Babic
2011-05-12 5:32 ` Jason Hui
2011-05-12 6:13 ` Jason Liu
2011-05-12 9:03 ` Stefano Babic
2011-05-13 3:13 ` Jason Hui
2011-05-20 18:35 ` Albert ARIBAUD
2011-05-16 9:26 ` [U-Boot] [PATCH V7 1/3] MX5: clock: Add clock config interface Stefano Babic
2011-05-17 6:25 ` Jason Liu
2011-05-17 11:15 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTik2Lh4eVaYuwg17vHrfy5eYMWObow@mail.gmail.com \
--to=jason.hui@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.