From: Minchan Kim <minchan.kim@gmail.com>
To: Cesar Eduardo Barros <cesarb@cesarb.net>
Cc: linux-mm@kvack.org, Jan Beulich <JBeulich@novell.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger@sun.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleancache: use __read_mostly for cleancache_enabled
Date: Mon, 30 May 2011 09:35:29 +0900 [thread overview]
Message-ID: <BANLkTikX+dKsdwGOxG10Q2LVd_rCxEBRHw@mail.gmail.com> (raw)
In-Reply-To: <1306701498-10846-1-git-send-email-cesarb@cesarb.net>
On Mon, May 30, 2011 at 5:38 AM, Cesar Eduardo Barros <cesarb@cesarb.net> wrote:
> The global variable cleancache_enabled is read often but written to
> rarely. Use __read_mostly to prevent it being on the same cacheline as
> another variable which is written to often, which would cause cacheline
> bouncing.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
--
Kind regards,
Minchan Kim
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com>
To: Cesar Eduardo Barros <cesarb@cesarb.net>
Cc: linux-mm@kvack.org, Jan Beulich <JBeulich@novell.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger@sun.com>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cleancache: use __read_mostly for cleancache_enabled
Date: Mon, 30 May 2011 09:35:29 +0900 [thread overview]
Message-ID: <BANLkTikX+dKsdwGOxG10Q2LVd_rCxEBRHw@mail.gmail.com> (raw)
In-Reply-To: <1306701498-10846-1-git-send-email-cesarb@cesarb.net>
On Mon, May 30, 2011 at 5:38 AM, Cesar Eduardo Barros <cesarb@cesarb.net> wrote:
> The global variable cleancache_enabled is read often but written to
> rarely. Use __read_mostly to prevent it being on the same cacheline as
> another variable which is written to often, which would cause cacheline
> bouncing.
>
> Signed-off-by: Cesar Eduardo Barros <cesarb@cesarb.net>
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-30 0:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 20:38 [PATCH] cleancache: use __read_mostly for cleancache_enabled Cesar Eduardo Barros
2011-05-29 20:38 ` Cesar Eduardo Barros
2011-05-30 0:35 ` Minchan Kim [this message]
2011-05-30 0:35 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTikX+dKsdwGOxG10Q2LVd_rCxEBRHw@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=JBeulich@novell.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=cesarb@cesarb.net \
--cc=dan.magenheimer@oracle.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.