All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Lee Jones <lee.jones@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Mattias Wallin <mattias.wallin@stericsson.com>
Subject: Re: [PATCH 2/3] clocksource: add DB8500 PRCMU Timer support
Date: Wed, 1 Jun 2011 10:37:16 +0200	[thread overview]
Message-ID: <BANLkTimAOWNJNGJwJkCkwwDJ2BR__NCV+A@mail.gmail.com> (raw)
In-Reply-To: <20110601083000.GD3660@n2100.arm.linux.org.uk>

2011/6/1 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Tue, May 31, 2011 at 11:18:25PM +0200, Linus Walleij wrote:
>> Keeping it under include/linux is probably wise since we want drivers
>> OUT of the ARM tree, but I don't know if there is much consensus on that?
>
> Header files private to a driver should be alongside the driver.  Look
> at drivers/net or drivers/scsi for plenty of examples.
>
> Just because its a header file does not mean it must be in some directory
> with 'include' in its path.  The only reason to put it in include/linux
> is if it contains stuff which needs to be shared outside of the driver
> (eg, with arches).

I agree. Right now I have a creepy feeling that many drivers are just
putting headers in <mach/foo.h> out of habit, when plain "foo.h" in
working dir or <linux/subsystem/foo.h> is what is really apropriate.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] clocksource: add DB8500 PRCMU Timer support
Date: Wed, 1 Jun 2011 10:37:16 +0200	[thread overview]
Message-ID: <BANLkTimAOWNJNGJwJkCkwwDJ2BR__NCV+A@mail.gmail.com> (raw)
In-Reply-To: <20110601083000.GD3660@n2100.arm.linux.org.uk>

2011/6/1 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Tue, May 31, 2011 at 11:18:25PM +0200, Linus Walleij wrote:
>> Keeping it under include/linux is probably wise since we want drivers
>> OUT of the ARM tree, but I don't know if there is much consensus on that?
>
> Header files private to a driver should be alongside the driver. ?Look
> at drivers/net or drivers/scsi for plenty of examples.
>
> Just because its a header file does not mean it must be in some directory
> with 'include' in its path. ?The only reason to put it in include/linux
> is if it contains stuff which needs to be shared outside of the driver
> (eg, with arches).

I agree. Right now I have a creepy feeling that many drivers are just
putting headers in <mach/foo.h> out of habit, when plain "foo.h" in
working dir or <linux/subsystem/foo.h> is what is really apropriate.

Yours,
Linus Walleij

  reply	other threads:[~2011-06-01  8:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31  8:31 [PATCH 2/3] clocksource: add DB8500 PRCMU Timer support Mattias Wallin
2011-05-31  8:31 ` Mattias Wallin
2011-05-31 10:38 ` Thomas Gleixner
2011-05-31 10:38   ` Thomas Gleixner
2011-05-31 17:00   ` Mattias Wallin
2011-05-31 17:00     ` Mattias Wallin
2011-05-31 21:18     ` Linus Walleij
2011-05-31 21:18       ` Linus Walleij
2011-06-01  7:57       ` Mattias Wallin
2011-06-01  7:57         ` Mattias Wallin
2011-06-01 14:22         ` Mattias Wallin
2011-06-01 14:22           ` Mattias Wallin
2011-06-01 14:25           ` Russell King - ARM Linux
2011-06-01 14:25             ` Russell King - ARM Linux
2011-06-01 14:31             ` Mattias Wallin
2011-06-01 14:31               ` Mattias Wallin
2011-06-01 14:36               ` Mattias Wallin
2011-06-01 14:36                 ` Mattias Wallin
2011-06-01 23:35               ` Linus Walleij
2011-06-01 23:35                 ` Linus Walleij
2011-06-01  8:30       ` Russell King - ARM Linux
2011-06-01  8:30         ` Russell King - ARM Linux
2011-06-01  8:37         ` Linus Walleij [this message]
2011-06-01  8:37           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimAOWNJNGJwJkCkwwDJ2BR__NCV+A@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mattias.wallin@stericsson.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.