* [PATCH v2] x264_r2245: do not override `DEPENDS` for x86
@ 2011-05-08 11:00 Bob Foerster
2011-05-08 11:09 ` Paul Menzel
0 siblings, 1 reply; 5+ messages in thread
From: Bob Foerster @ 2011-05-08 11:00 UTC (permalink / raw)
To: openembedded-devel
The recipe intended to add "yasm-native" to the dependencies on x86,
but it set DEPENDS_x86 = "yasm-native" which obliterated the base
dependencies. On a fresh build, this package was failing since it
was trying to build before the compiler was ready.
Depends is now set with DEPENDS_append_x86, which leaves the base
dependencies intact.
Signed-off-by: Bob Foerster <robert@erafx.com>
---
recipes/vlc/x264_r2245.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
index 0cffea3..21e5a0e 100644
--- a/recipes/vlc/x264_r2245.bb
+++ b/recipes/vlc/x264_r2245.bb
@@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
X264_DISABLE_ASM = "--disable-asm"
# use assembler written functions for those archs supporting this
X264_DISABLE_ASM_x86 = ""
-DEPENDS_x86 = "yasm-native"
+DEPENDS_append_x86 = " yasm-native"
EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}"'
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] x264_r2245: do not override `DEPENDS` for x86
2011-05-08 11:00 [PATCH v2] x264_r2245: do not override `DEPENDS` for x86 Bob Foerster
@ 2011-05-08 11:09 ` Paul Menzel
2011-05-08 11:33 ` Robert Foerster
0 siblings, 1 reply; 5+ messages in thread
From: Paul Menzel @ 2011-05-08 11:09 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Dear Bob,
Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:
> The recipe intended to add "yasm-native" to the dependencies on x86,
> but it set DEPENDS_x86 = "yasm-native" which obliterated the base
> dependencies. On a fresh build, this package was failing since it
> was trying to build before the compiler was ready.
>
> Depends is now set with DEPENDS_append_x86, which leaves the base
> dependencies intact.
Btw. What `MACHINE` and `DISTRIBUTION` do you use?
> Signed-off-by: Bob Foerster <robert@erafx.com>
> ---
> recipes/vlc/x264_r2245.bb | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
> index 0cffea3..21e5a0e 100644
> --- a/recipes/vlc/x264_r2245.bb
> +++ b/recipes/vlc/x264_r2245.bb
> @@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
> X264_DISABLE_ASM = "--disable-asm"
> # use assembler written functions for those archs supporting this
> X264_DISABLE_ASM_x86 = ""
> -DEPENDS_x86 = "yasm-native"
> +DEPENDS_append_x86 = " yasm-native"
>
> EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}"'
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] x264_r2245: do not override `DEPENDS` for x86
2011-05-08 11:09 ` Paul Menzel
@ 2011-05-08 11:33 ` Robert Foerster
2011-05-08 15:35 ` Paul Menzel
0 siblings, 1 reply; 5+ messages in thread
From: Robert Foerster @ 2011-05-08 11:33 UTC (permalink / raw)
To: openembedded-devel
On Sun, May 8, 2011 at 7:09 AM, Paul Menzel <
paulepanter@users.sourceforge.net> wrote:
> Dear Bob,
>
>
> Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:
> > The recipe intended to add "yasm-native" to the dependencies on x86,
> > but it set DEPENDS_x86 = "yasm-native" which obliterated the base
> > dependencies. On a fresh build, this package was failing since it
> > was trying to build before the compiler was ready.
> >
> > Depends is now set with DEPENDS_append_x86, which leaves the base
> > dependencies intact.
>
> Btw. What `MACHINE` and `DISTRIBUTION` do you use?
>
machine=x86, distro=custom
>
> > Signed-off-by: Bob Foerster <robert@erafx.com>
> > ---
> > recipes/vlc/x264_r2245.bb | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
> > index 0cffea3..21e5a0e 100644
> > --- a/recipes/vlc/x264_r2245.bb
> > +++ b/recipes/vlc/x264_r2245.bb
> > @@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
> > X264_DISABLE_ASM = "--disable-asm"
> > # use assembler written functions for those archs supporting this
> > X264_DISABLE_ASM_x86 = ""
> > -DEPENDS_x86 = "yasm-native"
> > +DEPENDS_append_x86 = " yasm-native"
> >
> > EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM}
> --extra-cflags="${X264_ECFLAGS}"'
>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
>
>
> Thanks,
>
> Paul
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] x264_r2245: do not override `DEPENDS` for x86
2011-05-08 11:33 ` Robert Foerster
@ 2011-05-08 15:35 ` Paul Menzel
2011-05-09 14:54 ` Robert Foerster
0 siblings, 1 reply; 5+ messages in thread
From: Paul Menzel @ 2011-05-08 15:35 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 1968 bytes --]
Am Sonntag, den 08.05.2011, 07:33 -0400 schrieb Robert Foerster:
> On Sun, May 8, 2011 at 7:09 AM, Paul Menzel wrote:
> > Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:
> > > The recipe intended to add "yasm-native" to the dependencies on x86,
> > > but it set DEPENDS_x86 = "yasm-native" which obliterated the base
> > > dependencies. On a fresh build, this package was failing since it
> > > was trying to build before the compiler was ready.
> > >
> > > Depends is now set with DEPENDS_append_x86, which leaves the base
> > > dependencies intact.
> >
> > Btw. What `MACHINE` and `DISTRIBUTION` do you use?
>
> machine=x86, distro=custom
>
> > > Signed-off-by: Bob Foerster <robert@erafx.com>
> > > ---
> > > recipes/vlc/x264_r2245.bb | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
> > > index 0cffea3..21e5a0e 100644
> > > --- a/recipes/vlc/x264_r2245.bb
> > > +++ b/recipes/vlc/x264_r2245.bb
> > > @@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
> > > X264_DISABLE_ASM = "--disable-asm"
> > > # use assembler written functions for those archs supporting this
> > > X264_DISABLE_ASM_x86 = ""
> > > -DEPENDS_x86 = "yasm-native"
> > > +DEPENDS_append_x86 = " yasm-native"
> > >
> > > EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM}
> > --extra-cflags="${X264_ECFLAGS}"'
> >
> > Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
I pushed your patch upstream in 0409d1d9 [1].
Please update the patch queue [2] with for example the following
command.
$ pwclient update -s Accepted -c 0409d1d98a400c56d348de1f49c8a09f38b52fba 3385
I do not have the rights to change the state of patches I did not
submit.
Thanks,
Paul
[1] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=0409d1d98a400c56d348de1f49c8a09f38b52fba
[2] http://openembedded.org/index.php/Patchwork
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] x264_r2245: do not override `DEPENDS` for x86
2011-05-08 15:35 ` Paul Menzel
@ 2011-05-09 14:54 ` Robert Foerster
0 siblings, 0 replies; 5+ messages in thread
From: Robert Foerster @ 2011-05-09 14:54 UTC (permalink / raw)
To: openembedded-devel
On Sun, May 8, 2011 at 11:35 AM, Paul Menzel <
paulepanter@users.sourceforge.net> wrote:
> Am Sonntag, den 08.05.2011, 07:33 -0400 schrieb Robert Foerster:
> > On Sun, May 8, 2011 at 7:09 AM, Paul Menzel wrote:
>
> > > Am Sonntag, den 08.05.2011, 07:00 -0400 schrieb Bob Foerster:
> > > > The recipe intended to add "yasm-native" to the dependencies on x86,
> > > > but it set DEPENDS_x86 = "yasm-native" which obliterated the base
> > > > dependencies. On a fresh build, this package was failing since it
> > > > was trying to build before the compiler was ready.
> > > >
> > > > Depends is now set with DEPENDS_append_x86, which leaves the base
> > > > dependencies intact.
> > >
> > > Btw. What `MACHINE` and `DISTRIBUTION` do you use?
> >
> > machine=x86, distro=custom
> >
> > > > Signed-off-by: Bob Foerster <robert@erafx.com>
> > > > ---
> > > > recipes/vlc/x264_r2245.bb | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
> > > > index 0cffea3..21e5a0e 100644
> > > > --- a/recipes/vlc/x264_r2245.bb
> > > > +++ b/recipes/vlc/x264_r2245.bb
> > > > @@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
> > > > X264_DISABLE_ASM = "--disable-asm"
> > > > # use assembler written functions for those archs supporting this
> > > > X264_DISABLE_ASM_x86 = ""
> > > > -DEPENDS_x86 = "yasm-native"
> > > > +DEPENDS_append_x86 = " yasm-native"
> > > >
> > > > EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM}
> > > --extra-cflags="${X264_ECFLAGS}"'
> > >
> > > Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
>
> I pushed your patch upstream in 0409d1d9 [1].
>
> Please update the patch queue [2] with for example the following
> command.
>
> $ pwclient update -s Accepted -c
> 0409d1d98a400c56d348de1f49c8a09f38b52fba 3385
>
> I do not have the rights to change the state of patches I did not
> submit.
>
>
>
Done. Thanks, Paul!
> Thanks,
>
> Paul
>
>
> [1]
> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=0409d1d98a400c56d348de1f49c8a09f38b52fba
> [2] http://openembedded.org/index.php/Patchwork
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-09 14:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-08 11:00 [PATCH v2] x264_r2245: do not override `DEPENDS` for x86 Bob Foerster
2011-05-08 11:09 ` Paul Menzel
2011-05-08 11:33 ` Robert Foerster
2011-05-08 15:35 ` Paul Menzel
2011-05-09 14:54 ` Robert Foerster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.