* [Qemu-devel] [PATCH] multiboot: set boot_device to first partition
@ 2011-04-28 14:11 Arun Thomas
2011-05-01 16:35 ` Stefan Hajnoczi
2011-06-03 20:33 ` Aurelien Jarno
0 siblings, 2 replies; 5+ messages in thread
From: Arun Thomas @ 2011-04-28 14:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Arun Thomas
The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, which
maps to the second primary partition. To specify the first primary partition,
'part1' should be set to 0x00, since partition numbers start from zero
according to the multiboot spec.
Signed-off-by: Arun Thomas <arun.thomas@gmail.com>
---
hw/multiboot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/multiboot.c b/hw/multiboot.c
index 394ed01..6e6cfb9 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -307,7 +307,7 @@ int load_multiboot(void *fw_cfg,
| MULTIBOOT_FLAGS_MMAP);
stl_p(bootinfo + MBI_MEM_LOWER, 640);
stl_p(bootinfo + MBI_MEM_UPPER, (ram_size / 1024) - 1024);
- stl_p(bootinfo + MBI_BOOT_DEVICE, 0x8001ffff); /* XXX: use the -boot switch? */
+ stl_p(bootinfo + MBI_BOOT_DEVICE, 0x8000ffff); /* XXX: use the -boot switch? */
stl_p(bootinfo + MBI_MMAP_ADDR, ADDR_E820_MAP);
mb_debug("multiboot: mh_entry_addr = %#x\n", mh_entry_addr);
--
tg: (d16e0f0..) bootdev (depends on: master)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] multiboot: set boot_device to first partition
2011-04-28 14:11 [Qemu-devel] [PATCH] multiboot: set boot_device to first partition Arun Thomas
@ 2011-05-01 16:35 ` Stefan Hajnoczi
2011-05-18 21:49 ` Arun Thomas
2011-06-03 20:33 ` Aurelien Jarno
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2011-05-01 16:35 UTC (permalink / raw)
To: Arun Thomas; +Cc: qemu-devel
On Thu, Apr 28, 2011 at 3:11 PM, Arun Thomas <arun.thomas@gmail.com> wrote:
> The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, which
> maps to the second primary partition. To specify the first primary partition,
> 'part1' should be set to 0x00, since partition numbers start from zero
> according to the multiboot spec.
>
> Signed-off-by: Arun Thomas <arun.thomas@gmail.com>
Which OSes have you tested? Xen? Solaris?
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] multiboot: set boot_device to first partition
2011-05-01 16:35 ` Stefan Hajnoczi
@ 2011-05-18 21:49 ` Arun Thomas
2011-05-19 8:17 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Arun Thomas @ 2011-05-18 21:49 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel
On Sun, May 1, 2011 at 6:35 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Thu, Apr 28, 2011 at 3:11 PM, Arun Thomas <arun.thomas@gmail.com> wrote:
>> The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, which
>> maps to the second primary partition. To specify the first primary partition,
>> 'part1' should be set to 0x00, since partition numbers start from zero
>> according to the multiboot spec.
>>
>> Signed-off-by: Arun Thomas <arun.thomas@gmail.com>
>
> Which OSes have you tested? Xen? Solaris?
I tested Solaris (OpenIndiana Build 148), and it boots fine. I haven't
been able to try Xen. Linux also boots fine, as expected.
Thanks,
Arun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] multiboot: set boot_device to first partition
2011-05-18 21:49 ` Arun Thomas
@ 2011-05-19 8:17 ` Stefan Hajnoczi
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2011-05-19 8:17 UTC (permalink / raw)
To: Arun Thomas; +Cc: qemu-devel
On Wed, May 18, 2011 at 11:49:26PM +0200, Arun Thomas wrote:
> On Sun, May 1, 2011 at 6:35 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Thu, Apr 28, 2011 at 3:11 PM, Arun Thomas <arun.thomas@gmail.com> wrote:
> >> The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, which
> >> maps to the second primary partition. To specify the first primary partition,
> >> 'part1' should be set to 0x00, since partition numbers start from zero
> >> according to the multiboot spec.
> >>
> >> Signed-off-by: Arun Thomas <arun.thomas@gmail.com>
> >
> > Which OSes have you tested? Xen? Solaris?
>
> I tested Solaris (OpenIndiana Build 148), and it boots fine. I haven't
> been able to try Xen. Linux also boots fine, as expected.
Okay, if Solaris boots that's a good sign. According to the spec your
change is correct, I think this patch should be applied.
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] multiboot: set boot_device to first partition
2011-04-28 14:11 [Qemu-devel] [PATCH] multiboot: set boot_device to first partition Arun Thomas
2011-05-01 16:35 ` Stefan Hajnoczi
@ 2011-06-03 20:33 ` Aurelien Jarno
1 sibling, 0 replies; 5+ messages in thread
From: Aurelien Jarno @ 2011-06-03 20:33 UTC (permalink / raw)
To: Arun Thomas; +Cc: qemu-devel
On Thu, Apr 28, 2011 at 04:11:11PM +0200, Arun Thomas wrote:
> The multiboot info struct's 'boot_device' field has 'part1' set to 0x01, which
> maps to the second primary partition. To specify the first primary partition,
> 'part1' should be set to 0x00, since partition numbers start from zero
> according to the multiboot spec.
>
> Signed-off-by: Arun Thomas <arun.thomas@gmail.com>
>
> ---
> hw/multiboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/hw/multiboot.c b/hw/multiboot.c
> index 394ed01..6e6cfb9 100644
> --- a/hw/multiboot.c
> +++ b/hw/multiboot.c
> @@ -307,7 +307,7 @@ int load_multiboot(void *fw_cfg,
> | MULTIBOOT_FLAGS_MMAP);
> stl_p(bootinfo + MBI_MEM_LOWER, 640);
> stl_p(bootinfo + MBI_MEM_UPPER, (ram_size / 1024) - 1024);
> - stl_p(bootinfo + MBI_BOOT_DEVICE, 0x8001ffff); /* XXX: use the -boot switch? */
> + stl_p(bootinfo + MBI_BOOT_DEVICE, 0x8000ffff); /* XXX: use the -boot switch? */
> stl_p(bootinfo + MBI_MMAP_ADDR, ADDR_E820_MAP);
>
> mb_debug("multiboot: mh_entry_addr = %#x\n", mh_entry_addr);
> --
> tg: (d16e0f0..) bootdev (depends on: master)
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-06-03 20:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-28 14:11 [Qemu-devel] [PATCH] multiboot: set boot_device to first partition Arun Thomas
2011-05-01 16:35 ` Stefan Hajnoczi
2011-05-18 21:49 ` Arun Thomas
2011-05-19 8:17 ` Stefan Hajnoczi
2011-06-03 20:33 ` Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.