All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
	"Juha Riihimäki" <juha.riihimaki@nokia.com>,
	qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about some writes to r/o registers
Date: Wed, 29 Jun 2011 21:39:52 +0100	[thread overview]
Message-ID: <BANLkTinYrJjx-yGNuesCd4xw47vXx-v_ew@mail.gmail.com> (raw)
In-Reply-To: <20110629200711.GA32548@laped.lan>

On 29 June 2011 21:07, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
> On Wed, Jun 29, 2011 at 07:53:10PM +0100, Peter Maydell wrote:
>> Don't complain about some writes to r/o OMAP2 GPIO registers, because the
>> kernel will do them anyway.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Hi Peter,
>
> I usually find this kind of logs useful.
> Maybe we should turn them into _log_mask(~0, xxx) so they only come out
> when -d is enabled?

I think the ideal would be to have all of this kind of message go
through some consistent path (ie not just printf) so you could
tell all of qemu "I'm doing OS development, warn about things which
indicate driver bugs" vs the more common "I'm just a user and I
don't really care".

You'd also want to be able to trace the guest program counter
and to do things like drop into gdb if running with the gdb stub
enabled.

In the absence of that kind of infrastructure I tend to default
to removing this kind of printf or relegating it to DPRINTF.

-- PMM

  reply	other threads:[~2011-06-29 20:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 18:53 [Qemu-devel] [PATCH 0/3] omap_gpio: convert to qdev Peter Maydell
2011-06-29 18:53 ` [Qemu-devel] [PATCH 1/3] hw/omap_l4.c: Add helper function omap_l4_base Peter Maydell
2011-06-29 18:53 ` [Qemu-devel] [PATCH 2/3] hw/omap_gpio.c: Don't complain about some writes to r/o registers Peter Maydell
2011-06-29 20:07   ` Edgar E. Iglesias
2011-06-29 20:39     ` Peter Maydell [this message]
2011-06-29 20:49       ` Edgar E. Iglesias
2011-06-29 18:53 ` [Qemu-devel] [PATCH 3/3] hw/omap_gpio.c: Convert to qdev Peter Maydell
2011-07-04 22:39   ` andrzej zaborowski
2011-07-05 13:19     ` Peter Maydell
2011-07-07 15:29       ` andrzej zaborowski
2011-07-07 16:00         ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinYrJjx-yGNuesCd4xw47vXx-v_ew@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=edgar.iglesias@gmail.com \
    --cc=juha.riihimaki@nokia.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.