All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@laptop.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-acpi@vger.kernel.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, dilinger@queued.net
Subject: Re: [PATCH 11/11] x86, olpc: Add XO-1.5 SCI driver
Date: Tue, 24 May 2011 22:52:07 +0100	[thread overview]
Message-ID: <BANLkTinnL2KLGQXcA_St3QLggpoiBw_pgg@mail.gmail.com> (raw)
In-Reply-To: <20110516092429.GC26487@linutronix.de>

On 16 May 2011 10:24, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> * Daniel Drake | 2011-04-30 13:32:30 [+0100]:
>
>>+static DECLARE_WORK(sci_work, process_sci_queue_work);
>>+
>>+static u32 xo15_sci_gpe_handler(acpi_handle gpe_device, u32 gpe, void *context)
>>+{
>>+      schedule_work(&sci_work);
>>+      return ACPI_INTERRUPT_HANDLED | ACPI_REENABLE_GPE;
>>+}
>
> I know this is too much to ask but acpi_install_gpe_handler() looks like
> a custom irq demultiplexor which lacks the support for threaded irqs.

Thanks for looking at the patch.

I guess you mean that ACPI should hide all this behind an irq_chip
abstraction. I had a quick look at doing this but not being very
familiar with ACPI nor irq_chip I don't think I'm the right person for
the task. Hopefully it is not seen as a merge requirement...

CCing ACPI list for comments.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Drake <dsd@laptop.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	linux-acpi@vger.kernel.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, dilinger@queued.net
Subject: Re: [PATCH 11/11] x86, olpc: Add XO-1.5 SCI driver
Date: Tue, 24 May 2011 22:52:07 +0100	[thread overview]
Message-ID: <BANLkTinnL2KLGQXcA_St3QLggpoiBw_pgg@mail.gmail.com> (raw)
In-Reply-To: <20110516092429.GC26487@linutronix.de>

On 16 May 2011 10:24, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> * Daniel Drake | 2011-04-30 13:32:30 [+0100]:
>
>>+static DECLARE_WORK(sci_work, process_sci_queue_work);
>>+
>>+static u32 xo15_sci_gpe_handler(acpi_handle gpe_device, u32 gpe, void *context)
>>+{
>>+      schedule_work(&sci_work);
>>+      return ACPI_INTERRUPT_HANDLED | ACPI_REENABLE_GPE;
>>+}
>
> I know this is too much to ask but acpi_install_gpe_handler() looks like
> a custom irq demultiplexor which lacks the support for threaded irqs.

Thanks for looking at the patch.

I guess you mean that ACPI should hide all this behind an irq_chip
abstraction. I had a quick look at doing this but not being very
familiar with ACPI nor irq_chip I don't think I'm the right person for
the task. Hopefully it is not seen as a merge requirement...

CCing ACPI list for comments.

Daniel

  reply	other threads:[~2011-05-24 21:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-30 12:32 [PATCH 0/11] OLPC Power Management Daniel Drake
2011-04-30 12:32 ` [PATCH 01/11] x86, olpc: add missing elements to device tree Daniel Drake
2011-04-30 12:32   ` Daniel Drake
2011-04-30 12:32 ` [PATCH 02/11] x86, olpc: Move CS5536-related constants to cs5535.h Daniel Drake
2011-04-30 12:32 ` [PATCH 03/11] x86, olpc: rename olpc-xo1 to olpc-xo1-pm Daniel Drake
2011-04-30 12:32 ` [PATCH 04/11] x86, olpc: Add XO-1 suspend/resume support Daniel Drake
2011-04-30 12:32 ` [PATCH 05/11] x86, olpc: Add XO-1 SCI driver and power button control Daniel Drake
2011-04-30 12:32 ` [PATCH 06/11] x86, olpc: EC SCI wakeup mask functionality Daniel Drake
2011-04-30 12:32 ` [PATCH 07/11] x86, olpc-xo1-sci: Add GPE handler and ebook switch functionality Daniel Drake
2011-05-16  9:08   ` Sebastian Andrzej Siewior
2011-05-16 16:07     ` Andres Salomon
2011-05-24 21:40     ` Daniel Drake
2011-05-31 11:28       ` Sebastian Andrzej Siewior
2011-05-31 20:48         ` Daniel Drake
2011-06-09  0:25           ` Andres Salomon
2011-04-30 12:32 ` [PATCH 08/11] x86, olpc-xo1-sci: Add lid " Daniel Drake
2011-04-30 12:32 ` [PATCH 09/11] x86, olpc-xo1-sci: Propagate power supply/battery events Daniel Drake
2011-04-30 12:32 ` [PATCH 10/11] x86, olpc: Add XO-1 RTC driver Daniel Drake
2011-05-16  9:18   ` Sebastian Andrzej Siewior
2011-05-16  9:18     ` Sebastian Andrzej Siewior
2011-05-19 19:35   ` Grant Likely
2011-04-30 12:32 ` [PATCH 11/11] x86, olpc: Add XO-1.5 SCI driver Daniel Drake
2011-05-16  9:24   ` Sebastian Andrzej Siewior
2011-05-24 21:52     ` Daniel Drake [this message]
2011-05-24 21:52       ` Daniel Drake
2011-04-30 17:07 ` [PATCH 0/11] OLPC Power Management Andres Salomon
2011-05-14 19:09   ` Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinnL2KLGQXcA_St3QLggpoiBw_pgg@mail.gmail.com \
    --to=dsd@laptop.org \
    --cc=bigeasy@linutronix.de \
    --cc=dilinger@queued.net \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.