* [PATCH] brd: make brd_make_request() return error code
@ 2011-06-03 5:02 Eric Miao
2011-06-03 14:38 ` Eric Miao
2011-06-07 3:30 ` Eric Miao
0 siblings, 2 replies; 3+ messages in thread
From: Eric Miao @ 2011-06-03 5:02 UTC (permalink / raw)
To: linux-kernel; +Cc: Eric Miao
brd_make_request() always returns 0, which doesn't make much sense.
Signed-off-by: Eric Miao <eric.miao@linaro.org>
---
drivers/block/brd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index dba1c32..a9587ee 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -360,7 +360,7 @@ static int brd_make_request(struct request_queue *q, struct bio *bio)
out:
bio_endio(bio, err);
- return 0;
+ return err;
}
#ifdef CONFIG_BLK_DEV_XIP
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] brd: make brd_make_request() return error code
2011-06-03 5:02 [PATCH] brd: make brd_make_request() return error code Eric Miao
@ 2011-06-03 14:38 ` Eric Miao
2011-06-07 3:30 ` Eric Miao
1 sibling, 0 replies; 3+ messages in thread
From: Eric Miao @ 2011-06-03 14:38 UTC (permalink / raw)
To: linux-kernel; +Cc: Nick Piggin
On Fri, Jun 3, 2011 at 1:02 PM, Eric Miao <eric.miao@linaro.org> wrote:
> brd_make_request() always returns 0, which doesn't make much sense.
>
> Signed-off-by: Eric Miao <eric.miao@linaro.org>
> ---
> drivers/block/brd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index dba1c32..a9587ee 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -360,7 +360,7 @@ static int brd_make_request(struct request_queue *q, struct bio *bio)
> out:
> bio_endio(bio, err);
>
> - return 0;
> + return err;
> }
>
> #ifdef CONFIG_BLK_DEV_XIP
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] brd: make brd_make_request() return error code
2011-06-03 5:02 [PATCH] brd: make brd_make_request() return error code Eric Miao
2011-06-03 14:38 ` Eric Miao
@ 2011-06-07 3:30 ` Eric Miao
1 sibling, 0 replies; 3+ messages in thread
From: Eric Miao @ 2011-06-07 3:30 UTC (permalink / raw)
To: linux-kernel; +Cc: Nick Piggin
On Fri, Jun 3, 2011 at 1:02 PM, Eric Miao <eric.miao@linaro.org> wrote:
> brd_make_request() always returns 0, which doesn't make much sense.
>
> Signed-off-by: Eric Miao <eric.miao@linaro.org>
> ---
> drivers/block/brd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index dba1c32..a9587ee 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -360,7 +360,7 @@ static int brd_make_request(struct request_queue *q, struct bio *bio)
> out:
> bio_endio(bio, err);
>
> - return 0;
> + return err;
> }
>
> #ifdef CONFIG_BLK_DEV_XIP
> --
> 1.7.4.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-07 3:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-03 5:02 [PATCH] brd: make brd_make_request() return error code Eric Miao
2011-06-03 14:38 ` Eric Miao
2011-06-07 3:30 ` Eric Miao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.