[PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24

[PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24

[Damian Hobson-Garcia]

The ordering of the bytes in the 24 bpp RGB colour mode was
being set to BGR.

This now matches the values returned in the
struct fb_var_screeninfo .red, .green, and .blue offsets as well as
the output format of other blocs, such as the VEU

Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
---
 drivers/video/sh_mobile_lcdcfb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
index 04f2260..a442471 100644
--- a/drivers/video/sh_mobile_lcdcfb.c
+++ b/drivers/video/sh_mobile_lcdcfb.c
@@ -590,7 +590,7 @@ static int sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
 				tmp |= 0x03;
 				break;
 			case 24:
-				tmp |= 0x0b;
+				tmp |= 0x02;
 				break;
 			case 32:
 				break;
@@ -1178,7 +1178,7 @@ static int sh_mobile_lcdc_set_bpp(struct fb_var_screeninfo *var, int bpp,
 		var->transp.length = 0;
 		break;
 
-	case 24: /* PKF[4:0] = 01011 - RGB 888 */
+	case 24: /* PKF[4:0] = 00010 - RGB 888 */
 		var->red.offset = 16;
 		var->red.length = 8;
 		var->green.offset = 8;
-- 
1.7.1

Re: [PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24

[Magnus Damm]

Hi Damian,

On Thu, May 26, 2011 at 6:09 PM, Damian Hobson-Garcia
<dhobsong@igel.co.jp> wrote:
> The ordering of the bytes in the 24 bpp RGB colour mode was
> being set to BGR.
>
> This now matches the values returned in the
> struct fb_var_screeninfo .red, .green, and .blue offsets as well as
> the output format of other blocs, such as the VEU
>
> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
> ---

Thanks for your patch. With this change in place, is the fbdev console
still working as expected?

Also, the byte swap settings in _LDDDSR are ok as-is?

Thanks,

/ magnus

Re: [PATCH] fbdev: sh_mobile_lcdcfb: Change BGR24 to RGB24

[Damian Hobson-Garcia]

Hi Magnus,
On 2011/05/27 17:14, Magnus Damm wrote:
> Hi Damian,
> 
> On Thu, May 26, 2011 at 6:09 PM, Damian Hobson-Garcia
> <dhobsong@igel.co.jp> wrote:
>> The ordering of the bytes in the 24 bpp RGB colour mode was
>> being set to BGR.
>>
>> This now matches the values returned in the
>> struct fb_var_screeninfo .red, .green, and .blue offsets as well as
>> the output format of other blocs, such as the VEU
>>
>> Signed-off-by: Damian Hobson-Garcia <dhobsong@igel.co.jp>
>> ---
> 
> Thanks for your patch. With this change in place, is the fbdev console
> still working as expected?
> 
> Also, the byte swap settings in _LDDDSR are ok as-is?
Actually, let me look into this a bit more.  After thinking about it
some more there are one or two more things I want to check on this
first.  Please ignore this patch for now.  I'll resubmit it again once
its properly completed. Sorry for the mess.

Thanks,
Damian