* [PATCH] ARM: armv6 & armv7 no need update SCTLR for alignment
@ 2014-04-24 1:32 ` Wuqixuan
0 siblings, 0 replies; 2+ messages in thread
From: Wuqixuan @ 2014-04-24 1:32 UTC (permalink / raw)
To: linux, linux-arm-kernel; +Cc: linux-kernel, Lizefan, qixuan wu
Now in the code, when interrupt and exception disturbs the user-space, always
update SCTLR with cr_alignment. In our ARMv7 Cortex A15 SOC, the statements
bracketed by CONFIG_ALIGNMENT_TRAP need about 100 cycles. it impacts our
high realtime interrupt requirement scenario. Considering in ARMv6 and ARMv7
versions, cr_alignment and cr_no_alignment are always same without A bit,
they are initialized by clearing A bit in alignment_init. So there is no
need to update SCTLR if interrupt and exception disturbs the user-space
in vector_swi function or alignment_trap macro, in the ARMv6 and ARMv7 chip.
The patch has already verified in our ARMv7 Cortex A15 SOC.
Signed-off-by: Wuqixuan <wuqixuan@huawei.com>
---
arch/arm/kernel/entry-common.S | 4 ++--
| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index a2dcafd..4b7686a 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -366,7 +366,7 @@ ENTRY(vector_swi)
#endif
zero_fp
-#ifdef CONFIG_ALIGNMENT_TRAP
+#if defined(CONFIG_ALIGNMENT_TRAP) && !(__LINUX_ARM_ARCH__ >= 6)
ldr ip, __cr_alignment
ldr ip, [ip]
mcr p15, 0, ip, c1, c0 @ update control register
@@ -490,7 +490,7 @@ __sys_trace_return:
b ret_slow_syscall
.align 5
-#ifdef CONFIG_ALIGNMENT_TRAP
+#if defined(CONFIG_ALIGNMENT_TRAP) && !(__LINUX_ARM_ARCH__ >= 6)
.type __cr_alignment, #object
__cr_alignment:
.word cr_alignment
--git a/arch/arm/kernel/entry-header.S b/arch/arm/kernel/entry-header.S
index 1420725..5eb9e59 100644
--- a/arch/arm/kernel/entry-header.S
+++ b/arch/arm/kernel/entry-header.S
@@ -38,7 +38,7 @@
.endm
.macro alignment_trap, rtemp
-#ifdef CONFIG_ALIGNMENT_TRAP
+#if defined(CONFIG_ALIGNMENT_TRAP) && !(__LINUX_ARM_ARCH__ >= 6)
ldr \rtemp, .LCcralign
ldr \rtemp, [\rtemp]
mcr p15, 0, \rtemp, c1, c0
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: armv6 & armv7 no need update SCTLR for alignment
@ 2014-04-24 1:32 ` Wuqixuan
0 siblings, 0 replies; 2+ messages in thread
From: Wuqixuan @ 2014-04-24 1:32 UTC (permalink / raw)
To: linux-arm-kernel
Now in the code, when interrupt and exception disturbs the user-space, always
update SCTLR with cr_alignment. In our ARMv7 Cortex A15 SOC, the statements
bracketed by CONFIG_ALIGNMENT_TRAP need about 100 cycles. it impacts our
high realtime interrupt requirement scenario. Considering in ARMv6 and ARMv7
versions, cr_alignment and cr_no_alignment are always same without A bit,
they are initialized by clearing A bit in alignment_init. So there is no
need to update SCTLR if interrupt and exception disturbs the user-space
in vector_swi function or alignment_trap macro, in the ARMv6 and ARMv7 chip.
The patch has already verified in our ARMv7 Cortex A15 SOC.
Signed-off-by: Wuqixuan <wuqixuan@huawei.com>
---
arch/arm/kernel/entry-common.S | 4 ++--
| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index a2dcafd..4b7686a 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -366,7 +366,7 @@ ENTRY(vector_swi)
#endif
zero_fp
-#ifdef CONFIG_ALIGNMENT_TRAP
+#if defined(CONFIG_ALIGNMENT_TRAP) && !(__LINUX_ARM_ARCH__ >= 6)
ldr ip, __cr_alignment
ldr ip, [ip]
mcr p15, 0, ip, c1, c0 @ update control register
@@ -490,7 +490,7 @@ __sys_trace_return:
b ret_slow_syscall
.align 5
-#ifdef CONFIG_ALIGNMENT_TRAP
+#if defined(CONFIG_ALIGNMENT_TRAP) && !(__LINUX_ARM_ARCH__ >= 6)
.type __cr_alignment, #object
__cr_alignment:
.word cr_alignment
--git a/arch/arm/kernel/entry-header.S b/arch/arm/kernel/entry-header.S
index 1420725..5eb9e59 100644
--- a/arch/arm/kernel/entry-header.S
+++ b/arch/arm/kernel/entry-header.S
@@ -38,7 +38,7 @@
.endm
.macro alignment_trap, rtemp
-#ifdef CONFIG_ALIGNMENT_TRAP
+#if defined(CONFIG_ALIGNMENT_TRAP) && !(__LINUX_ARM_ARCH__ >= 6)
ldr \rtemp, .LCcralign
ldr \rtemp, [\rtemp]
mcr p15, 0, \rtemp, c1, c0
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-24 1:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-24 1:32 [PATCH] ARM: armv6 & armv7 no need update SCTLR for alignment Wuqixuan
2014-04-24 1:32 ` Wuqixuan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.