[PATCH 1/1] kmod: fix installation path of pkgconfig files

[PATCH 1/1] kmod: fix installation path of pkgconfig files

[Otavio Salvador]

The pkgconfig files need to be installed in ${libdir} instead of
${base_libdir}.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-kernel/kmod/kmod_git.bb |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
index d9c4d8b..7b4a45a 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -3,7 +3,7 @@
 
 require kmod.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 PROVIDES += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
 RPROVIDES_${PN} += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
@@ -34,6 +34,10 @@ do_install_append () {
 
         # install depmod.d file for search/ dir
         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
+
+		# fix pkgconfig installation path
+		install -dm755 ${D}${libdir}
+		mv ${D}${base_libdir}/pkgconfig ${D}{libdir}
 }
 
 pkg_postinst_kmod() {
-- 
1.7.2.5

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Koen Kooi]

Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:

> The pkgconfig files need to be installed in ${libdir} instead of
> ${base_libdir}.

Thanks for the patch, I was working on something similar :) I talked with the kmod and udev people and they asked why we want kmod libs in /lib instead of /usr/lib. I didn't have an answer to that, does anyone else have a decent one? If not, let's not mess with $prefix and remove all the do_install changes.

regards,

Koen

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Otavio Salvador]

On Mon, May 14, 2012 at 11:06 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:
>
>> The pkgconfig files need to be installed in ${libdir} instead of
>> ${base_libdir}.
>
> Thanks for the patch, I was working on something similar :) I talked with the kmod and udev people and they asked why we want kmod libs in /lib instead of /usr/lib. I didn't have an answer to that, does anyone else have a decent one? If not, let's not mess with $prefix and remove all the do_install changes.

OE-Core try to allow the use of /usr in a separated partition so it
seems it is a requirement for it to work in initrdless systems.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[PATCH 1/1] kmod: fix installation path of pkgconfig files

[Otavio Salvador]

The pkgconfig files need to be installed in ${libdir} instead of
${base_libdir}.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-kernel/kmod/kmod_git.bb |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
index d9c4d8b..a4a284e 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -3,7 +3,7 @@
 
 require kmod.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 PROVIDES += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
 RPROVIDES_${PN} += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
@@ -34,6 +34,10 @@ do_install_append () {
 
         # install depmod.d file for search/ dir
         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
+
+        # fix pkgconfig installation path
+        install -dm755 ${D}${libdir}
+        mv ${D}${base_libdir}/pkgconfig ${D}${libdir}
 }
 
 pkg_postinst_kmod() {
-- 
1.7.2.5

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Otavio Salvador]

On Mon, May 14, 2012 at 3:30 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The pkgconfig files need to be installed in ${libdir} instead of
> ${base_libdir}.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

This patch is near but still doesn't  work as expected. I am working on that.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Richard Purdie]

On Mon, 2012-05-14 at 12:24 -0300, Otavio Salvador wrote:
> On Mon, May 14, 2012 at 11:06 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> >
> > Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:
> >
> >> The pkgconfig files need to be installed in ${libdir} instead of
> >> ${base_libdir}.
> >
> > Thanks for the patch, I was working on something similar :) I talked
> with the kmod and udev people and they asked why we want kmod libs
> in /lib instead of /usr/lib. I didn't have an answer to that, does
> anyone else have a decent one? If not, let's not mess with $prefix and
> remove all the do_install changes.
> 
> OE-Core try to allow the use of /usr in a separated partition so it
> seems it is a requirement for it to work in initrdless systems.

I've heard requests from people that / be bootable with /usr being
mounted later. For something like kmod, there is therefore a case for
putting the library in base_libdir, not libdir. Not doing so sounds like
a bit of a cop-out from the maintainers.

Cheers,

Richard

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Koen Kooi]

Op 15 mei 2012, om 19:55 heeft Richard Purdie het volgende geschreven:

> On Mon, 2012-05-14 at 12:24 -0300, Otavio Salvador wrote:
>> On Mon, May 14, 2012 at 11:06 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>> 
>>> Op 14 mei 2012, om 15:47 heeft Otavio Salvador het volgende geschreven:
>>> 
>>>> The pkgconfig files need to be installed in ${libdir} instead of
>>>> ${base_libdir}.
>>> 
>>> Thanks for the patch, I was working on something similar :) I talked
>> with the kmod and udev people and they asked why we want kmod libs
>> in /lib instead of /usr/lib. I didn't have an answer to that, does
>> anyone else have a decent one? If not, let's not mess with $prefix and
>> remove all the do_install changes.
>> 
>> OE-Core try to allow the use of /usr in a separated partition so it
>> seems it is a requirement for it to work in initrdless systems.
> 
> I've heard requests from people that / be bootable with /usr being
> mounted later. For something like kmod, there is therefore a case for
> putting the library in base_libdir, not libdir. Not doing so sounds like
> a bit of a cop-out from the maintainers.

Good luck with booting a split /usr without udev. Can we *please* get the .pc in the right place so udev builds before trying to fix pie-in-the-sky things like split /usr?

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Khem Raj]

On Tue, May 15, 2012 at 10:55 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> I've heard requests from people that / be bootable with /usr being
> mounted later. For something like kmod, there is therefore a case for
> putting the library in base_libdir, not libdir. Not doing so sounds like
> a bit of a cop-out from the maintainers.

I think this should not be made so mandatory in OE-Core IMO since none of modern
systems would do something like that.

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Otavio Salvador]

On Tue, May 15, 2012 at 5:55 PM, Khem Raj <raj.khem@gmail.com> wrote:
> I think this should not be made so mandatory in OE-Core IMO since none of modern
> systems would do something like that.

I agree with you Khem; I think that systems that require this ought to
use a initramfs or initrd image for it. I see no it as not worth to
support it and the amount of hassle to support it is not worth it.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

Yes. I need this too. Hope it will make it soon.
On May 17, 2012 10:49 AM, "Koen Kooi" <koen@dominion.thruhere.net> wrote:

>
> Op 15 mei 2012, om 22:39 heeft Otavio Salvador het volgende geschreven:
>
> > The pkgconfig files need to be installed in ${libdir} instead of
> > ${base_libdir}.
> >
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Acked-by: Koen Kooi <koen@dominion.thruhere.net>
>
> Udev have been broken for a week now, can this please to in ASAP?
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 1254 bytes --]

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Koen Kooi]

Op 15 mei 2012, om 22:39 heeft Otavio Salvador het volgende geschreven:

> The pkgconfig files need to be installed in ${libdir} instead of
> ${base_libdir}.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Acked-by: Koen Kooi <koen@dominion.thruhere.net>

Udev have been broken for a week now, can this please to in ASAP?

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Otavio Salvador]

On Tue, May 15, 2012 at 5:58 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Tue, May 15, 2012 at 1:39 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> The pkgconfig files need to be installed in ${libdir} instead of
>> ${base_libdir}.
>
> Looks ok to me

As discussed on IRC we ought to move the .so file to ${libdir}; I am
busy at work fixing other stuff to support gcc 4.7 and cannot work on
that now but will look at it later.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [PATCH 1/1] kmod: fix installation path of pkgconfig files

[Khem Raj]

On Tue, May 15, 2012 at 1:39 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The pkgconfig files need to be installed in ${libdir} instead of
> ${base_libdir}.
>


Looks ok to me


> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  meta/recipes-kernel/kmod/kmod_git.bb |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
> index d9c4d8b..11dfe57 100644
> --- a/meta/recipes-kernel/kmod/kmod_git.bb
> +++ b/meta/recipes-kernel/kmod/kmod_git.bb
> @@ -3,7 +3,7 @@
>
>  require kmod.inc
>
> -PR = "${INC_PR}.1"
> +PR = "${INC_PR}.2"
>
>  PROVIDES += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
>  RPROVIDES_${PN} += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
> @@ -16,7 +16,8 @@ RCONFLICTS_libkmod2 += "module-init-tools-insmod-static module-init-tools-depmod
>  # autotools set prefix to /usr, however we want them in /bin and /sbin
>  bindir = "${base_bindir}"
>  sbindir = "${base_sbindir}"
> -libdir = "${base_libdir}"
> +
> +EXTRA_OECONF += "--libdir=${base_libdir}"
>
>  do_install_append () {
>         install -dm755 ${D}${base_bindir}
> @@ -34,6 +35,10 @@ do_install_append () {
>
>         # install depmod.d file for search/ dir
>         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
> +
> +        # fix pkgconfig installation path
> +        install -dm755 ${D}${libdir}
> +        mv ${D}${base_libdir}/pkgconfig ${D}${libdir}
>  }
>
>  pkg_postinst_kmod() {
> @@ -59,4 +64,5 @@ pkg_prerm_kmod() {
>  PACKAGES =+ "libkmod"
>
>  FILES_libkmod = "${base_libdir}/libkmod*${SOLIBS} ${libdir}/libkmod*${SOLIBS}"
> +FILES_${PN}-dev += "${base_libdir}/libkmod*${SOLIBSDEV} ${base_libdir}/*.la"
>  FILES_${PN} += "${base_libdir}/depmod.d ${base_libdir}/modprobe.d"
> --
> 1.7.2.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

[PATCH 1/1] kmod: fix installation path of pkgconfig files

[Otavio Salvador]

The pkgconfig files need to be installed in ${libdir} instead of
${base_libdir}.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-kernel/kmod/kmod_git.bb |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
index d9c4d8b..11dfe57 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -3,7 +3,7 @@
 
 require kmod.inc
 
-PR = "${INC_PR}.1"
+PR = "${INC_PR}.2"
 
 PROVIDES += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
 RPROVIDES_${PN} += "module-init-tools-insmod-static module-init-tools-depmod module-init-tools"
@@ -16,7 +16,8 @@ RCONFLICTS_libkmod2 += "module-init-tools-insmod-static module-init-tools-depmod
 # autotools set prefix to /usr, however we want them in /bin and /sbin
 bindir = "${base_bindir}"
 sbindir = "${base_sbindir}"
-libdir = "${base_libdir}"
+
+EXTRA_OECONF += "--libdir=${base_libdir}"
 
 do_install_append () {
         install -dm755 ${D}${base_bindir}
@@ -34,6 +35,10 @@ do_install_append () {
 
         # install depmod.d file for search/ dir
         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
+
+        # fix pkgconfig installation path
+        install -dm755 ${D}${libdir}
+        mv ${D}${base_libdir}/pkgconfig ${D}${libdir}
 }
 
 pkg_postinst_kmod() {
@@ -59,4 +64,5 @@ pkg_prerm_kmod() {
 PACKAGES =+ "libkmod"
 
 FILES_libkmod = "${base_libdir}/libkmod*${SOLIBS} ${libdir}/libkmod*${SOLIBS}"
+FILES_${PN}-dev += "${base_libdir}/libkmod*${SOLIBSDEV} ${base_libdir}/*.la"
 FILES_${PN} += "${base_libdir}/depmod.d ${base_libdir}/modprobe.d"
-- 
1.7.2.5