* RE: minor bug on these three macros for mesh
@ 2012-11-06 21:46 Chaoxing Lin
0 siblings, 0 replies; 3+ messages in thread
From: Chaoxing Lin @ 2012-11-06 21:46 UTC (permalink / raw)
To: linux-wireless
Should be two not three.
disc_timeout_jiff()
root_path_confirmation_jiffies()
-----Original Message-----
From: Chaoxing Lin
Sent: Tuesday, November 06, 2012 4:44 PM
To: linux-wireless@vger.kernel.org
Subject: minor bug on these three macros for mesh
Net/mac80211/mesh_hwmp.c
#define max_preq_retries(s) (s->u.mesh.mshcfg.dot11MeshHWMPmaxPREQretries)
#define disc_timeout_jiff(s) \
msecs_to_jiffies(sdata->u.mesh.mshcfg.min_discovery_timeout)
#define root_path_confirmation_jiffies(s) \
msecs_to_jiffies(sdata->u.mesh.mshcfg.dot11MeshHWMPconfirmationInterval)
The "sdata" in these 3 macros should be "s".
For now, code just happens to work since caller always passes in "sdata"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: minor bug on these three macros for mesh
2012-11-06 21:43 Chaoxing Lin
@ 2012-11-06 22:12 ` Johannes Berg
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2012-11-06 22:12 UTC (permalink / raw)
To: Chaoxing Lin; +Cc: linux-wireless
On Tue, 2012-11-06 at 21:43 +0000, Chaoxing Lin wrote:
> Net/mac80211/mesh_hwmp.c
>
> #define max_preq_retries(s) (s->u.mesh.mshcfg.dot11MeshHWMPmaxPREQretries)
> #define disc_timeout_jiff(s) \
> msecs_to_jiffies(sdata->u.mesh.mshcfg.min_discovery_timeout)
> #define root_path_confirmation_jiffies(s) \
> msecs_to_jiffies(sdata->u.mesh.mshcfg.dot11MeshHWMPconfirmationInterval)
>
>
> The "sdata" in these 3 macros should be "s".
> For now, code just happens to work since caller always passes in "sdata"
They should probably all just be static inlines, care to send a patch?
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* minor bug on these three macros for mesh
@ 2012-11-06 21:43 Chaoxing Lin
2012-11-06 22:12 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Chaoxing Lin @ 2012-11-06 21:43 UTC (permalink / raw)
To: linux-wireless
Net/mac80211/mesh_hwmp.c
#define max_preq_retries(s) (s->u.mesh.mshcfg.dot11MeshHWMPmaxPREQretries)
#define disc_timeout_jiff(s) \
msecs_to_jiffies(sdata->u.mesh.mshcfg.min_discovery_timeout)
#define root_path_confirmation_jiffies(s) \
msecs_to_jiffies(sdata->u.mesh.mshcfg.dot11MeshHWMPconfirmationInterval)
The "sdata" in these 3 macros should be "s".
For now, code just happens to work since caller always passes in "sdata"
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-06 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-06 21:46 minor bug on these three macros for mesh Chaoxing Lin
-- strict thread matches above, loose matches on Subject: below --
2012-11-06 21:43 Chaoxing Lin
2012-11-06 22:12 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.