* [PATCH] rust: delete rust-project.json when running make clean
@ 2023-02-03 17:37 Maíra Canal
2023-02-03 20:08 ` Miguel Ojeda
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Maíra Canal @ 2023-02-03 17:37 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek, Nick Desaulniers, Miguel Ojeda,
Alex Gaynor, Wedson Almeida Filho, Boqun Feng, Gary Guo,
Björn Roy Baron
Cc: Melissa Wen, linux-kbuild, rust-for-linux, Maíra Canal
rust-project.json is the configuration file used by rust-analyzer.
As it is a configuration file and it is not needed to build external
modules, it should be delete by make clean. So, delete rust-project.json
when running make clean.
Link: https://github.com/Rust-for-Linux/linux/issues/939
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index f41ec8c8426b..6223d5f82f66 100644
--- a/Makefile
+++ b/Makefile
@@ -1573,7 +1573,7 @@ endif # CONFIG_MODULES
CLEAN_FILES += include/ksym vmlinux.symvers modules-only.symvers \
modules.builtin modules.builtin.modinfo modules.nsdeps \
compile_commands.json .thinlto-cache rust/test rust/doc \
- .vmlinux.objs .vmlinux.export.c
+ rust-project.json .vmlinux.objs .vmlinux.export.c
# Directories & files removed with 'make mrproper'
MRPROPER_FILES += include/config include/generated \
--
2.39.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-03 17:37 [PATCH] rust: delete rust-project.json when running make clean Maíra Canal
@ 2023-02-03 20:08 ` Miguel Ojeda
2023-02-03 20:27 ` Björn Roy Baron
2023-02-04 17:59 ` Masahiro Yamada
2023-02-04 10:12 ` Finn Behrens
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Miguel Ojeda @ 2023-02-03 20:08 UTC (permalink / raw)
To: Maíra Canal, Björn Roy Baron
Cc: Masahiro Yamada, Michal Marek, Nick Desaulniers, Miguel Ojeda,
Alex Gaynor, Wedson Almeida Filho, Boqun Feng, Gary Guo,
Melissa Wen, linux-kbuild, rust-for-linux
On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal <mcanal@igalia.com> wrote:
>
> rust-project.json is the configuration file used by rust-analyzer.
> As it is a configuration file and it is not needed to build external
> modules, it should be delete by make clean. So, delete rust-project.json
> when running make clean.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/939
Thanks Maíra! I will add a tag with Björn as a `Suggested-by`, if he
is OK with that.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-03 20:08 ` Miguel Ojeda
@ 2023-02-03 20:27 ` Björn Roy Baron
2023-02-04 17:59 ` Masahiro Yamada
1 sibling, 0 replies; 9+ messages in thread
From: Björn Roy Baron @ 2023-02-03 20:27 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Maíra Canal, Masahiro Yamada, Michal Marek,
Nick Desaulniers, Miguel Ojeda, Alex Gaynor,
Wedson Almeida Filho, Boqun Feng, Gary Guo, Melissa Wen,
linux-kbuild, rust-for-linux
On Friday, February 3rd, 2023 at 21:08, Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal mcanal@igalia.com wrote:
>
> > rust-project.json is the configuration file used by rust-analyzer.
> > As it is a configuration file and it is not needed to build external
> > modules, it should be delete by make clean. So, delete rust-project.json
> > when running make clean.
> >
> > Link: https://github.com/Rust-for-Linux/linux/issues/939
>
>
> Thanks Maíra! I will add a tag with Björn as a `Suggested-by`, if he
> is OK with that.
>
> Cheers,
> Miguel
Sure
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-03 17:37 [PATCH] rust: delete rust-project.json when running make clean Maíra Canal
2023-02-03 20:08 ` Miguel Ojeda
@ 2023-02-04 10:12 ` Finn Behrens
2023-02-04 18:41 ` Vincenzo Palazzo
2023-02-05 0:18 ` Miguel Ojeda
3 siblings, 0 replies; 9+ messages in thread
From: Finn Behrens @ 2023-02-04 10:12 UTC (permalink / raw)
To: Maíra Canal
Cc: Masahiro Yamada, Michal Marek, Nick Desaulniers, Miguel Ojeda,
Alex Gaynor, Wedson Almeida Filho, Boqun Feng, Gary Guo,
Björn Roy Baron, Melissa Wen, linux-kbuild, rust-for-linux
On 3 Feb 2023, at 18:37, Maíra Canal wrote:
> rust-project.json is the configuration file used by rust-analyzer.
> As it is a configuration file and it is not needed to build external
> modules, it should be delete by make clean. So, delete rust-project.json
> when running make clean.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/939
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Finn Behrens <fin@nyantec.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f41ec8c8426b..6223d5f82f66 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1573,7 +1573,7 @@ endif # CONFIG_MODULES
> CLEAN_FILES += include/ksym vmlinux.symvers modules-only.symvers \
> modules.builtin modules.builtin.modinfo modules.nsdeps \
> compile_commands.json .thinlto-cache rust/test rust/doc \
> - .vmlinux.objs .vmlinux.export.c
> + rust-project.json .vmlinux.objs .vmlinux.export.c
>
> # Directories & files removed with 'make mrproper'
> MRPROPER_FILES += include/config include/generated \
> --
> 2.39.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-03 20:08 ` Miguel Ojeda
2023-02-03 20:27 ` Björn Roy Baron
@ 2023-02-04 17:59 ` Masahiro Yamada
2023-02-04 18:04 ` Miguel Ojeda
1 sibling, 1 reply; 9+ messages in thread
From: Masahiro Yamada @ 2023-02-04 17:59 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Maíra Canal, Björn Roy Baron, Michal Marek,
Nick Desaulniers, Miguel Ojeda, Alex Gaynor,
Wedson Almeida Filho, Boqun Feng, Gary Guo, Melissa Wen,
linux-kbuild, rust-for-linux
On Sat, Feb 4, 2023 at 5:08 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal <mcanal@igalia.com> wrote:
> >
> > rust-project.json is the configuration file used by rust-analyzer.
> > As it is a configuration file and it is not needed to build external
> > modules, it should be delete by make clean. So, delete rust-project.json
> > when running make clean.
> >
> > Link: https://github.com/Rust-for-Linux/linux/issues/939
>
> Thanks Maíra! I will add a tag with Björn as a `Suggested-by`, if he
> is OK with that.
>
> Cheers,
> Miguel
Miguel,
Are you applying this to your tree,
or do you want me to pick this up?
For the former case,
Acked-by: Masahiro Yamada <masahiroy@kernel.org>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-04 17:59 ` Masahiro Yamada
@ 2023-02-04 18:04 ` Miguel Ojeda
2023-02-04 18:24 ` Masahiro Yamada
0 siblings, 1 reply; 9+ messages in thread
From: Miguel Ojeda @ 2023-02-04 18:04 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Maíra Canal, Björn Roy Baron, Michal Marek,
Nick Desaulniers, Miguel Ojeda, Alex Gaynor,
Wedson Almeida Filho, Boqun Feng, Gary Guo, Melissa Wen,
linux-kbuild, rust-for-linux
On Sat, Feb 4, 2023 at 6:59 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> Miguel,
>
> Are you applying this to your tree,
> or do you want me to pick this up?
>
> For the former case,
>
> Acked-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks! I was about to apply it, but let me know if you prefer otherwise.
Cheers,
Miguel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-04 18:04 ` Miguel Ojeda
@ 2023-02-04 18:24 ` Masahiro Yamada
0 siblings, 0 replies; 9+ messages in thread
From: Masahiro Yamada @ 2023-02-04 18:24 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Maíra Canal, Björn Roy Baron, Michal Marek,
Nick Desaulniers, Miguel Ojeda, Alex Gaynor,
Wedson Almeida Filho, Boqun Feng, Gary Guo, Melissa Wen,
linux-kbuild, rust-for-linux
On Sun, Feb 5, 2023 at 3:04 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sat, Feb 4, 2023 at 6:59 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Miguel,
> >
> > Are you applying this to your tree,
> > or do you want me to pick this up?
> >
> > For the former case,
> >
> > Acked-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Thanks! I was about to apply it, but let me know if you prefer otherwise.
>
> Cheers,
> Miguel
Please go ahead.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-03 17:37 [PATCH] rust: delete rust-project.json when running make clean Maíra Canal
2023-02-03 20:08 ` Miguel Ojeda
2023-02-04 10:12 ` Finn Behrens
@ 2023-02-04 18:41 ` Vincenzo Palazzo
2023-02-05 0:18 ` Miguel Ojeda
3 siblings, 0 replies; 9+ messages in thread
From: Vincenzo Palazzo @ 2023-02-04 18:41 UTC (permalink / raw)
To: Maíra Canal, Masahiro Yamada, Michal Marek,
Nick Desaulniers, Miguel Ojeda, Alex Gaynor,
Wedson Almeida Filho, Boqun Feng, Gary Guo, Björn Roy Baron
Cc: Melissa Wen, linux-kbuild, rust-for-linux
On Fri Feb 3, 2023 at 6:37 PM CET, Maíra Canal wrote:
> rust-project.json is the configuration file used by rust-analyzer.
> As it is a configuration file and it is not needed to build external
> modules, it should be delete by make clean. So, delete rust-project.json
> when running make clean.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/939
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
Reviewd-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f41ec8c8426b..6223d5f82f66 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1573,7 +1573,7 @@ endif # CONFIG_MODULES
> CLEAN_FILES += include/ksym vmlinux.symvers modules-only.symvers \
> modules.builtin modules.builtin.modinfo modules.nsdeps \
> compile_commands.json .thinlto-cache rust/test rust/doc \
> - .vmlinux.objs .vmlinux.export.c
> + rust-project.json .vmlinux.objs .vmlinux.export.c
>
> # Directories & files removed with 'make mrproper'
> MRPROPER_FILES += include/config include/generated \
> --
> 2.39.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] rust: delete rust-project.json when running make clean
2023-02-03 17:37 [PATCH] rust: delete rust-project.json when running make clean Maíra Canal
` (2 preceding siblings ...)
2023-02-04 18:41 ` Vincenzo Palazzo
@ 2023-02-05 0:18 ` Miguel Ojeda
3 siblings, 0 replies; 9+ messages in thread
From: Miguel Ojeda @ 2023-02-05 0:18 UTC (permalink / raw)
To: Maíra Canal
Cc: Masahiro Yamada, Michal Marek, Nick Desaulniers, Miguel Ojeda,
Alex Gaynor, Wedson Almeida Filho, Boqun Feng, Gary Guo,
Björn Roy Baron, Melissa Wen, linux-kbuild, rust-for-linux
On Fri, Feb 3, 2023 at 6:37 PM Maíra Canal <mcanal@igalia.com> wrote:
>
> rust-project.json is the configuration file used by rust-analyzer.
> As it is a configuration file and it is not needed to build external
> modules, it should be delete by make clean. So, delete rust-project.json
> when running make clean.
Applied to `rust-next`, thanks!
Cheers,
Miguel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-05 0:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-03 17:37 [PATCH] rust: delete rust-project.json when running make clean Maíra Canal
2023-02-03 20:08 ` Miguel Ojeda
2023-02-03 20:27 ` Björn Roy Baron
2023-02-04 17:59 ` Masahiro Yamada
2023-02-04 18:04 ` Miguel Ojeda
2023-02-04 18:24 ` Masahiro Yamada
2023-02-04 10:12 ` Finn Behrens
2023-02-04 18:41 ` Vincenzo Palazzo
2023-02-05 0:18 ` Miguel Ojeda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.