* [PATCH] drm/amdgpu: fix amdgpu_vm warning @ 2017-04-06 14:06 Junwei Zhang [not found] ` <1491487600-22722-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Junwei Zhang @ 2017-04-06 14:06 UTC (permalink / raw) To: alexander.deucher-5C7GfCeVMHo Cc: Junwei Zhang, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c: In function 'amdgpu_vm_bo_update_mapping': >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1207:20: warning: comparison of distinct pointer types lacks a cast [enabled by default] Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index bc2650ef..2209a6a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -1204,7 +1204,7 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev, * reserve space for one command every (1 << BLOCK_SIZE) * entries or 2k dwords (whatever is smaller) */ - ncmds = (nptes >> min(adev->vm_manager.block_size, 11)) + 1; + ncmds = (nptes >> min(adev->vm_manager.block_size, (uint32_t)11)) + 1; /* padding, etc. */ ndw = 64; -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1491487600-22722-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: fix amdgpu_vm warning [not found] ` <1491487600-22722-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> @ 2017-04-06 14:03 ` Christian König [not found] ` <9a03821d-09f4-2b69-543d-e2e460c9b67a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Christian König @ 2017-04-06 14:03 UTC (permalink / raw) To: Junwei Zhang, alexander.deucher-5C7GfCeVMHo Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Am 06.04.2017 um 16:06 schrieb Junwei Zhang: > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c: In function > 'amdgpu_vm_bo_update_mapping': >>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1207:20: warning: > comparison of distinct pointer types lacks a cast [enabled by default] > > Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > index bc2650ef..2209a6a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > @@ -1204,7 +1204,7 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev, > * reserve space for one command every (1 << BLOCK_SIZE) > * entries or 2k dwords (whatever is smaller) > */ > - ncmds = (nptes >> min(adev->vm_manager.block_size, 11)) + 1; > + ncmds = (nptes >> min(adev->vm_manager.block_size, (uint32_t)11)) + 1; Writing this as "11u" should be sufficient as well and is more convenient. With that fixed Reviewed-by: Christian König <christian.koenig@amd.com>. Regards, Christian. > > /* padding, etc. */ > ndw = 64; _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <9a03821d-09f4-2b69-543d-e2e460c9b67a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: fix amdgpu_vm warning [not found] ` <9a03821d-09f4-2b69-543d-e2e460c9b67a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> @ 2017-04-06 14:19 ` Zhang, Jerry 0 siblings, 0 replies; 3+ messages in thread From: Zhang, Jerry @ 2017-04-06 14:19 UTC (permalink / raw) To: Christian König Cc: Zhang, Jerry, Deucher, Alexander, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW > 在 2017年4月6日,22:03,Christian König <deathsimple@vodafone.de> 写道: > > Am 06.04.2017 um 16:06 schrieb Junwei Zhang: >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c: In function >> 'amdgpu_vm_bo_update_mapping': >>>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1207:20: warning: >> comparison of distinct pointer types lacks a cast [enabled by default] >> >> Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >> index bc2650ef..2209a6a 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c >> @@ -1204,7 +1204,7 @@ static int amdgpu_vm_bo_update_mapping(struct amdgpu_device *adev, >> * reserve space for one command every (1 << BLOCK_SIZE) >> * entries or 2k dwords (whatever is smaller) >> */ >> - ncmds = (nptes >> min(adev->vm_manager.block_size, 11)) + 1; >> + ncmds = (nptes >> min(adev->vm_manager.block_size, (uint32_t)11)) + 1; > > Writing this as "11u" should be sufficient as well and is more convenient. Good point. Will update. Jerry > > With that fixed Reviewed-by: Christian König <christian.koenig@amd.com>. > > Regards, > Christian. > >> /* padding, etc. */ >> ndw = 64; > > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-06 14:19 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-06 14:06 [PATCH] drm/amdgpu: fix amdgpu_vm warning Junwei Zhang [not found] ` <1491487600-22722-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 2017-04-06 14:03 ` Christian König [not found] ` <9a03821d-09f4-2b69-543d-e2e460c9b67a-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 2017-04-06 14:19 ` Zhang, Jerry
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.