All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Keith Busch <Keith.Busch@wdc.com>
Subject: Re: [PATCH v3 1/3] block: introduce zone_write_granularity limit
Date: Mon, 25 Jan 2021 05:32:05 +0000	[thread overview]
Message-ID: <BL0PR04MB6514C3C43A5E3DA84632188CE7BD9@BL0PR04MB6514.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210124100724.GA27580@lst.de

On 2021/01/24 19:07, Christoph Hellwig wrote:
> On Fri, Jan 22, 2021 at 08:56:58AM +0000, Damien Le Moal wrote:
>>> This looks a little strange.  If we special case zoned vs not zoned
>>> here anyway, why not set the zone_write_granularity to the logical
>>> block size here by default.
>>
>> The convention is zone_write_granularity == 0 for the BLK_ZONED_NONE case. Hence
>> the reset here if we force the zoned model to none for HA drives. This way, this
>> does not create a special case for HA drives used as regular disks.
> 
> Just inititialize it for all cases if you initialize it for some here.
> That way everyone but sd already gets a right default and life becomes
> simpler.

True for nullblk, and that also simplifies sd a little. But not for nvme,
blk_queue_set_zoned() is not used AND nvme_update_zone_info() is called before
nvme_update_disk_info() where the NS logical block size is set. So some
surgery/cleanups would be needed to benefit. I could add a cleanup for this, but
not entirely sure if calling nvme_update_zone_info() after
nvme_update_disk_info() is OK. Thoughts ?


-- 
Damien Le Moal
Western Digital Research

WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <Keith.Busch@wdc.com>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v3 1/3] block: introduce zone_write_granularity limit
Date: Mon, 25 Jan 2021 05:32:05 +0000	[thread overview]
Message-ID: <BL0PR04MB6514C3C43A5E3DA84632188CE7BD9@BL0PR04MB6514.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210124100724.GA27580@lst.de

On 2021/01/24 19:07, Christoph Hellwig wrote:
> On Fri, Jan 22, 2021 at 08:56:58AM +0000, Damien Le Moal wrote:
>>> This looks a little strange.  If we special case zoned vs not zoned
>>> here anyway, why not set the zone_write_granularity to the logical
>>> block size here by default.
>>
>> The convention is zone_write_granularity == 0 for the BLK_ZONED_NONE case. Hence
>> the reset here if we force the zoned model to none for HA drives. This way, this
>> does not create a special case for HA drives used as regular disks.
> 
> Just inititialize it for all cases if you initialize it for some here.
> That way everyone but sd already gets a right default and life becomes
> simpler.

True for nullblk, and that also simplifies sd a little. But not for nvme,
blk_queue_set_zoned() is not used AND nvme_update_zone_info() is called before
nvme_update_disk_info() where the NS logical block size is set. So some
surgery/cleanups would be needed to benefit. I could add a cleanup for this, but
not entirely sure if calling nvme_update_zone_info() after
nvme_update_disk_info() is OK. Thoughts ?


-- 
Damien Le Moal
Western Digital Research

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-01-25  5:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22  8:00 [PATCH v3 0/3] block: add zone write granularity limit Damien Le Moal
2021-01-22  8:00 ` Damien Le Moal
2021-01-22  8:00 ` [PATCH v3 1/3] block: introduce zone_write_granularity limit Damien Le Moal
2021-01-22  8:00   ` Damien Le Moal
2021-01-22  8:42   ` Christoph Hellwig
2021-01-22  8:42     ` Christoph Hellwig
2021-01-22  8:56     ` Damien Le Moal
2021-01-22  8:56       ` Damien Le Moal
2021-01-24 10:07       ` Christoph Hellwig
2021-01-24 10:07         ` Christoph Hellwig
2021-01-25  5:32         ` Damien Le Moal [this message]
2021-01-25  5:32           ` Damien Le Moal
2021-01-25  5:34           ` Damien Le Moal
2021-01-25  5:34             ` Damien Le Moal
2021-01-23  2:43   ` Martin K. Petersen
2021-01-23  2:43     ` Martin K. Petersen
2021-01-22  8:00 ` [PATCH v3 2/3] block: document zone_append_max_bytes attribute Damien Le Moal
2021-01-22  8:00   ` Damien Le Moal
2021-01-23  2:43   ` Martin K. Petersen
2021-01-23  2:43     ` Martin K. Petersen
2021-01-23  3:03   ` Chaitanya Kulkarni
2021-01-23  3:03     ` Chaitanya Kulkarni
2021-01-22  8:00 ` [PATCH v3 3/3] zonefs: use zone write granularity as block size Damien Le Moal
2021-01-22  8:00   ` Damien Le Moal
2021-01-22  8:42   ` Christoph Hellwig
2021-01-22  8:42     ` Christoph Hellwig
2021-01-23  2:44   ` Martin K. Petersen
2021-01-23  2:44     ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR04MB6514C3C43A5E3DA84632188CE7BD9@BL0PR04MB6514.namprd04.prod.outlook.com \
    --to=damien.lemoal@wdc.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=Keith.Busch@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.