* [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131
@ 2020-04-10 3:16 Atsushi Nemoto
2020-04-10 18:00 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Atsushi Nemoto @ 2020-04-10 3:16 UTC (permalink / raw)
To: netdev; +Cc: Yuiko Oshino, tomonori.sakita
KSZ9131 will not work with some switches due to workaround for KSZ9031
introduced in commit d2fd719bcb0e83cb39cfee22ee800f98a56eceb3
("net/phy: micrel: Add workaround for bad autoneg").
Use genphy_read_status instead of dedicated ksz9031_read_status.
Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
---
drivers/net/phy/micrel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 05d20343b816..3a4d83fa52dc 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -1204,7 +1204,7 @@ static struct phy_driver ksphy_driver[] = {
.driver_data = &ksz9021_type,
.probe = kszphy_probe,
.config_init = ksz9131_config_init,
- .read_status = ksz9031_read_status,
+ .read_status = genphy_read_status,
.ack_interrupt = kszphy_ack_interrupt,
.config_intr = kszphy_config_intr,
.get_sset_count = kszphy_get_sset_count,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131
2020-04-10 3:16 [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131 Atsushi Nemoto
@ 2020-04-10 18:00 ` Jakub Kicinski
2020-04-10 18:41 ` Yuiko.Oshino
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2020-04-10 18:00 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: netdev, Yuiko Oshino, tomonori.sakita
On Fri, 10 Apr 2020 12:16:16 +0900 (JST) Atsushi Nemoto wrote:
> KSZ9131 will not work with some switches due to workaround for KSZ9031
> introduced in commit d2fd719bcb0e83cb39cfee22ee800f98a56eceb3
> ("net/phy: micrel: Add workaround for bad autoneg").
> Use genphy_read_status instead of dedicated ksz9031_read_status.
That commit older than support for KSZ9131 itself, right?
If so we should blame this one:
Fixes: bff5b4b37372 ("net: phy: micrel: add Microchip KSZ9131 initial driver")
Yuiko, does this change look good to you?
> Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
> ---
> drivers/net/phy/micrel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 05d20343b816..3a4d83fa52dc 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -1204,7 +1204,7 @@ static struct phy_driver ksphy_driver[] = {
> .driver_data = &ksz9021_type,
> .probe = kszphy_probe,
> .config_init = ksz9131_config_init,
> - .read_status = ksz9031_read_status,
> + .read_status = genphy_read_status,
> .ack_interrupt = kszphy_ack_interrupt,
> .config_intr = kszphy_config_intr,
> .get_sset_count = kszphy_get_sset_count,
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131
2020-04-10 18:00 ` Jakub Kicinski
@ 2020-04-10 18:41 ` Yuiko.Oshino
2020-04-13 13:26 ` Yuiko.Oshino
0 siblings, 1 reply; 4+ messages in thread
From: Yuiko.Oshino @ 2020-04-10 18:41 UTC (permalink / raw)
To: kuba, atsushi.nemoto; +Cc: netdev, tomonori.sakita
>From: Jakub Kicinski <kuba@kernel.org>
>Sent: Friday, April 10, 2020 2:00 PM
>To: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
>Cc: netdev@vger.kernel.org; Yuiko Oshino - C18177
><Yuiko.Oshino@microchip.com>; tomonori.sakita@sord.co.jp
>Subject: Re: [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>content is safe
>
>On Fri, 10 Apr 2020 12:16:16 +0900 (JST) Atsushi Nemoto wrote:
>> KSZ9131 will not work with some switches due to workaround for KSZ9031
>> introduced in commit d2fd719bcb0e83cb39cfee22ee800f98a56eceb3
>> ("net/phy: micrel: Add workaround for bad autoneg").
>> Use genphy_read_status instead of dedicated ksz9031_read_status.
>
>That commit older than support for KSZ9131 itself, right?
>If so we should blame this one:
>
>Fixes: bff5b4b37372 ("net: phy: micrel: add Microchip KSZ9131 initial driver")
>
>Yuiko, does this change look good to you?
Let me check with my team and get back to you.
- Yuiko
>
>> Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
>> ---
>> drivers/net/phy/micrel.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
>> 05d20343b816..3a4d83fa52dc 100644
>> --- a/drivers/net/phy/micrel.c
>> +++ b/drivers/net/phy/micrel.c
>> @@ -1204,7 +1204,7 @@ static struct phy_driver ksphy_driver[] = {
>> .driver_data = &ksz9021_type,
>> .probe = kszphy_probe,
>> .config_init = ksz9131_config_init,
>> - .read_status = ksz9031_read_status,
>> + .read_status = genphy_read_status,
>> .ack_interrupt = kszphy_ack_interrupt,
>> .config_intr = kszphy_config_intr,
>> .get_sset_count = kszphy_get_sset_count,
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131
2020-04-10 18:41 ` Yuiko.Oshino
@ 2020-04-13 13:26 ` Yuiko.Oshino
0 siblings, 0 replies; 4+ messages in thread
From: Yuiko.Oshino @ 2020-04-13 13:26 UTC (permalink / raw)
To: kuba, atsushi.nemoto; +Cc: netdev, tomonori.sakita, UNGLinuxDriver
>From: Yuiko Oshino - C18177
>Sent: Friday, April 10, 2020 2:41 PM
>To: 'Jakub Kicinski' <kuba@kernel.org>; 'Atsushi Nemoto'
><atsushi.nemoto@sord.co.jp>
>Cc: 'netdev@vger.kernel.org' <netdev@vger.kernel.org>;
>'tomonori.sakita@sord.co.jp' <tomonori.sakita@sord.co.jp>
>Subject: RE: [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131
>
>>From: Jakub Kicinski <kuba@kernel.org>
>>Sent: Friday, April 10, 2020 2:00 PM
>>To: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
>>Cc: netdev@vger.kernel.org; Yuiko Oshino - C18177
>><Yuiko.Oshino@microchip.com>; tomonori.sakita@sord.co.jp
>>Subject: Re: [PATCH] net: phy: micrel: use genphy_read_status for
>>KSZ9131
>>
>>EXTERNAL EMAIL: Do not click links or open attachments unless you know
>>the content is safe
>>
>>On Fri, 10 Apr 2020 12:16:16 +0900 (JST) Atsushi Nemoto wrote:
>>> KSZ9131 will not work with some switches due to workaround for
>>> KSZ9031 introduced in commit d2fd719bcb0e83cb39cfee22ee800f98a56eceb3
>>> ("net/phy: micrel: Add workaround for bad autoneg").
>>> Use genphy_read_status instead of dedicated ksz9031_read_status.
>>
>>That commit older than support for KSZ9131 itself, right?
>>If so we should blame this one:
>>
>>Fixes: bff5b4b37372 ("net: phy: micrel: add Microchip KSZ9131 initial
>>driver")
>>
>>Yuiko, does this change look good to you?
>
>Let me check with my team and get back to you.
>- Yuiko
Hi Jakub and Nemoto-san,
The KSZ9031 workaround is not necessary for KSZ9131.
Please apply the new patch.
Thank you.
Yuiko
>>
>>> Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
>>> ---
>>> drivers/net/phy/micrel.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
>>> index 05d20343b816..3a4d83fa52dc 100644
>>> --- a/drivers/net/phy/micrel.c
>>> +++ b/drivers/net/phy/micrel.c
>>> @@ -1204,7 +1204,7 @@ static struct phy_driver ksphy_driver[] = {
>>> .driver_data = &ksz9021_type,
>>> .probe = kszphy_probe,
>>> .config_init = ksz9131_config_init,
>>> - .read_status = ksz9031_read_status,
>>> + .read_status = genphy_read_status,
>>> .ack_interrupt = kszphy_ack_interrupt,
>>> .config_intr = kszphy_config_intr,
>>> .get_sset_count = kszphy_get_sset_count,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-13 13:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 3:16 [PATCH] net: phy: micrel: use genphy_read_status for KSZ9131 Atsushi Nemoto
2020-04-10 18:00 ` Jakub Kicinski
2020-04-10 18:41 ` Yuiko.Oshino
2020-04-13 13:26 ` Yuiko.Oshino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.