All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: disable runtime pm on several sienna cichlid cards
@ 2022-04-27 10:11 Guchun Chen
  2022-04-27 10:15 ` Lazar, Lijo
  0 siblings, 1 reply; 3+ messages in thread
From: Guchun Chen @ 2022-04-27 10:11 UTC (permalink / raw)
  To: amd-gfx, christian.koenig, hawking.zhang, alexander.deucher,
	lijo.lazar, evan.quan
  Cc: Guchun Chen

Disable runtime power management on several sienna cichlid
cards, otherwise SMU will possibly fail to be resumed from
runtime suspend. Will drop this after a clean solution between
kernel driver and SMU FW is available.

amdgpu 0000:63:00.0: amdgpu: GECC is enabled
amdgpu 0000:63:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available
amdgpu 0000:63:00.0: amdgpu: SMU is resuming...
amdgpu 0000:63:00.0: amdgpu: SMU: I'm not done with your command: SMN_C2PMSG_66:0x0000000E SMN_C2PMSG_82:0x00000080
amdgpu 0000:63:00.0: amdgpu: Failed to SetDriverDramAddr!
amdgpu 0000:63:00.0: amdgpu: Failed to setup smc hw!
[drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <smu> failed -62
amdgpu 0000:63:00.0: amdgpu: amdgpu_device_ip_resume failed (-62)

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 262938f0dfdb..9c483787c0ca 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -180,6 +180,15 @@ int amdgpu_driver_load_kms(struct amdgpu_device *adev, unsigned long flags)
 		 */
 		if (adev->is_fw_fb)
 			adev->runpm = false;
+
+		/*
+		 * Add below quirk on several sienna_cichlid cards to disable
+		 * runtime pm to fix EMI failures.
+		 */
+		if (((adev->pdev->device == 0x73A1) && (adev->pdev->revision == 0x00)) ||
+		    ((adev->pdev->device == 0x73BF) && (adev->pdev->revision == 0xCF)))
+			adev->runpm = false;
+
 		if (adev->runpm)
 			dev_info(adev->dev, "Using BACO for runtime pm\n");
 	}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: disable runtime pm on several sienna cichlid cards
  2022-04-27 10:11 [PATCH] drm/amdgpu: disable runtime pm on several sienna cichlid cards Guchun Chen
@ 2022-04-27 10:15 ` Lazar, Lijo
  2022-04-27 10:22   ` Chen, Guchun
  0 siblings, 1 reply; 3+ messages in thread
From: Lazar, Lijo @ 2022-04-27 10:15 UTC (permalink / raw)
  To: Guchun Chen, amd-gfx, christian.koenig, hawking.zhang,
	alexander.deucher, evan.quan



On 4/27/2022 3:41 PM, Guchun Chen wrote:
> Disable runtime power management on several sienna cichlid
> cards, otherwise SMU will possibly fail to be resumed from
> runtime suspend. Will drop this after a clean solution between
> kernel driver and SMU FW is available.
> 
> amdgpu 0000:63:00.0: amdgpu: GECC is enabled
> amdgpu 0000:63:00.0: amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available
> amdgpu 0000:63:00.0: amdgpu: SMU is resuming...
> amdgpu 0000:63:00.0: amdgpu: SMU: I'm not done with your command: SMN_C2PMSG_66:0x0000000E SMN_C2PMSG_82:0x00000080
> amdgpu 0000:63:00.0: amdgpu: Failed to SetDriverDramAddr!
> amdgpu 0000:63:00.0: amdgpu: Failed to setup smc hw!
> [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <smu> failed -62
> amdgpu 0000:63:00.0: amdgpu: amdgpu_device_ip_resume failed (-62)
> 
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 262938f0dfdb..9c483787c0ca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -180,6 +180,15 @@ int amdgpu_driver_load_kms(struct amdgpu_device *adev, unsigned long flags)
>   		 */
>   		if (adev->is_fw_fb)
>   			adev->runpm = false;
> +
> +		/*
> +		 * Add below quirk on several sienna_cichlid cards to disable
> +		 * runtime pm to fix EMI failures.
> +		 */
> +		if (((adev->pdev->device == 0x73A1) && (adev->pdev->revision == 0x00)) ||
> +		    ((adev->pdev->device == 0x73BF) && (adev->pdev->revision == 0xCF)))
> +			adev->runpm = false;
> +

Separate to amdgpu_runtime_pm_quirk()?

Thanks,
Lijo

>   		if (adev->runpm)
>   			dev_info(adev->dev, "Using BACO for runtime pm\n");
>   	}
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: disable runtime pm on several sienna cichlid cards
  2022-04-27 10:15 ` Lazar, Lijo
@ 2022-04-27 10:22   ` Chen, Guchun
  0 siblings, 0 replies; 3+ messages in thread
From: Chen, Guchun @ 2022-04-27 10:22 UTC (permalink / raw)
  To: Lazar, Lijo, amd-gfx, Koenig, Christian, Zhang, Hawking, Deucher,
	Alexander, Quan, Evan

Sure, will update it in v2.

Regards,
Guchun

-----Original Message-----
From: Lazar, Lijo <Lijo.Lazar@amd.com> 
Sent: Wednesday, April 27, 2022 6:16 PM
To: Chen, Guchun <Guchun.Chen@amd.com>; amd-gfx@lists.freedesktop.org; Koenig, Christian <Christian.Koenig@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Quan, Evan <Evan.Quan@amd.com>
Subject: Re: [PATCH] drm/amdgpu: disable runtime pm on several sienna cichlid cards



On 4/27/2022 3:41 PM, Guchun Chen wrote:
> Disable runtime power management on several sienna cichlid cards, 
> otherwise SMU will possibly fail to be resumed from runtime suspend. 
> Will drop this after a clean solution between kernel driver and SMU FW 
> is available.
> 
> amdgpu 0000:63:00.0: amdgpu: GECC is enabled amdgpu 0000:63:00.0: 
> amdgpu: SECUREDISPLAY: securedisplay ta ucode is not available amdgpu 
> 0000:63:00.0: amdgpu: SMU is resuming...
> amdgpu 0000:63:00.0: amdgpu: SMU: I'm not done with your command: 
> SMN_C2PMSG_66:0x0000000E SMN_C2PMSG_82:0x00000080 amdgpu 0000:63:00.0: amdgpu: Failed to SetDriverDramAddr!
> amdgpu 0000:63:00.0: amdgpu: Failed to setup smc hw!
> [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP 
> block <smu> failed -62 amdgpu 0000:63:00.0: amdgpu: 
> amdgpu_device_ip_resume failed (-62)
> 
> Signed-off-by: Guchun Chen <guchun.chen@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index 262938f0dfdb..9c483787c0ca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -180,6 +180,15 @@ int amdgpu_driver_load_kms(struct amdgpu_device *adev, unsigned long flags)
>   		 */
>   		if (adev->is_fw_fb)
>   			adev->runpm = false;
> +
> +		/*
> +		 * Add below quirk on several sienna_cichlid cards to disable
> +		 * runtime pm to fix EMI failures.
> +		 */
> +		if (((adev->pdev->device == 0x73A1) && (adev->pdev->revision == 0x00)) ||
> +		    ((adev->pdev->device == 0x73BF) && (adev->pdev->revision == 0xCF)))
> +			adev->runpm = false;
> +

Separate to amdgpu_runtime_pm_quirk()?

Thanks,
Lijo

>   		if (adev->runpm)
>   			dev_info(adev->dev, "Using BACO for runtime pm\n");
>   	}
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-27 10:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 10:11 [PATCH] drm/amdgpu: disable runtime pm on several sienna cichlid cards Guchun Chen
2022-04-27 10:15 ` Lazar, Lijo
2022-04-27 10:22   ` Chen, Guchun

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.