* [PATCH v1] uio: dfl: add HSSI feature id
@ 2022-03-08 6:43 Tianfei Zhang
2022-03-10 19:33 ` Russ Weight
0 siblings, 1 reply; 10+ messages in thread
From: Tianfei Zhang @ 2022-03-08 6:43 UTC (permalink / raw)
To: hao.wu, trix, mdf, linux-fpga, gregkh
Cc: yilun.xu, Matthew Gerlach, Tianfei Zhang
From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Add the feature id of the OFS High Speed Serial Interface
subsystem to table of ids supported by the uio_dfl driver.
Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
---
drivers/uio/uio_dfl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
index 89c0fc7b0cbc..660e1d0bf6b9 100644
--- a/drivers/uio/uio_dfl.c
+++ b/drivers/uio/uio_dfl.c
@@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
}
#define FME_FEATURE_ID_ETH_GROUP 0x10
+#define FME_FEATURE_ID_OFS_HSSI 0x15
static const struct dfl_device_id uio_dfl_ids[] = {
{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
+ { FME_ID, FME_FEATURE_ID_OFS_HSSI },
{ }
};
MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
--
2.26.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-08 6:43 [PATCH v1] uio: dfl: add HSSI feature id Tianfei Zhang
@ 2022-03-10 19:33 ` Russ Weight
2022-03-11 2:46 ` Wu, Hao
0 siblings, 1 reply; 10+ messages in thread
From: Russ Weight @ 2022-03-10 19:33 UTC (permalink / raw)
To: Tianfei Zhang, hao.wu, trix, mdf, linux-fpga, gregkh
Cc: yilun.xu, Matthew Gerlach
On 3/7/22 22:43, Tianfei Zhang wrote:
> From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>
> Add the feature id of the OFS High Speed Serial Interface
> subsystem to table of ids supported by the uio_dfl driver.
>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> ---
> drivers/uio/uio_dfl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> index 89c0fc7b0cbc..660e1d0bf6b9 100644
> --- a/drivers/uio/uio_dfl.c
> +++ b/drivers/uio/uio_dfl.c
> @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> }
>
> #define FME_FEATURE_ID_ETH_GROUP 0x10
> +#define FME_FEATURE_ID_OFS_HSSI 0x15
>
> static const struct dfl_device_id uio_dfl_ids[] = {
> { FME_ID, FME_FEATURE_ID_ETH_GROUP },
> + { FME_ID, FME_FEATURE_ID_OFS_HSSI },
> { }
> };
> MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-10 19:33 ` Russ Weight
@ 2022-03-11 2:46 ` Wu, Hao
2022-03-11 6:14 ` Zhang, Tianfei
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hao @ 2022-03-11 2:46 UTC (permalink / raw)
To: Weight, Russell H, Zhang, Tianfei, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> On 3/7/22 22:43, Tianfei Zhang wrote:
> > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >
> > Add the feature id of the OFS High Speed Serial Interface
> > subsystem to table of ids supported by the uio_dfl driver.
> >
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
>
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > ---
> > drivers/uio/uio_dfl.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > index 89c0fc7b0cbc..660e1d0bf6b9 100644
> > --- a/drivers/uio/uio_dfl.c
> > +++ b/drivers/uio/uio_dfl.c
> > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > }
> >
> > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > +#define FME_FEATURE_ID_OFS_HSSI 0x15
Where is the "OFS" coming from? is it for all OFS device or a specific card?
Anyway, could we have a matched name per public table?
https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst
Hao
> >
> > static const struct dfl_device_id uio_dfl_ids[] = {
> > { FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > + { FME_ID, FME_FEATURE_ID_OFS_HSSI },
> > { }
> > };
> > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-11 2:46 ` Wu, Hao
@ 2022-03-11 6:14 ` Zhang, Tianfei
2022-03-14 3:08 ` Wu, Hao
0 siblings, 1 reply; 10+ messages in thread
From: Zhang, Tianfei @ 2022-03-11 6:14 UTC (permalink / raw)
To: Wu, Hao, Weight, Russell H, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> -----Original Message-----
> From: Wu, Hao <hao.wu@intel.com>
> Sent: Friday, March 11, 2022 10:47 AM
> To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> fpga@vger.kernel.org; gregkh@linuxfoundation.org
> Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> <matthew.gerlach@linux.intel.com>
> Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
>
> > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > >
> > > Add the feature id of the OFS High Speed Serial Interface subsystem
> > > to table of ids supported by the uio_dfl driver.
> > >
> > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> >
> > Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > > ---
> > > drivers/uio/uio_dfl.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > --- a/drivers/uio/uio_dfl.c
> > > +++ b/drivers/uio/uio_dfl.c
> > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > > }
> > >
> > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > +#define FME_FEATURE_ID_OFS_HSSI 0x15
>
> Where is the "OFS" coming from? is it for all OFS device or a specific card?
> Anyway, could we have a matched name per public table?
> https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst
Yes, I think a matched name of public table will be better. How about the " FME_FEATURE_ID_HSSI"?
>
> Hao
>
> > >
> > > static const struct dfl_device_id uio_dfl_ids[] = {
> > > { FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > > + { FME_ID, FME_FEATURE_ID_OFS_HSSI },
> > > { }
> > > };
> > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-11 6:14 ` Zhang, Tianfei
@ 2022-03-14 3:08 ` Wu, Hao
2022-03-14 9:45 ` Zhang, Tianfei
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hao @ 2022-03-14 3:08 UTC (permalink / raw)
To: Zhang, Tianfei, Weight, Russell H, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> > -----Original Message-----
> > From: Wu, Hao <hao.wu@intel.com>
> > Sent: Friday, March 11, 2022 10:47 AM
> > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei
> > <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> > fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > <matthew.gerlach@linux.intel.com>
> > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> >
> > > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > >
> > > > Add the feature id of the OFS High Speed Serial Interface subsystem
> > > > to table of ids supported by the uio_dfl driver.
> > > >
> > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > >
> > > Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > > > ---
> > > > drivers/uio/uio_dfl.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > > --- a/drivers/uio/uio_dfl.c
> > > > +++ b/drivers/uio/uio_dfl.c
> > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> > > > }
> > > >
> > > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15
> >
> > Where is the "OFS" coming from? is it for all OFS device or a specific card?
> > Anyway, could we have a matched name per public table?
> > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst
>
> Yes, I think a matched name of public table will be better. How about the "
> FME_FEATURE_ID_HSSI"?
No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h
#define FME_FEATURE_ID_HSSI 0x6
Need a new matched name.
Hao
>
> >
> > Hao
> >
> > > >
> > > > static const struct dfl_device_id uio_dfl_ids[] = {
> > > > { FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > > > + { FME_ID, FME_FEATURE_ID_OFS_HSSI },
> > > > { }
> > > > };
> > > > MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-14 3:08 ` Wu, Hao
@ 2022-03-14 9:45 ` Zhang, Tianfei
2022-03-15 9:32 ` Wu, Hao
0 siblings, 1 reply; 10+ messages in thread
From: Zhang, Tianfei @ 2022-03-14 9:45 UTC (permalink / raw)
To: Wu, Hao, Weight, Russell H, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> -----Original Message-----
> From: Wu, Hao <hao.wu@intel.com>
> Sent: Monday, March 14, 2022 11:09 AM
> To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> fpga@vger.kernel.org; gregkh@linuxfoundation.org
> Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> <matthew.gerlach@linux.intel.com>
> Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
>
> > > -----Original Message-----
> > > From: Wu, Hao <hao.wu@intel.com>
> > > Sent: Friday, March 11, 2022 10:47 AM
> > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei
> > > <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> > > fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > <matthew.gerlach@linux.intel.com>
> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > >
> > > > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > >
> > > > > Add the feature id of the OFS High Speed Serial Interface
> > > > > subsystem to table of ids supported by the uio_dfl driver.
> > > > >
> > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > > >
> > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > > > > ---
> > > > > drivers/uio/uio_dfl.c | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > > > --- a/drivers/uio/uio_dfl.c
> > > > > +++ b/drivers/uio/uio_dfl.c
> > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device
> > > > > *ddev) }
> > > > >
> > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15
> > >
> > > Where is the "OFS" coming from? is it for all OFS device or a specific card?
> > > Anyway, could we have a matched name per public table?
> > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature
> > > -ids.rst
> >
> > Yes, I think a matched name of public table will be better. How about the "
> > FME_FEATURE_ID_HSSI"?
>
> No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h
> #define FME_FEATURE_ID_HSSI 0x6
Is it possible change the "FME_FEATURE_ID_HSSI" to " FME_FEATURE_ID_LEGACY_HSSI", and the new one is " FME_FEATURE_ID_HSSI"?
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-14 9:45 ` Zhang, Tianfei
@ 2022-03-15 9:32 ` Wu, Hao
2022-03-15 10:18 ` Zhang, Tianfei
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hao @ 2022-03-15 9:32 UTC (permalink / raw)
To: Zhang, Tianfei, Weight, Russell H, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> > -----Original Message-----
> > From: Wu, Hao <hao.wu@intel.com>
> > Sent: Monday, March 14, 2022 11:09 AM
> > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> > fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > <matthew.gerlach@linux.intel.com>
> > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> >
> > > > -----Original Message-----
> > > > From: Wu, Hao <hao.wu@intel.com>
> > > > Sent: Friday, March 11, 2022 10:47 AM
> > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang, Tianfei
> > > > <tianfei.zhang@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> > > > fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > > <matthew.gerlach@linux.intel.com>
> > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > > >
> > > > > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > >
> > > > > > Add the feature id of the OFS High Speed Serial Interface
> > > > > > subsystem to table of ids supported by the uio_dfl driver.
> > > > > >
> > > > > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > > > >
> > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > > > > > ---
> > > > > > drivers/uio/uio_dfl.c | 2 ++
> > > > > > 1 file changed, 2 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c index
> > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > > > > --- a/drivers/uio/uio_dfl.c
> > > > > > +++ b/drivers/uio/uio_dfl.c
> > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device
> > > > > > *ddev) }
> > > > > >
> > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15
> > > >
> > > > Where is the "OFS" coming from? is it for all OFS device or a specific card?
> > > > Anyway, could we have a matched name per public table?
> > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature
> > > > -ids.rst
> > >
> > > Yes, I think a matched name of public table will be better. How about the "
> > > FME_FEATURE_ID_HSSI"?
> >
> > No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h
> > #define FME_FEATURE_ID_HSSI 0x6
>
> Is it possible change the "FME_FEATURE_ID_HSSI" to "
> FME_FEATURE_ID_LEGACY_HSSI", and the new one is "
> FME_FEATURE_ID_HSSI"?
I am not sure who owns the ID allocation table, and why
0x6 is changed to "Legacy" HSSI but I feel it's better to
have a specific prefix for this HSSI instead, I hope we don't
have to change this 0x15 HSSI to another legacy one when
someone adds a new HSSI. This is for FPGA, everybody
could implement his own HSSI, generic name should
be avoid when possible, and a better rule when managing
the feature IDs.
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-15 9:32 ` Wu, Hao
@ 2022-03-15 10:18 ` Zhang, Tianfei
2022-03-17 0:41 ` Wu, Hao
0 siblings, 1 reply; 10+ messages in thread
From: Zhang, Tianfei @ 2022-03-15 10:18 UTC (permalink / raw)
To: Wu, Hao, Weight, Russell H, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> -----Original Message-----
> From: Wu, Hao <hao.wu@intel.com>
> Sent: Tuesday, March 15, 2022 5:32 PM
> To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> fpga@vger.kernel.org; gregkh@linuxfoundation.org
> Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> <matthew.gerlach@linux.intel.com>
> Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
>
> > > -----Original Message-----
> > > From: Wu, Hao <hao.wu@intel.com>
> > > Sent: Monday, March 14, 2022 11:09 AM
> > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org;
> > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > <matthew.gerlach@linux.intel.com>
> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > >
> > > > > -----Original Message-----
> > > > > From: Wu, Hao <hao.wu@intel.com>
> > > > > Sent: Friday, March 11, 2022 10:47 AM
> > > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang,
> > > > > Tianfei <tianfei.zhang@intel.com>; trix@redhat.com;
> > > > > mdf@kernel.org; linux- fpga@vger.kernel.org;
> > > > > gregkh@linuxfoundation.org
> > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > > > <matthew.gerlach@linux.intel.com>
> > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > > > >
> > > > > > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > > >
> > > > > > > Add the feature id of the OFS High Speed Serial Interface
> > > > > > > subsystem to table of ids supported by the uio_dfl driver.
> > > > > > >
> > > > > > > Signed-off-by: Matthew Gerlach
> > > > > > > <matthew.gerlach@linux.intel.com>
> > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > > > > >
> > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > > > > > > ---
> > > > > > > drivers/uio/uio_dfl.c | 2 ++
> > > > > > > 1 file changed, 2 insertions(+)
> > > > > > >
> > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > > > > > > index
> > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > > > > > --- a/drivers/uio/uio_dfl.c
> > > > > > > +++ b/drivers/uio/uio_dfl.c
> > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct
> > > > > > > dfl_device
> > > > > > > *ddev) }
> > > > > > >
> > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15
> > > > >
> > > > > Where is the "OFS" coming from? is it for all OFS device or a specific
> card?
> > > > > Anyway, could we have a matched name per public table?
> > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-fea
> > > > > ture
> > > > > -ids.rst
> > > >
> > > > Yes, I think a matched name of public table will be better. How about the "
> > > > FME_FEATURE_ID_HSSI"?
> > >
> > > No. We already have the same name for id 0x6 defined in drivers/fpga/dfl.h
> > > #define FME_FEATURE_ID_HSSI 0x6
> >
> > Is it possible change the "FME_FEATURE_ID_HSSI" to "
> > FME_FEATURE_ID_LEGACY_HSSI", and the new one is "
> > FME_FEATURE_ID_HSSI"?
>
> I am not sure who owns the ID allocation table, and why
> 0x6 is changed to "Legacy" HSSI but I feel it's better to have a specific prefix for
> this HSSI instead, I hope we don't have to change this 0x15 HSSI to another
> legacy one when someone adds a new HSSI. This is for FPGA, everybody could
> implement his own HSSI, generic name should be avoid when possible, and a
> better rule when managing the feature IDs.
Yes, I think this HSSI was designed for OFS, using "OFS" as prefix is better.
>
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-15 10:18 ` Zhang, Tianfei
@ 2022-03-17 0:41 ` Wu, Hao
2022-03-30 6:59 ` Zhang, Tianfei
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hao @ 2022-03-17 0:41 UTC (permalink / raw)
To: Zhang, Tianfei, Weight, Russell H, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> > -----Original Message-----
> > From: Wu, Hao <hao.wu@intel.com>
> > Sent: Tuesday, March 15, 2022 5:32 PM
> > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> > fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > <matthew.gerlach@linux.intel.com>
> > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> >
> > > > -----Original Message-----
> > > > From: Wu, Hao <hao.wu@intel.com>
> > > > Sent: Monday, March 14, 2022 11:09 AM
> > > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> > > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org;
> > > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > > <matthew.gerlach@linux.intel.com>
> > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > > >
> > > > > > -----Original Message-----
> > > > > > From: Wu, Hao <hao.wu@intel.com>
> > > > > > Sent: Friday, March 11, 2022 10:47 AM
> > > > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang,
> > > > > > Tianfei <tianfei.zhang@intel.com>; trix@redhat.com;
> > > > > > mdf@kernel.org; linux- fpga@vger.kernel.org;
> > > > > > gregkh@linuxfoundation.org
> > > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > > > > <matthew.gerlach@linux.intel.com>
> > > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > > > > >
> > > > > > > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > > > >
> > > > > > > > Add the feature id of the OFS High Speed Serial Interface
> > > > > > > > subsystem to table of ids supported by the uio_dfl driver.
> > > > > > > >
> > > > > > > > Signed-off-by: Matthew Gerlach
> > > > > > > > <matthew.gerlach@linux.intel.com>
> > > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > > > > > >
> > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > > > > > > > ---
> > > > > > > > drivers/uio/uio_dfl.c | 2 ++
> > > > > > > > 1 file changed, 2 insertions(+)
> > > > > > > >
> > > > > > > > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > > > > > > > index
> > > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > > > > > > --- a/drivers/uio/uio_dfl.c
> > > > > > > > +++ b/drivers/uio/uio_dfl.c
> > > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct
> > > > > > > > dfl_device
> > > > > > > > *ddev) }
> > > > > > > >
> > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15
> > > > > >
> > > > > > Where is the "OFS" coming from? is it for all OFS device or a specific
> > card?
> > > > > > Anyway, could we have a matched name per public table?
> > > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-fea
> > > > > > ture
> > > > > > -ids.rst
> > > > >
> > > > > Yes, I think a matched name of public table will be better. How about the
> "
> > > > > FME_FEATURE_ID_HSSI"?
> > > >
> > > > No. We already have the same name for id 0x6 defined in
> drivers/fpga/dfl.h
> > > > #define FME_FEATURE_ID_HSSI 0x6
> > >
> > > Is it possible change the "FME_FEATURE_ID_HSSI" to "
> > > FME_FEATURE_ID_LEGACY_HSSI", and the new one is "
> > > FME_FEATURE_ID_HSSI"?
> >
> > I am not sure who owns the ID allocation table, and why
> > 0x6 is changed to "Legacy" HSSI but I feel it's better to have a specific prefix
> for
> > this HSSI instead, I hope we don't have to change this 0x15 HSSI to another
> > legacy one when someone adds a new HSSI. This is for FPGA, everybody could
> > implement his own HSSI, generic name should be avoid when possible, and a
> > better rule when managing the feature IDs.
>
> Yes, I think this HSSI was designed for OFS, using "OFS" as prefix is better.
Then change the name in
https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst
as well.
Hao
>
> >
> > >
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v1] uio: dfl: add HSSI feature id
2022-03-17 0:41 ` Wu, Hao
@ 2022-03-30 6:59 ` Zhang, Tianfei
0 siblings, 0 replies; 10+ messages in thread
From: Zhang, Tianfei @ 2022-03-30 6:59 UTC (permalink / raw)
To: Wu, Hao, Weight, Russell H, trix, mdf, linux-fpga, gregkh
Cc: Xu, Yilun, Matthew Gerlach
> -----Original Message-----
> From: Wu, Hao <hao.wu@intel.com>
> Sent: Thursday, March 17, 2022 8:42 AM
> To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org; linux-
> fpga@vger.kernel.org; gregkh@linuxfoundation.org
> Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> <matthew.gerlach@linux.intel.com>
> Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
>
> > > -----Original Message-----
> > > From: Wu, Hao <hao.wu@intel.com>
> > > Sent: Tuesday, March 15, 2022 5:32 PM
> > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org;
> > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > <matthew.gerlach@linux.intel.com>
> > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > >
> > > > > -----Original Message-----
> > > > > From: Wu, Hao <hao.wu@intel.com>
> > > > > Sent: Monday, March 14, 2022 11:09 AM
> > > > > To: Zhang, Tianfei <tianfei.zhang@intel.com>; Weight, Russell H
> > > > > <russell.h.weight@intel.com>; trix@redhat.com; mdf@kernel.org;
> > > > > linux- fpga@vger.kernel.org; gregkh@linuxfoundation.org
> > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > > > <matthew.gerlach@linux.intel.com>
> > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Wu, Hao <hao.wu@intel.com>
> > > > > > > Sent: Friday, March 11, 2022 10:47 AM
> > > > > > > To: Weight, Russell H <russell.h.weight@intel.com>; Zhang,
> > > > > > > Tianfei <tianfei.zhang@intel.com>; trix@redhat.com;
> > > > > > > mdf@kernel.org; linux- fpga@vger.kernel.org;
> > > > > > > gregkh@linuxfoundation.org
> > > > > > > Cc: Xu, Yilun <yilun.xu@intel.com>; Matthew Gerlach
> > > > > > > <matthew.gerlach@linux.intel.com>
> > > > > > > Subject: RE: [PATCH v1] uio: dfl: add HSSI feature id
> > > > > > >
> > > > > > > > On 3/7/22 22:43, Tianfei Zhang wrote:
> > > > > > > > > From: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > > > > > >
> > > > > > > > > Add the feature id of the OFS High Speed Serial
> > > > > > > > > Interface subsystem to table of ids supported by the uio_dfl
> driver.
> > > > > > > > >
> > > > > > > > > Signed-off-by: Matthew Gerlach
> > > > > > > > > <matthew.gerlach@linux.intel.com>
> > > > > > > > > Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> > > > > > > >
> > > > > > > > Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > > > > > > > > ---
> > > > > > > > > drivers/uio/uio_dfl.c | 2 ++
> > > > > > > > > 1 file changed, 2 insertions(+)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/uio/uio_dfl.c
> > > > > > > > > b/drivers/uio/uio_dfl.c index
> > > > > > > > > 89c0fc7b0cbc..660e1d0bf6b9 100644
> > > > > > > > > --- a/drivers/uio/uio_dfl.c
> > > > > > > > > +++ b/drivers/uio/uio_dfl.c
> > > > > > > > > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct
> > > > > > > > > dfl_device
> > > > > > > > > *ddev) }
> > > > > > > > >
> > > > > > > > > #define FME_FEATURE_ID_ETH_GROUP 0x10
> > > > > > > > > +#define FME_FEATURE_ID_OFS_HSSI 0x15
> > > > > > >
> > > > > > > Where is the "OFS" coming from? is it for all OFS device or
> > > > > > > a specific
> > > card?
> > > > > > > Anyway, could we have a matched name per public table?
> > > > > > > https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl
> > > > > > > -fea
> > > > > > > ture
> > > > > > > -ids.rst
> > > > > >
> > > > > > Yes, I think a matched name of public table will be better.
> > > > > > How about the
> > "
> > > > > > FME_FEATURE_ID_HSSI"?
> > > > >
> > > > > No. We already have the same name for id 0x6 defined in
> > drivers/fpga/dfl.h
> > > > > #define FME_FEATURE_ID_HSSI 0x6
> > > >
> > > > Is it possible change the "FME_FEATURE_ID_HSSI" to "
> > > > FME_FEATURE_ID_LEGACY_HSSI", and the new one is "
> > > > FME_FEATURE_ID_HSSI"?
> > >
> > > I am not sure who owns the ID allocation table, and why
> > > 0x6 is changed to "Legacy" HSSI but I feel it's better to have a
> > > specific prefix
> > for
> > > this HSSI instead, I hope we don't have to change this 0x15 HSSI to
> > > another legacy one when someone adds a new HSSI. This is for FPGA,
> > > everybody could implement his own HSSI, generic name should be avoid
> > > when possible, and a better rule when managing the feature IDs.
> >
> > Yes, I think this HSSI was designed for OFS, using "OFS" as prefix is better.
>
> Then change the name in
> https://github.com/OPAE/linux-dfl-feature-id/blob/master/dfl-feature-ids.rst
> as well.
Thanks Hao's comment, it has changed to " OFS HSSI Subsystem" in this git repo.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-03-30 7:01 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 6:43 [PATCH v1] uio: dfl: add HSSI feature id Tianfei Zhang
2022-03-10 19:33 ` Russ Weight
2022-03-11 2:46 ` Wu, Hao
2022-03-11 6:14 ` Zhang, Tianfei
2022-03-14 3:08 ` Wu, Hao
2022-03-14 9:45 ` Zhang, Tianfei
2022-03-15 9:32 ` Wu, Hao
2022-03-15 10:18 ` Zhang, Tianfei
2022-03-17 0:41 ` Wu, Hao
2022-03-30 6:59 ` Zhang, Tianfei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.