All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Deucher <alexdeucher@gmail.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"Zhang, Morris" <Shiwu.Zhang@amd.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: RE: [PATCH] drm/amdgpu: add the accelerator pcie class
Date: Tue, 30 May 2023 18:22:43 +0000	[thread overview]
Message-ID: <BL1PR12MB5144051B528AE6BB7F30B729F74B9@BL1PR12MB5144.namprd12.prod.outlook.com> (raw)
In-Reply-To: <ZHBXzItiT1+OSsjX@infradead.org>

[Public]

> -----Original Message-----
> From: Christoph Hellwig <hch@infradead.org>
> Sent: Friday, May 26, 2023 2:55 AM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>
> Cc: Christoph Hellwig <hch@infradead.org>; Alex Deucher
> <alexdeucher@gmail.com>; bhelgaas@google.com; amd-
> gfx@lists.freedesktop.org; Zhang, Morris <Shiwu.Zhang@amd.com>; linux-
> pci@vger.kernel.org
> Subject: Re: [PATCH] drm/amdgpu: add the accelerator pcie class
>
> On Thu, May 25, 2023 at 08:52:06PM +0000, Deucher, Alexander wrote:
> > We already handle this today for CLASS_DISPLAY via a data table provided on
> our hardware that details the components on the board.  The driver can then
> determine whether or not that combination of components is supported.  If
> the data table doesn't exist or isn’t parse-able, or the components
> enumerated are not supported, the driver doesn't load.
>
> But things like module loading and initramfs generation still work off the ID
> table and not your internal tables.

Sure, and everything still works fine.  If the device is too new and the driver doesn't have support for it, it doesn't bind and returns -ENODEV when it probes the device.

Alex


WARNING: multiple messages have this Message-ID (diff)
From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Deucher <alexdeucher@gmail.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"Zhang, Morris" <Shiwu.Zhang@amd.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: RE: [PATCH] drm/amdgpu: add the accelerator pcie class
Date: Tue, 30 May 2023 18:22:43 +0000	[thread overview]
Message-ID: <BL1PR12MB5144051B528AE6BB7F30B729F74B9@BL1PR12MB5144.namprd12.prod.outlook.com> (raw)
In-Reply-To: <ZHBXzItiT1+OSsjX@infradead.org>

[Public]

> -----Original Message-----
> From: Christoph Hellwig <hch@infradead.org>
> Sent: Friday, May 26, 2023 2:55 AM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>
> Cc: Christoph Hellwig <hch@infradead.org>; Alex Deucher
> <alexdeucher@gmail.com>; bhelgaas@google.com; amd-
> gfx@lists.freedesktop.org; Zhang, Morris <Shiwu.Zhang@amd.com>; linux-
> pci@vger.kernel.org
> Subject: Re: [PATCH] drm/amdgpu: add the accelerator pcie class
>
> On Thu, May 25, 2023 at 08:52:06PM +0000, Deucher, Alexander wrote:
> > We already handle this today for CLASS_DISPLAY via a data table provided on
> our hardware that details the components on the board.  The driver can then
> determine whether or not that combination of components is supported.  If
> the data table doesn't exist or isn’t parse-able, or the components
> enumerated are not supported, the driver doesn't load.
>
> But things like module loading and initramfs generation still work off the ID
> table and not your internal tables.

Sure, and everything still works fine.  If the device is too new and the driver doesn't have support for it, it doesn't bind and returns -ENODEV when it probes the device.

Alex


  reply	other threads:[~2023-05-30 18:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23  4:02 [PATCH] drm/amdgpu: add the accelerator pcie class Shiwu Zhang
2023-05-23  4:12 ` Zhang, Morris
2023-05-23  6:37 ` Christoph Hellwig
2023-05-23  6:37   ` Christoph Hellwig
2023-05-23 14:02   ` Alex Deucher
2023-05-23 14:02     ` Alex Deucher
2023-05-25  9:46     ` Christoph Hellwig
2023-05-25  9:46       ` Christoph Hellwig
2023-05-25 20:52       ` Deucher, Alexander
2023-05-25 20:52         ` Deucher, Alexander
2023-05-26  6:55         ` Christoph Hellwig
2023-05-26  6:55           ` Christoph Hellwig
2023-05-30 18:22           ` Deucher, Alexander [this message]
2023-05-30 18:22             ` Deucher, Alexander
2023-06-08 19:52 ` Bjorn Helgaas
2023-06-08 19:52   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL1PR12MB5144051B528AE6BB7F30B729F74B9@BL1PR12MB5144.namprd12.prod.outlook.com \
    --to=alexander.deucher@amd.com \
    --cc=Shiwu.Zhang@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bhelgaas@google.com \
    --cc=hch@infradead.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.